René's URL Explorer Experiment


Title: JobUpdateTask cleanups by ches · Pull Request #650 · feast-dev/feast · GitHub

Open Graph Title: JobUpdateTask cleanups by ches · Pull Request #650 · feast-dev/feast

X Title: JobUpdateTask cleanups by ches · Pull Request #650 · feast-dev/feast

Description: The Open Source Feature Store for AI/ML. Contribute to feast-dev/feast development by creating an account on GitHub.

Open Graph Description: What this PR does / why we need it: Cleanup, this is purely refactoring aiming to make code easier to read, understand, and modify. I've been doing some work—and reviews of work—around this cod...

X Description: What this PR does / why we need it: Cleanup, this is purely refactoring aiming to make code easier to read, understand, and modify. I've been doing some work—and reviews of work—around this...

Opengraph URL: https://github.com/feast-dev/feast/pull/650

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:1bf4757e-4d9e-1822-b532-3bb90e38296f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA28E:1AB1F7:321DC1:410F92:697DCD50
html-safe-noncea1ce93b4c806a9cecd47a3fb582d0fb8d44a76768bd0af5f61e9a92d5f795d91
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjhFOjFBQjFGNzozMjFEQzE6NDEwRjkyOjY5N0RDRDUwIiwidmlzaXRvcl9pZCI6IjY2MzcwMDM0ODk1ODA3OTcyNjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3badd8add7c5133957669ac8995b3ac689b1bdded6ac22f4cc8f7a6ccd3a6476
hovercard-subject-tagpull_request:408956150
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/650/commits
twitter:imagehttps://opengraph.githubassets.com/2773831f3f9f3cf146c886b002097da3e65351965964211781ca878064d26248/feast-dev/feast/pull/650
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2773831f3f9f3cf146c886b002097da3e65351965964211781ca878064d26248/feast-dev/feast/pull/650
og:image:altWhat this PR does / why we need it: Cleanup, this is purely refactoring aiming to make code easier to read, understand, and modify. I've been doing some work—and reviews of work—around this cod...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameches
hostnamegithub.com
expected-hostnamegithub.com
None60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6
turbo-cache-controlno-cache
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7c85641c598ad130c74f7bcc27f58575cac69551
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/650/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F650%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F650%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/650/commits
Reloadhttps://github.com/feast-dev/feast/pull/650/commits
Reloadhttps://github.com/feast-dev/feast/pull/650/commits
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 183 https://github.com/feast-dev/feast/issues
Pull requests 68 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
feast-ci-bothttps://github.com/feast-ci-bot
masterhttps://github.com/feast-dev/feast/tree/master
JobUpdateTask-cleanuphttps://github.com/feast-dev/feast/tree/JobUpdateTask-cleanup
Conversationhttps://github.com/feast-dev/feast/pull/650
Commits7 (7)https://github.com/feast-dev/feast/pull/650/commits
Checkshttps://github.com/feast-dev/feast/pull/650/checks
Files changedhttps://github.com/feast-dev/feast/pull/650/changes
JobUpdateTask cleanupshttps://github.com/feast-dev/feast/pull/650/commits#top
feast-ci-bothttps://github.com/feast-ci-bot
masterhttps://github.com/feast-dev/feast/tree/master
JobUpdateTask-cleanuphttps://github.com/feast-dev/feast/tree/JobUpdateTask-cleanup
core: Clean up repetition in JobUpdateTaskhttps://github.com/feast-dev/feast/pull/650/commits/ac1143dcde7d39f91cec66b60448450856daea79
https://github.com/ches
cheshttps://github.com/feast-dev/feast/commits?author=ches
ac1143dhttps://github.com/feast-dev/feast/pull/650/commits/ac1143dcde7d39f91cec66b60448450856daea79
https://github.com/feast-dev/feast/tree/ac1143dcde7d39f91cec66b60448450856daea79
core: Reduce noise of AuditLogger in JobUpdateTaskhttps://github.com/feast-dev/feast/pull/650/commits/59f0352b37d882d03ea1b6a79146566b7854793e
https://github.com/ches
cheshttps://github.com/feast-dev/feast/commits?author=ches
59f0352https://github.com/feast-dev/feast/pull/650/commits/59f0352b37d882d03ea1b6a79146566b7854793e
https://github.com/feast-dev/feast/tree/59f0352b37d882d03ea1b6a79146566b7854793e
core: Simplify JobUpdateTask internal helper callshttps://github.com/feast-dev/feast/pull/650/commits/5871d134b2f8d9753d0fed5c4d2888028e28ef97
https://github.com/ches
cheshttps://github.com/feast-dev/feast/commits?author=ches
5871d13https://github.com/feast-dev/feast/pull/650/commits/5871d134b2f8d9753d0fed5c4d2888028e28ef97
https://github.com/feast-dev/feast/tree/5871d134b2f8d9753d0fed5c4d2888028e28ef97
core: Make isTerminal an instance property of JobStatushttps://github.com/feast-dev/feast/pull/650/commits/25b9dcb69d72f08d4391928852f449dac11d0852
https://github.com/ches
cheshttps://github.com/feast-dev/feast/commits?author=ches
25b9dcbhttps://github.com/feast-dev/feast/pull/650/commits/25b9dcb69d72f08d4391928852f449dac11d0852
https://github.com/feast-dev/feast/tree/25b9dcb69d72f08d4391928852f449dac11d0852
core: Remove test setup duplication in JobUpdateTaskTesthttps://github.com/feast-dev/feast/pull/650/commits/b5e0ce8a504bd2aa87615f39a8ba6997d7ebc1d3
https://github.com/ches
cheshttps://github.com/feast-dev/feast/commits?author=ches
b5e0ce8https://github.com/feast-dev/feast/pull/650/commits/b5e0ce8a504bd2aa87615f39a8ba6997d7ebc1d3
https://github.com/feast-dev/feast/tree/b5e0ce8a504bd2aa87615f39a8ba6997d7ebc1d3
core: Add unit tests for JobStatushttps://github.com/feast-dev/feast/pull/650/commits/15cc078598101279c6107d61bd5a0504a08b2ad6
https://github.com/ches
cheshttps://github.com/feast-dev/feast/commits?author=ches
15cc078https://github.com/feast-dev/feast/pull/650/commits/15cc078598101279c6107d61bd5a0504a08b2ad6
https://github.com/feast-dev/feast/tree/15cc078598101279c6107d61bd5a0504a08b2ad6
core: Refactor JobUpdateTask to use domain model typeshttps://github.com/feast-dev/feast/pull/650/commits/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915
https://github.com/ches
cheshttps://github.com/feast-dev/feast/commits?author=ches
ded7ca5https://github.com/feast-dev/feast/pull/650/commits/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915
https://github.com/feast-dev/feast/tree/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.