Title: JobUpdateTask cleanups by ches · Pull Request #650 · feast-dev/feast · GitHub
Open Graph Title: JobUpdateTask cleanups by ches · Pull Request #650 · feast-dev/feast
X Title: JobUpdateTask cleanups by ches · Pull Request #650 · feast-dev/feast
Description: What this PR does / why we need it: Cleanup, this is purely refactoring aiming to make code easier to read, understand, and modify. I've been doing some work—and reviews of work—around this code, and found it a bit hard to follow and work with. This is my attempt at improving that. This PR is meant to be reviewed commit-by-commit, it should hopefully make sense quickly that way. Tests are untouched until the final commit and should pass at every step. I have a question or two though that I'll ask inline, so I'm marking this WIP, I may update a bit more based on the answers, especially docstrings where warranted. Which issue(s) this PR fixes: No issue Does this PR introduce a user-facing change?: NONE
Open Graph Description: What this PR does / why we need it: Cleanup, this is purely refactoring aiming to make code easier to read, understand, and modify. I've been doing some work—and reviews of work—around this cod...
X Description: What this PR does / why we need it: Cleanup, this is purely refactoring aiming to make code easier to read, understand, and modify. I've been doing some work—and reviews of work—around this...
Opengraph URL: https://github.com/feast-dev/feast/pull/650
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:19bcfb2e-f1ba-d733-c144-d37112a2c0d2 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | AD5C:15DF6C:2728BFA:36840C5:697CC71B |
| html-safe-nonce | 3deaa6fa9148616f6479887d603bcf5cdff817fd7b5db80b2c1879eaf8a95f67 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDVDOjE1REY2QzoyNzI4QkZBOjM2ODQwQzU6Njk3Q0M3MUIiLCJ2aXNpdG9yX2lkIjoiODY0NzkwMTk3MjA2NzU2NzM4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 597659f9130744352ca38163a274af10ff7a3d1bf57b81eb82b46cdcaaefe137 |
| hovercard-subject-tag | pull_request:408956150 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/650/checks |
| twitter:image | https://avatars.githubusercontent.com/u/13277?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/13277?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: Cleanup, this is purely refactoring aiming to make code easier to read, understand, and modify. I've been doing some work—and reviews of work—around this cod... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d4c783778d5800630f3410c71c48893af4e0b2c5fc0c3d1b496c01fbaf3dc168 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5692c2ac29cb639a6b80b3e5e21feed6755366b6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width