| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a7941009-a1a0-fa18-e7a4-26e6ae9b6fcc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B20C:2A8767:19F5D50:240A901:697C9565 |
| html-safe-nonce | 602e552f2ecfed3862824b617dedfadba1cd1fdc24fe2bb690329d32bee691c1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjBDOjJBODc2NzoxOUY1RDUwOjI0MEE5MDE6Njk3Qzk1NjUiLCJ2aXNpdG9yX2lkIjoiMjA4NTA1MTE1MDQ1NjYyNDQ4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2b180f8177d23cb344cf8fd0cbc9e1af3d50c3d8fef02886b96ba9a6282b6179 |
| hovercard-subject-tag | pull_request:408956150 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/650/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2773831f3f9f3cf146c886b002097da3e65351965964211781ca878064d26248/feast-dev/feast/pull/650 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2773831f3f9f3cf146c886b002097da3e65351965964211781ca878064d26248/feast-dev/feast/pull/650 |
| og:image:alt | What this PR does / why we need it:
Cleanup, this is purely refactoring aiming to make code easier to read, understand, and modify.
I've been doing some work—and reviews of work—around this cod... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ches |
| hostname | github.com |
| expected-hostname | github.com |
| None | f30e23787c843d478679169eb69bc1bf04c9aaf526e14cad93570a516ad7b047 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0bf17967680d17d40933881af78023e6675fa045 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/650#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F650 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F650 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/650 |
| Reload | https://github.com/feast-dev/feast/pull/650 |
| Reload | https://github.com/feast-dev/feast/pull/650 |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
182
| https://github.com/feast-dev/feast/issues |
|
Pull requests
66
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/feast-dev/feast/pull/650#issue-comment-box |
| feast-ci-bot | https://github.com/feast-ci-bot |
| master | https://github.com/feast-dev/feast/tree/master |
| JobUpdateTask-cleanup | https://github.com/feast-dev/feast/tree/JobUpdateTask-cleanup |
|
JobUpdateTask cleanups
| https://github.com/feast-dev/feast/pull/650#top |
| feast-ci-bot | https://github.com/feast-ci-bot |
| master | https://github.com/feast-dev/feast/tree/master |
| JobUpdateTask-cleanup | https://github.com/feast-dev/feast/tree/JobUpdateTask-cleanup |
|
Conversation
41
| https://github.com/feast-dev/feast/pull/650 |
|
Commits
7
| https://github.com/feast-dev/feast/pull/650/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/650/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/650/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
|
| https://github.com/ches |
| ches | https://github.com/ches |
| Apr 25, 2020 | https://github.com/feast-dev/feast/pull/650#issue-606836036 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/ches |
| ches | https://github.com/ches |
|
do-not-merge/work-in-progress
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fwork-in-progress |
| Apr 25, 2020 | https://github.com/feast-dev/feast/pull/650#event-3272205466 |
| https://github.com/ches |
| ches | https://github.com/ches |
| mrzzy | https://github.com/mrzzy |
| zhilingc | https://github.com/zhilingc |
| April 25, 2020 19:11 | https://github.com/feast-dev/feast/pull/650#event-3272205467 |
| https://github.com/ches |
| ches | https://github.com/ches |
| pradithya | https://github.com/pradithya |
| code owner | https://github.com/feast-dev/feast/blob/e5bc18c6833f742a954c1325764721b96f31faa1/.github/CODEOWNERS#L5 |
| April 25, 2020 19:11 | https://github.com/feast-dev/feast/pull/650#event-3272205470 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
size/L
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL |
|
do-not-merge/work-in-progress
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fwork-in-progress |
| Apr 25, 2020 | https://github.com/feast-dev/feast/pull/650#event-3272205476 |
| https://github.com/ches |
| ches | https://github.com/ches |
|
Apr 25, 2020
| https://github.com/feast-dev/feast/pull/650#pullrequestreview-400423586 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/650/files |
| core/src/main/java/feast/core/service/JobService.java | https://github.com/feast-dev/feast/pull/650/files#diff-2d7c4b0863b06e44e7186367d8612e7e4b9be9841efb113841b37268f46d2023 |
| ches | https://github.com/ches |
| Apr 25, 2020 | https://github.com/feast-dev/feast/pull/650#discussion_r415125907 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @mrzzy | https://github.com/mrzzy |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| mrzzy | https://github.com/mrzzy |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/650#discussion_r415496934 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/ches |
| ches | https://github.com/ches |
|
Apr 25, 2020
| https://github.com/feast-dev/feast/pull/650#pullrequestreview-400425359 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/650/files |
| core/src/main/java/feast/core/job/JobUpdateTask.java | https://github.com/feast-dev/feast/pull/650/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f |
| ches | https://github.com/ches |
| Apr 25, 2020 | https://github.com/feast-dev/feast/pull/650#discussion_r415130044 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @zhilingc | https://github.com/zhilingc |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| zhilingc | https://github.com/zhilingc |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/650#discussion_r415472243 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/ches |
| ches | https://github.com/ches |
|
Apr 25, 2020
| https://github.com/feast-dev/feast/pull/650#pullrequestreview-400426597 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/650/files |
| core/src/main/java/feast/core/job/JobUpdateTask.java | https://github.com/feast-dev/feast/pull/650/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/ches |
| ches | https://github.com/ches |
|
Apr 25, 2020
| https://github.com/feast-dev/feast/pull/650#pullrequestreview-400427323 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/650/files |
| core/src/main/java/feast/core/job/JobUpdateTask.java | https://github.com/feast-dev/feast/pull/650/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/ches |
| ches | https://github.com/ches |
|
Apr 25, 2020
| https://github.com/feast-dev/feast/pull/650#pullrequestreview-400428185 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/650/files |
| core/src/main/java/feast/core/model/JobStatus.java | https://github.com/feast-dev/feast/pull/650/files#diff-d80cd248b30f221ad8a435548b47b850cd2806ae20c275fcf3b53ac8a53b813f |
| ches | https://github.com/ches |
| Apr 25, 2020 | https://github.com/feast-dev/feast/pull/650#discussion_r415136744 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| zhilingc | https://github.com/zhilingc |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/650#discussion_r415472973 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/ches |
| ches | https://github.com/ches |
| Apr 26, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-619477601 |
| @pradithya | https://github.com/pradithya |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| pradithya | https://github.com/pradithya |
| Apr 26, 2020 | https://github.com/feast-dev/feast/pull/650#event-3272516003 |
| https://github.com/ches |
| ches | https://github.com/ches |
|
Apr 26, 2020
| https://github.com/feast-dev/feast/pull/650#ref-pullrequest-606945748 |
|
core: Use Runner enum type instead of string for Job model
#651
| https://github.com/feast-dev/feast/pull/651 |
| https://github.com/zhilingc |
| zhilingc | https://github.com/zhilingc |
| Apr 26, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-619581207 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/zhilingc |
| zhilingc | https://github.com/zhilingc |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-619679662 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/zhilingc |
| zhilingc | https://github.com/zhilingc |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-619679696 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/zhilingc |
| zhilingc | https://github.com/zhilingc |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-619682154 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/zhilingc |
| zhilingc | https://github.com/zhilingc |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-619695418 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| zhilingc | https://github.com/zhilingc |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/650#event-3273835775 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/650#event-3273835806 |
| https://github.com/zhilingc |
| zhilingc | https://github.com/zhilingc |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-619695510 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
|
Apr 27, 2020
| https://github.com/feast-dev/feast/pull/650#pullrequestreview-400617185 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/650/files |
| core/src/main/java/feast/core/job/JobUpdateTask.java | https://github.com/feast-dev/feast/pull/650/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
|
Apr 27, 2020
| https://github.com/feast-dev/feast/pull/650#pullrequestreview-400618681 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/650/files |
| core/src/main/java/feast/core/job/JobUpdateTask.java | https://github.com/feast-dev/feast/pull/650/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-619739916 |
| @ches | https://github.com/ches |
| @mrzzy | https://github.com/mrzzy |
| comment | https://github.com/gojek/feast/pull/650#discussion_r415501353 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/ches |
| ches | https://github.com/ches |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-620027268 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
do-not-merge/hold
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fhold |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/650#event-3276089451 |
| ches | https://github.com/ches |
| April 27, 2020 21:38 | https://github.com/feast-dev/feast/pull/650#commits-pushed-ac1143d |
|
| https://github.com/ches |
| core: Clean up repetition in JobUpdateTask | https://github.com/feast-dev/feast/pull/650/commits/ac1143dcde7d39f91cec66b60448450856daea79 |
| ac1143d | https://github.com/feast-dev/feast/pull/650/commits/ac1143dcde7d39f91cec66b60448450856daea79 |
|
| https://github.com/ches |
| core: Reduce noise of AuditLogger in JobUpdateTask | https://github.com/feast-dev/feast/pull/650/commits/59f0352b37d882d03ea1b6a79146566b7854793e |
| 59f0352 | https://github.com/feast-dev/feast/pull/650/commits/59f0352b37d882d03ea1b6a79146566b7854793e |
|
| https://github.com/ches |
| core: Simplify JobUpdateTask internal helper calls | https://github.com/feast-dev/feast/pull/650/commits/5871d134b2f8d9753d0fed5c4d2888028e28ef97 |
| 5871d13 | https://github.com/feast-dev/feast/pull/650/commits/5871d134b2f8d9753d0fed5c4d2888028e28ef97 |
|
| https://github.com/ches |
| core: Refactor JobUpdateTask to use domain model types | https://github.com/feast-dev/feast/pull/650/commits/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915 |
| ded7ca5 | https://github.com/feast-dev/feast/pull/650/commits/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915 |
| https://github.com/ches |
| ches | https://github.com/ches |
| force-pushed | https://github.com/feast-dev/feast/compare/a3b04522cefa1cbd3b9e7cab4a0d34825223391e..ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915 |
| a3b0452 | https://github.com/feast-dev/feast/commit/a3b04522cefa1cbd3b9e7cab4a0d34825223391e |
| ded7ca5 | https://github.com/feast-dev/feast/commit/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915 |
|
Compare
| https://github.com/feast-dev/feast/compare/a3b04522cefa1cbd3b9e7cab4a0d34825223391e..ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915 |
| April 28, 2020 01:46 | https://github.com/feast-dev/feast/pull/650#event-3278232074 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
size/XL
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXL |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
|
size/L
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL |
| Apr 28, 2020 | https://github.com/feast-dev/feast/pull/650#event-3278232102 |
| https://github.com/ches |
| ches | https://github.com/ches |
| Apr 28, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-620331610 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Apr 28, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-620335212 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/ches |
| ches | https://github.com/ches |
| Apr 28, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-620336713 |
| as @mrzzy suggested | https://github.com/gojek/feast/pull/650#discussion_r415501353 |
| removing the redundant Executor in JobUpdateTask | https://github.com/gojek/feast/pull/650#discussion_r415130044 |
| @zhilingc | https://github.com/zhilingc |
| there is an existing TODO | https://github.com/gojek/feast/blob/45e6500ca5dfa78c36be95069863c515d762dc1b/core/src/main/java/feast/core/job/dataflow/DataflowJobManager.java#L303 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/ches |
| ches | https://github.com/ches |
| Apr 28, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-620336841 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
do-not-merge/hold
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fhold |
| Apr 28, 2020 | https://github.com/feast-dev/feast/pull/650#event-3278289802 |
| https://github.com/ches |
| ches | https://github.com/ches |
| Apr 28, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-620339383 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/ches |
| ches | https://github.com/ches |
| Apr 28, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-620341313 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Apr 28, 2020
| https://github.com/feast-dev/feast/pull/650#pullrequestreview-401568735 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/650/files/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915 |
| core/src/main/java/feast/core/service/JobCoordinatorService.java | https://github.com/feast-dev/feast/pull/650/files/15cc078598101279c6107d61bd5a0504a08b2ad6..ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915#diff-e00c51ab165ad0121271c6f080f7ec67812bf01ceb58b571f58d735fd6f184ba |
| woop | https://github.com/woop |
| Apr 28, 2020 | https://github.com/feast-dev/feast/pull/650#discussion_r416393038 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| ches | https://github.com/ches |
| Apr 29, 2020 | https://github.com/feast-dev/feast/pull/650#discussion_r417447673 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| woop | https://github.com/woop |
| Apr 30, 2020 | https://github.com/feast-dev/feast/pull/650#discussion_r417690127 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #664 | https://github.com/feast-dev/feast/issues/664 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Apr 29, 2020
| https://github.com/feast-dev/feast/pull/650#pullrequestreview-402761424 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/650/files/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915 |
| core/src/main/java/feast/core/job/JobUpdateTask.java | https://github.com/feast-dev/feast/pull/650/files/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f |
| woop | https://github.com/woop |
| Apr 29, 2020 | https://github.com/feast-dev/feast/pull/650#discussion_r417389088 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/gojek/feast/blame/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915/core/src/main/java/feast/core/config/FeastProperties.java#L95 | https://github.com/gojek/feast/blame/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915/core/src/main/java/feast/core/config/FeastProperties.java#L95 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| woop | https://github.com/woop |
| Apr 29, 2020 | https://github.com/feast-dev/feast/pull/650#discussion_r417390645 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| ches | https://github.com/ches |
| Apr 29, 2020 | https://github.com/feast-dev/feast/pull/650#discussion_r417458011 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/ches |
| ches | https://github.com/ches |
| Apr 29, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-621341352 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Apr 30, 2020
| https://github.com/feast-dev/feast/pull/650#ref-issue-609464410 |
|
Job Management Optimizations
#664
| https://github.com/feast-dev/feast/issues/664 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Apr 30, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-621542285 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| woop | https://github.com/woop |
| Apr 30, 2020 | https://github.com/feast-dev/feast/pull/650#event-3287035646 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
| Apr 30, 2020 | https://github.com/feast-dev/feast/pull/650#event-3287035673 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Apr 30, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-621542423 |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| Apr 30, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-621542454 |
| ches | https://github.com/gojek/feast/pull/650 |
| woop | https://github.com/gojek/feast/pull/650#issuecomment-621542423 |
| here | https://go.k8s.io/bot-commands?repo=gojek%2Ffeast |
| here | https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process |
| OWNERS | https://github.com/gojek/feast/blob/master/OWNERS |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
| Apr 30, 2020 | https://github.com/feast-dev/feast/pull/650#event-3287036718 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| 497b08d | https://github.com/feast-dev/feast/commit/497b08d039b0cd3b03bdb95c01f95ba261632a10 |
| Apr 30, 2020 | https://github.com/feast-dev/feast/pull/650#event-3287037197 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Apr 30, 2020 | https://github.com/feast-dev/feast/pull/650#issuecomment-621543188 |
| @zhilingc | https://github.com/zhilingc |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Apr 30, 2020
| https://github.com/feast-dev/feast/pull/650#ref-pullrequest-565019695 |
|
Document release steps
#476
| https://github.com/feast-dev/feast/pull/476 |
| https://github.com/ches |
| ches | https://github.com/ches |
| May 7, 2020 12:11 | https://github.com/feast-dev/feast/pull/650#event-3312592339 |
| ches | https://github.com/ches |
|
Jun 18, 2020
| https://github.com/feast-dev/feast/pull/650#ref-commit-3697c78 |
|
| https://github.com/ches |
| Fix Optional#get() and string comparison bugs in JobService | https://github.com/feast-dev/feast/commit/3697c780200fff22ffe884f813da03b3bcbef4ce |
| 3697c78 | https://github.com/feast-dev/feast/commit/3697c780200fff22ffe884f813da03b3bcbef4ce |
| #650 | https://github.com/feast-dev/feast/pull/650 |
| https://github.com/ches |
| ches | https://github.com/ches |
|
Jun 18, 2020
| https://github.com/feast-dev/feast/pull/650#ref-pullrequest-641340406 |
|
Fix Optional#get() and string comparison bugs in JobService
#804
| https://github.com/feast-dev/feast/pull/804 |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
Jun 18, 2020
| https://github.com/feast-dev/feast/pull/650#ref-commit-f117b65 |
|
| https://github.com/ches |
| Fix Optional#get() and string comparison bugs in JobService ( | https://github.com/feast-dev/feast/commit/f117b657956560d57a8e3048dbe3343131030e54 |
| #804 | https://github.com/feast-dev/feast/pull/804 |
| ) | https://github.com/feast-dev/feast/commit/f117b657956560d57a8e3048dbe3343131030e54 |
| f117b65 | https://github.com/feast-dev/feast/commit/f117b657956560d57a8e3048dbe3343131030e54 |
| #650 | https://github.com/feast-dev/feast/pull/650 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F650 |
|
| https://github.com/woop |
|
woop
| https://github.com/woop |
|
| https://github.com/feast-dev/feast/pull/650/files/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915 |
|
| https://github.com/mrzzy |
|
mrzzy
| https://github.com/mrzzy |
|
| https://github.com/feast-dev/feast/pull/650/files/a3b04522cefa1cbd3b9e7cab4a0d34825223391e |
|
| https://github.com/zhilingc |
|
zhilingc
| https://github.com/zhilingc |
|
| https://github.com/pradithya |
|
pradithya
| https://github.com/pradithya |
|
| https://github.com/pradithya |
|
pradithya
| https://github.com/pradithya |
|
| https://github.com/woop |
|
woop
| https://github.com/woop |
|
| https://github.com/zhilingc |
|
zhilingc
| https://github.com/zhilingc |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
|
size/XL
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXL |
| Please reload this page | https://github.com/feast-dev/feast/pull/650 |
|
| https://github.com/ches |
|
| https://github.com/zhilingc |
|
| https://github.com/woop |
|
| https://github.com/feast-ci-bot |
|
| https://github.com/mrzzy |
|
| https://github.com/pradithya |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |