René's URL Explorer Experiment


Title: feat: Add structured audit logging for MCP feature server by SIDDHESH1564 · Pull Request #6456 · feast-dev/feast · GitHub

Open Graph Title: feat: Add structured audit logging for MCP feature server by SIDDHESH1564 · Pull Request #6456 · feast-dev/feast

X Title: feat: Add structured audit logging for MCP feature server by SIDDHESH1564 · Pull Request #6456 · feast-dev/feast

Description: What this PR does / why we need it: This PR adds structured audit logging in JSONL format for the Python MCP feature server. Previously, the MCP integration only logged startup events and errors. Operators did not have a unified audit trail for MCP tool calls, internal REST requests, authentication results, authorization decisions, or request correlation. This change introduces an audit_logging configuration section under feature_server and adds structured audit events for: MCP tool invocations MCP JSON-RPC requests REST endpoint requests Authentication outcomes Authorization decisions Request correlation through X-Request-Id Client IP address and transport metadata Each audit event follows a stable schema and includes: event_type UTC timestamp request_id principal (username, roles, and auth_type) source (ip and transport) action (MCP tool name and/or HTTP path) resource (type, name, and permitted actions) outcome duration_ms Sensitive data is intentionally excluded from audit logs. Tokens, entity rows, feature values, and request payloads are not logged. Audit logging layers Layer Scope Event types McpAuditMiddleware /mcp JSON-RPC requests mcp.tools.call, mcp.request AuditLoggingMiddleware REST endpoints such as /get-online-features and /push http.request AuditLogger helpers Authentication and authorization hooks authn.success, authn.failure, authz.decision New files sdk/python/feast/audit/audit_logger.py Adds the AuditEvent model. Adds sink abstractions: StdoutAuditSink, FileAuditSink, and LoggerAuditSink. Adds AuditLogger helper methods for MCP, HTTP, authentication, and authorization events. sdk/python/feast/audit/audit_middleware.py Adds AuditLoggingMiddleware for REST endpoint auditing. Adds McpAuditMiddleware for MCP JSON-RPC request auditing. Modified files sdk/python/feast/infra/feature_servers/base_config.py Adds AuditLoggingConfig to BaseFeatureServerConfig. sdk/python/feast/feature_server.py Initializes the audit logger lifecycle. Wires the audit middleware into get_app(). Example configuration feature_server: type: mcp mcp_enabled: true audit_logging: enabled: true sink: stdout # stdout | file | logger # file_path: /var/log/feast_audit.jsonl log_successful_reads: true Example JSONL event { "event_type": "mcp.tools.call", "timestamp": "2026-05-28T12:00:00.000Z", "request_id": "...", "principal": { "username": "jane@co.com", "roles": ["reader"], "auth_type": "oidc" }, "source": { "ip": "10.0.0.1", "transport": "mcp-http" }, "action": { "mcp_tool": "get_online_features", "path": "/mcp" }, "outcome": "success", "duration_ms": 42.0 } Which issue(s) this PR fixes: Fixes #6452 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Added 37 unit tests covering: AuditEvent serialization in JSONL format, including exclusion of None values AuditLogger helpers: log_mcp_call log_http_request log_authn log_authz Suppression of successful read events when log_successful_reads: false All supported sinks: StdoutAuditSink FileAuditSink LoggerAuditSink create_audit_logger_from_config factory behavior and fallback handling AuditLoggingConfig validation and inheritance through McpFeatureServerConfig AuditLoggingMiddleware behavior: HTTP request logging Health and MCP route skipping Error outcomes X-Request-Id propagation Resource mapping McpAuditMiddleware behavior: MCP tool-call extraction from JSON-RPC request bodies Generic MCP request logging Non-JSON request-body handling Misc audit_logging is defined on BaseFeatureServerConfig, making it available to both local and MCP feature server types. Principal metadata is extracted from the existing SecurityManager context and supports no_auth, oidc, and kubernetes authentication modes. Registry MCP parity and an OpenTelemetry sink are intentionally left as follow-up improvements, as noted in the linked issue.

Open Graph Description: What this PR does / why we need it: This PR adds structured audit logging in JSONL format for the Python MCP feature server. Previously, the MCP integration only logged startup events and errors. O...

X Description: What this PR does / why we need it: This PR adds structured audit logging in JSONL format for the Python MCP feature server. Previously, the MCP integration only logged startup events and errors. O...

Opengraph URL: https://github.com/feast-dev/feast/pull/6456

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ca63485a-f06f-237e-2ef3-8f9e1f20e004
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE04:BC38B:30897C:433319:6AFE99CD
html-safe-nonce30a5241736ace401be0eb86d88c1a798d5d833a778887abf95b1ace80ce54abb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTA0OkJDMzhCOjMwODk3Qzo0MzMzMTk6NkFGRTk5Q0QiLCJ2aXNpdG9yX2lkIjoiMzAwMzkyMDA2NTg1NTY1ODQ0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac15cd34854a78e430f484770e31f76fa6b49a0eaac6b0af79dd361f648198ae37
hovercard-subject-tagpull_request:3774542656
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6456/files
twitter:imagehttps://avatars.githubusercontent.com/u/91747482?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/91747482?s=400&v=4
og:image:altWhat this PR does / why we need it: This PR adds structured audit logging in JSONL format for the Python MCP feature server. Previously, the MCP integration only logged startup events and errors. O...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6456/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6456%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6456%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6456/files
Reloadhttps://github.com/feast-dev/feast/pull/6456/files
Reloadhttps://github.com/feast-dev/feast/pull/6456/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
SIDDHESH1564:feat/mcp-audit-logginghttps://github.com/SIDDHESH1564/feast/tree/feat/mcp-audit-logging
Conversation 28 https://github.com/feast-dev/feast/pull/6456
Commits 6 https://github.com/feast-dev/feast/pull/6456/commits
Checks 27 https://github.com/feast-dev/feast/pull/6456/checks
Files changed https://github.com/feast-dev/feast/pull/6456/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6456/files
feat: Add structured audit logging for MCP feature server https://github.com/feast-dev/feast/pull/6456/files#top
Show all changes 6 commits https://github.com/feast-dev/feast/pull/6456/files
a284b7e feat: Add structured audit logging for MCP feature server SIDDHESH1564 May 30, 2026 https://github.com/feast-dev/feast/pull/6456/commits/a284b7ef24bdd4077e9e6c1359a58fc698b7191c
a0b5e1c feat: Enhance audit logging with OpenTelemetry support and JSON-RPC c… SIDDHESH1564 May 31, 2026 https://github.com/feast-dev/feast/pull/6456/commits/a0b5e1c2c4fa2e7c5de7b0981b06b3d07274c897
5d2a7d0 refactor: Audit MCP at protocol layer, fix empty principal, add emit … SIDDHESH1564 Jun 1, 2026 https://github.com/feast-dev/feast/pull/6456/commits/5d2a7d03cf2019bc1373facf69bfe619ca296880
98dbab9 fix(mcp): Propagate request_id for audit logging SIDDHESH1564 Jun 6, 2026 https://github.com/feast-dev/feast/pull/6456/commits/98dbab9da4610f352a1f219e892316e657af6737
480bdfa refactor(mcp): Update MCP server handler for audit logging SIDDHESH1564 Jun 8, 2026 https://github.com/feast-dev/feast/pull/6456/commits/480bdfab54180811525418a0b8df71a0cf9e3789
f7b3e04 fix: Address review feedback for audit logging SIDDHESH1564 Aug 21, 2026 https://github.com/feast-dev/feast/pull/6456/commits/f7b3e049f27efc0aeb9be69e2e0e73a1fe587b4d
Clear filters https://github.com/feast-dev/feast/pull/6456/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6456/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6456/files
__init__.py https://github.com/feast-dev/feast/pull/6456/files#diff-24f6cbb75b7984c6855aa16fd82fa096732673e55da826a9cc8358fa31cfdd70
audit_logger.py https://github.com/feast-dev/feast/pull/6456/files#diff-fbdfa1b45bfbff509100a6916c0f0592c87cc6caca284b0988a2a2f9f75f7311
audit_middleware.py https://github.com/feast-dev/feast/pull/6456/files#diff-2df188ce87046838164cd0ec3df5200a9844d612a0bd71dab9d59692c8d27f75
feature_server.py https://github.com/feast-dev/feast/pull/6456/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
base_config.py https://github.com/feast-dev/feast/pull/6456/files#diff-d30cafde4bb641a4c1a28c0b30e490b13a858cd6bd35cc936b931e235fa96e37
mcp_server.py https://github.com/feast-dev/feast/pull/6456/files#diff-de25749bfc4240bbd1f157571567fe01c27bfe4be2824dc37b1ba34279783677
__init__.py https://github.com/feast-dev/feast/pull/6456/files#diff-143cc6a27503132ce29d79575bc5fb93c3284e2ba9715a2db746e3f2490bddca
test_audit_logger.py https://github.com/feast-dev/feast/pull/6456/files#diff-59e1f0fefaf87ff94ccd42b02a5f599654f96d658a938dc10aef519d31bcf8ac
test_audit_middleware.py https://github.com/feast-dev/feast/pull/6456/files#diff-38d1706e549c9b804e2c78b22e0fcb95a43b8a4097122a9db00edc0acbfb319f
test_mcp_audit_handler.py https://github.com/feast-dev/feast/pull/6456/files#diff-c63503c447026f3ecf638aae3f9ea30f2cec0ac2a293e5ef456161a5b043f679
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/audit/__init__.pyhttps://github.com/feast-dev/feast/pull/6456/files#diff-24f6cbb75b7984c6855aa16fd82fa096732673e55da826a9cc8358fa31cfdd70
View file https://github.com/SIDDHESH1564/feast/blob/f7b3e049f27efc0aeb9be69e2e0e73a1fe587b4d/sdk/python/feast/audit/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6456/{{ revealButtonHref }}
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/audit/audit_logger.pyhttps://github.com/feast-dev/feast/pull/6456/files#diff-fbdfa1b45bfbff509100a6916c0f0592c87cc6caca284b0988a2a2f9f75f7311
View file https://github.com/SIDDHESH1564/feast/blob/f7b3e049f27efc0aeb9be69e2e0e73a1fe587b4d/sdk/python/feast/audit/audit_logger.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6456/{{ revealButtonHref }}
Please reload this pagehttps://github.com/feast-dev/feast/pull/6456/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6456/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6456/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.