Title: test: Add regression tests for protobuf >= 7.34.0 compatibility (#6435) by Jwrede · Pull Request #6450 · feast-dev/feast · GitHub
Open Graph Title: test: Add regression tests for protobuf >= 7.34.0 compatibility (#6435) by Jwrede · Pull Request #6450 · feast-dev/feast
X Title: test: Add regression tests for protobuf >= 7.34.0 compatibility (#6435) by Jwrede · Pull Request #6450 · feast-dev/feast
Description: What this PR does / why we need it: Adds regression tests to guard against reintroduction of the float_precision kwarg usage that was removed in PR #6015. The MessageToDict(float_precision=...) call caused feature_server.py to crash on protobuf >= 7.34.0 (see #6435). While the fix landed in #6015, there were no tests preventing reintroduction. Two tests added: test_no_message_to_dict_dependency -- patches MessageToDict to raise if called, proving convert_response_to_dict is independent of it test_double_precision_without_float_precision_kwarg -- verifies doubles (including edge cases like very small and very large values) round-trip correctly without the removed parameter Which issue(s) this PR fixes: Fixes #6435 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests
Open Graph Description: What this PR does / why we need it: Adds regression tests to guard against reintroduction of the float_precision kwarg usage that was removed in PR #6015. The MessageToDict(float_precision=...) cal...
X Description: What this PR does / why we need it: Adds regression tests to guard against reintroduction of the float_precision kwarg usage that was removed in PR #6015. The MessageToDict(float_precision=...) cal...
Opengraph URL: https://github.com/feast-dev/feast/pull/6450
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:cf968ddf-8f37-e557-f237-0bc0ab7b5413 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B73A:320EB:511EB9B:71AF5C6:6A4F9606 |
| html-safe-nonce | 8eedbf5d9f5d9705b59d91dd70a2fb8d38baf7aed94a18563e54405e44bb5f42 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzNBOjMyMEVCOjUxMUVCOUI6NzFBRjVDNjo2QTRGOTYwNiIsInZpc2l0b3JfaWQiOiIzMTc0NjExMzgxOTcxMjkzNzAyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 3af83ea1cc813bc5adba1f11f4df00550d1a3c336221f0412820ac99bebad45a |
| hovercard-subject-tag | pull_request:3766813395 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6450/files |
| twitter:image | https://avatars.githubusercontent.com/u/62910358?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/62910358?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: Adds regression tests to guard against reintroduction of the float_precision kwarg usage that was removed in PR #6015. The MessageToDict(float_precision=...) cal... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width