| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b56774bd-f745-721e-4118-14bbb72196f7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E754:1DDFF4:2E4AB7:40C309:6AFE99B3 |
| html-safe-nonce | c281af79402df49f651c60f395f79e29e3e4ab4ff268cb9b51f0e1aa16b610e8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzU0OjFEREZGNDoyRTRBQjc6NDBDMzA5OjZBRkU5OUIzIiwidmlzaXRvcl9pZCI6IjI3MzY3ODU2MDI2OTQyNTcwNzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ac5b532abd0924e58d0a2dae3eeb0163d9cb6c1f6922e25673e95d762781a697 |
| hovercard-subject-tag | pull_request:3722944619 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6428/files |
| twitter:image | https://avatars.githubusercontent.com/u/59091429?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/59091429?s=400&v=4 |
| og:image:alt | What this PR does / why we need it:
Guards signal.signal() calls in Query.__init__() with a threading.current_thread() is threading.main_thread() check.
When the Trino offline store is served via A... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/6428/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6428%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6428%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/6428/files |
| Reload | https://github.com/feast-dev/feast/pull/6428/files |
| Reload | https://github.com/feast-dev/feast/pull/6428/files |
| feast-dev | https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
| Code | https://github.com/feast-dev/feast |
| Issues223 (223) | https://github.com/feast-dev/feast/issues |
| Pull requests143 (143) | https://github.com/feast-dev/feast/pulls |
| Discussions | https://github.com/feast-dev/feast/discussions |
| Actions | https://github.com/feast-dev/feast/actions |
| Security and quality1 (1) | https://github.com/feast-dev/feast/security |
| Insights | https://github.com/feast-dev/feast/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| ntkathole | https://github.com/ntkathole |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| mbm-codes:fix/trino-signal-worker-thread | https://github.com/mbm-codes/feast/tree/fix/trino-signal-worker-thread |
|
Conversation
14
| https://github.com/feast-dev/feast/pull/6428 |
|
Commits
4
| https://github.com/feast-dev/feast/pull/6428/commits |
|
Checks
22
| https://github.com/feast-dev/feast/pull/6428/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/6428/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/6428/files |
|
fix: Fix ValueError in signal handling for Trino worker threads
| https://github.com/feast-dev/feast/pull/6428/files#top |
|
Show all changes
4 commits
| https://github.com/feast-dev/feast/pull/6428/files |
|
9776761
fix: fix signal.signal() ValueError in Trino worker threads
mbm-codes May 21, 2026
| https://github.com/feast-dev/feast/pull/6428/commits/977676137dddba16c07fa1a9398dacb0ca056db2 |
|
c5ca3f8
test: patch signal.signal in main thread test to avoid handler leak
mbm-codes Jun 1, 2026
| https://github.com/feast-dev/feast/pull/6428/commits/c5ca3f8fc3423f1a6d589be355bbbfe6408d0640 |
|
d9d3fab
Update sdk/python/feast/infra/offline_stores/contrib/trino_offline_st…
mbm-codes Jun 3, 2026
| https://github.com/feast-dev/feast/pull/6428/commits/d9d3faba4baa3c76970db781a8946f304187d5cf |
|
4c1e5d8
test: address PR feedback for worker thread errors and signals
mbm-codes Jun 3, 2026
| https://github.com/feast-dev/feast/pull/6428/commits/4c1e5d8c0d036746ec45e9074539f860e87dc1a9 |
|
Clear filters
| https://github.com/feast-dev/feast/pull/6428/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/6428/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/6428/files |
|
test_trino_queries.py
| https://github.com/feast-dev/feast/pull/6428/files#diff-b36dfbfaab2209aa55f74d677daed63d646e337924db4ffb5997dee02fb76385 |
|
trino_queries.py
| https://github.com/feast-dev/feast/pull/6428/files#diff-43501c8c77d529114e44cab644a3ae663ddbca25c19f6b8e4c0ce497dd13ca79 |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| ...python/feast/infra/offline_stores/contrib/trino_offline_store/tests/test_trino_queries.py | https://github.com/feast-dev/feast/pull/6428/files#diff-b36dfbfaab2209aa55f74d677daed63d646e337924db4ffb5997dee02fb76385 |
|
View file
| https://github.com/mbm-codes/feast/blob/4c1e5d8c0d036746ec45e9074539f860e87dc1a9/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/tests/test_trino_queries.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/6428/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino_queries.py | https://github.com/feast-dev/feast/pull/6428/files#diff-43501c8c77d529114e44cab644a3ae663ddbca25c19f6b8e4c0ce497dd13ca79 |
|
View file
| https://github.com/mbm-codes/feast/blob/4c1e5d8c0d036746ec45e9074539f860e87dc1a9/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino_queries.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/6428/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/6428/files#diff-43501c8c77d529114e44cab644a3ae663ddbca25c19f6b8e4c0ce497dd13ca79 |
|
| https://github.com/feast-dev/feast/pull/6428/files#diff-43501c8c77d529114e44cab644a3ae663ddbca25c19f6b8e4c0ce497dd13ca79 |
|
| https://github.com/feast-dev/feast/pull/6428/files#diff-43501c8c77d529114e44cab644a3ae663ddbca25c19f6b8e4c0ce497dd13ca79 |
| Please reload this page | https://github.com/feast-dev/feast/pull/6428/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |