René's URL Explorer Experiment


Title: fix: Fix ValueError in signal handling for Trino worker threads by mbm-codes · Pull Request #6428 · feast-dev/feast · GitHub

Open Graph Title: fix: Fix ValueError in signal handling for Trino worker threads by mbm-codes · Pull Request #6428 · feast-dev/feast

X Title: fix: Fix ValueError in signal handling for Trino worker threads by mbm-codes · Pull Request #6428 · feast-dev/feast

Description: What this PR does / why we need it: Guards signal.signal() calls in Query.__init__() with a threading.current_thread() is threading.main_thread() check. When the Trino offline store is served via Arrow Flight, Query.__init__() runs in a worker thread. Python restricts signal.signal() to the main thread only, causing: ValueError: signal only works in main thread of the main interpreter Which issue(s) this PR fixes: Fixes #6424 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Misc Added regression tests covering both main thread and worker thread scenarios. Signal handling is preserved for CLI/interactive usage. Worker thread usage silently skips signal registration, which is the correct behavior when running under Arrow Flight.

Open Graph Description: What this PR does / why we need it: Guards signal.signal() calls in Query.__init__() with a threading.current_thread() is threading.main_thread() check. When the Trino offline store is served via A...

X Description: What this PR does / why we need it: Guards signal.signal() calls in Query.__init__() with a threading.current_thread() is threading.main_thread() check. When the Trino offline store is served via A...

Opengraph URL: https://github.com/feast-dev/feast/pull/6428

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b56774bd-f745-721e-4118-14bbb72196f7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE754:1DDFF4:2E4AB7:40C309:6AFE99B3
html-safe-noncec281af79402df49f651c60f395f79e29e3e4ab4ff268cb9b51f0e1aa16b610e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzU0OjFEREZGNDoyRTRBQjc6NDBDMzA5OjZBRkU5OUIzIiwidmlzaXRvcl9pZCI6IjI3MzY3ODU2MDI2OTQyNTcwNzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacac5b532abd0924e58d0a2dae3eeb0163d9cb6c1f6922e25673e95d762781a697
hovercard-subject-tagpull_request:3722944619
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6428/files
twitter:imagehttps://avatars.githubusercontent.com/u/59091429?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/59091429?s=400&v=4
og:image:altWhat this PR does / why we need it: Guards signal.signal() calls in Query.__init__() with a threading.current_thread() is threading.main_thread() check. When the Trino offline store is served via A...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6428/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6428%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6428%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6428/files
Reloadhttps://github.com/feast-dev/feast/pull/6428/files
Reloadhttps://github.com/feast-dev/feast/pull/6428/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
mbm-codes:fix/trino-signal-worker-threadhttps://github.com/mbm-codes/feast/tree/fix/trino-signal-worker-thread
Conversation 14 https://github.com/feast-dev/feast/pull/6428
Commits 4 https://github.com/feast-dev/feast/pull/6428/commits
Checks 22 https://github.com/feast-dev/feast/pull/6428/checks
Files changed https://github.com/feast-dev/feast/pull/6428/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6428/files
fix: Fix ValueError in signal handling for Trino worker threads https://github.com/feast-dev/feast/pull/6428/files#top
Show all changes 4 commits https://github.com/feast-dev/feast/pull/6428/files
9776761 fix: fix signal.signal() ValueError in Trino worker threads mbm-codes May 21, 2026 https://github.com/feast-dev/feast/pull/6428/commits/977676137dddba16c07fa1a9398dacb0ca056db2
c5ca3f8 test: patch signal.signal in main thread test to avoid handler leak mbm-codes Jun 1, 2026 https://github.com/feast-dev/feast/pull/6428/commits/c5ca3f8fc3423f1a6d589be355bbbfe6408d0640
d9d3fab Update sdk/python/feast/infra/offline_stores/contrib/trino_offline_st… mbm-codes Jun 3, 2026 https://github.com/feast-dev/feast/pull/6428/commits/d9d3faba4baa3c76970db781a8946f304187d5cf
4c1e5d8 test: address PR feedback for worker thread errors and signals mbm-codes Jun 3, 2026 https://github.com/feast-dev/feast/pull/6428/commits/4c1e5d8c0d036746ec45e9074539f860e87dc1a9
Clear filters https://github.com/feast-dev/feast/pull/6428/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6428/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6428/files
test_trino_queries.py https://github.com/feast-dev/feast/pull/6428/files#diff-b36dfbfaab2209aa55f74d677daed63d646e337924db4ffb5997dee02fb76385
trino_queries.py https://github.com/feast-dev/feast/pull/6428/files#diff-43501c8c77d529114e44cab644a3ae663ddbca25c19f6b8e4c0ce497dd13ca79
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
...python/feast/infra/offline_stores/contrib/trino_offline_store/tests/test_trino_queries.pyhttps://github.com/feast-dev/feast/pull/6428/files#diff-b36dfbfaab2209aa55f74d677daed63d646e337924db4ffb5997dee02fb76385
View file https://github.com/mbm-codes/feast/blob/4c1e5d8c0d036746ec45e9074539f860e87dc1a9/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/tests/test_trino_queries.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6428/{{ revealButtonHref }}
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino_queries.pyhttps://github.com/feast-dev/feast/pull/6428/files#diff-43501c8c77d529114e44cab644a3ae663ddbca25c19f6b8e4c0ce497dd13ca79
View file https://github.com/mbm-codes/feast/blob/4c1e5d8c0d036746ec45e9074539f860e87dc1a9/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino_queries.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6428/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6428/files#diff-43501c8c77d529114e44cab644a3ae663ddbca25c19f6b8e4c0ce497dd13ca79
https://github.com/feast-dev/feast/pull/6428/files#diff-43501c8c77d529114e44cab644a3ae663ddbca25c19f6b8e4c0ce497dd13ca79
https://github.com/feast-dev/feast/pull/6428/files#diff-43501c8c77d529114e44cab644a3ae663ddbca25c19f6b8e4c0ce497dd13ca79
Please reload this pagehttps://github.com/feast-dev/feast/pull/6428/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.