René's URL Explorer Experiment


Title: fix(trino): Clean up temporary entity tables after retrieval by Jwrede · Pull Request #6381 · feast-dev/feast · GitHub

Open Graph Title: fix(trino): Clean up temporary entity tables after retrieval by Jwrede · Pull Request #6381 · feast-dev/feast

X Title: fix(trino): Clean up temporary entity tables after retrieval by Jwrede · Pull Request #6381 · feast-dev/feast

Description: Summary TrinoOfflineStore.get_historical_features() creates a temporary table (feast_entity_df_) for the entity DataFrame but never drops it, leaking tables in the Trino catalog indefinitely. This applies the same context manager pattern already used by the BigQuery, Redshift, and Athena offline stores: wrap the query in a generator that issues DROP TABLE IF EXISTS in a finally block. The cleanup only runs when the entity_df is a DataFrame (when a temp table was actually created), not when it is a SQL string. Fixes #6306 How Has This Been Tested? Verified the change follows the same pattern as BigQuery (bigquery.py:304), Redshift (redshift.py:236), and Athena (athena.py:224). All callers of TrinoRetrievalJob that pass a plain query string (e.g. pull_latest_from_table_or_query) continue to work via the fallback contextmanager wrapper.

Open Graph Description: Summary TrinoOfflineStore.get_historical_features() creates a temporary table (feast_entity_df_<uuid>) for the entity DataFrame but never drops it, leaking tables in the Trino catalog indefin...

X Description: Summary TrinoOfflineStore.get_historical_features() creates a temporary table (feast_entity_df_&lt;uuid&gt;) for the entity DataFrame but never drops it, leaking tables in the Trino catalog...

Opengraph URL: https://github.com/feast-dev/feast/pull/6381

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:40dcf461-d7a4-1b23-c477-5ce33ec0baf3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC42:358B3C:51936E8:72EC6A5:6A502B73
html-safe-noncee0f8c450d2fba407066fd562394096bc222a659395de19366b152d727a950857
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzQyOjM1OEIzQzo1MTkzNkU4OjcyRUM2QTU6NkE1MDJCNzMiLCJ2aXNpdG9yX2lkIjoiOTA4MjkzNjA1MjY5MjI5ODYxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9eaad455f59c628d0f8434448302da3aff9591bd35d2191b1ac4fd418e659e54
hovercard-subject-tagpull_request:3645856002
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6381/files
twitter:imagehttps://avatars.githubusercontent.com/u/62910358?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/62910358?s=400&v=4
og:image:altSummary TrinoOfflineStore.get_historical_features() creates a temporary table (feast_entity_df_<uuid>) for the entity DataFrame but never drops it, leaking tables in the Trino catalog indefin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released90666eaf032b7eb8975a378efe38e37f4ebb96c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6381/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6381%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6381%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6381/files
Reloadhttps://github.com/feast-dev/feast/pull/6381/files
Reloadhttps://github.com/feast-dev/feast/pull/6381/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6381/files
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.4k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 7.1k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 213 https://github.com/feast-dev/feast/issues
Pull requests 177 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security and quality 1 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security and quality https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Jwrede:fix/trino-temp-table-cleanuphttps://github.com/Jwrede/feast/tree/fix/trino-temp-table-cleanup
Conversation 6 https://github.com/feast-dev/feast/pull/6381
Commits 3 https://github.com/feast-dev/feast/pull/6381/commits
Checks 26 https://github.com/feast-dev/feast/pull/6381/checks
Files changed https://github.com/feast-dev/feast/pull/6381/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6381/files
fix(trino): Clean up temporary entity tables after retrieval https://github.com/feast-dev/feast/pull/6381/files#top
Show all changes 3 commits https://github.com/feast-dev/feast/pull/6381/files
317adfa fix(trino): Clean up temporary entity tables after retrieval Jwrede May 7, 2026 https://github.com/feast-dev/feast/pull/6381/commits/317adfa8f551f9a61146ddbfac8022da85d14b33
f1008f2 fix: sort imports for ruff compliance Jwrede May 14, 2026 https://github.com/feast-dev/feast/pull/6381/commits/f1008f23fb4eef98ccb8a892ea8cf3d0ccc19191
3ddef73 fix: decouple temp table cleanup from query access Jwrede May 14, 2026 https://github.com/feast-dev/feast/pull/6381/commits/3ddef730ec07fcd83eb0c542a73b2cd43bc28a18
Clear filters https://github.com/feast-dev/feast/pull/6381/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6381/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6381/files
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.pyhttps://github.com/feast-dev/feast/pull/6381/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
View file https://github.com/Jwrede/feast/blob/3ddef730ec07fcd83eb0c542a73b2cd43bc28a18/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6381/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6381/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/pull/6381/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/pull/6381/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/pull/6381/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/pull/6381/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/pull/6381/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/pull/6381/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/pull/6381/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/pull/6381/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/pull/6381/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/pull/6381/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/pull/6381/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/pull/6381/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
Please reload this pagehttps://github.com/feast-dev/feast/pull/6381/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.