Title: fix: Scope feature view name conflict check to current project in file-based registry by Abhishek8108 · Pull Request #6369 · feast-dev/feast · GitHub
Open Graph Title: fix: Scope feature view name conflict check to current project in file-based registry by Abhishek8108 · Pull Request #6369 · feast-dev/feast
X Title: fix: Scope feature view name conflict check to current project in file-based registry by Abhishek8108 · Pull Request #6369 · feast-dev/feast
Description: What this PR does Fixes #6209. _check_conflicting_feature_view_names built its lookup map from all feature views in cached_registry_proto without filtering by project. In a shared file-based registry with multiple projects, this caused false ConflictingFeatureViewNames errors when two different projects defined feature views with the same name. Root cause _existing_feature_view_names_to_fvs iterated over all three collections (feature views, stream feature views, on-demand feature views) in the entire RegistryProto without scoping to the current project. The dict is keyed by name only, so a FeatureView named driver_stats in project_a and a FeatureView also named driver_stats in project_b would collide, triggering a spurious error on the second feast apply. Fix Added a project: str parameter to both _check_conflicting_feature_view_names and _existing_feature_view_names_to_fvs Each collection is now filtered by fv.spec.project == project so only feature views belonging to the current project are included in the conflict map The call site in apply_feature_view passes the project argument that is already in scope Tests Added test_cross_project_feature_view_names_do_not_conflict in tests/unit/local_feast_tests/test_local_feature_store.py: two FeatureStore instances sharing a registry file but different projects both apply a FeatureView named driver_stats — asserts no ConflictingFeatureViewNames is raised Existing test_apply_conflicting_feature_view_names continues to pass — same-project type conflicts are still detected correctly
Open Graph Description: What this PR does Fixes #6209. _check_conflicting_feature_view_names built its lookup map from all feature views in cached_registry_proto without filtering by project. In a shared file-based regist...
X Description: What this PR does Fixes #6209. _check_conflicting_feature_view_names built its lookup map from all feature views in cached_registry_proto without filtering by project. In a shared file-based regist...
Opengraph URL: https://github.com/feast-dev/feast/pull/6369
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8b13306b-6191-a6e4-3e2a-d9c7af0da44a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8AFC:18EF1B:19D917C:2383CCE:6A4EB7C5 |
| html-safe-nonce | 0b75a377dae85b7f70a1352f37f3ecc5f891c1246d39493fff186ac5c3bdc499 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUZDOjE4RUYxQjoxOUQ5MTdDOjIzODNDQ0U6NkE0RUI3QzUiLCJ2aXNpdG9yX2lkIjoiNDMwMzAzNjE3NTUzMzEyNzYyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 569870e2e980383a2b97f76183fbd45e3cf68384b13a77c704b22c1ed2a40d46 |
| hovercard-subject-tag | pull_request:3633147007 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6369/files |
| twitter:image | https://avatars.githubusercontent.com/u/87538407?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/87538407?s=400&v=4 |
| og:image:alt | What this PR does Fixes #6209. _check_conflicting_feature_view_names built its lookup map from all feature views in cached_registry_proto without filtering by project. In a shared file-based regist... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width