Title: fix(bigquery): Prefer query over table in get_table_query_string by Jwrede · Pull Request #6360 · feast-dev/feast · GitHub
Open Graph Title: fix(bigquery): Prefer query over table in get_table_query_string by Jwrede · Pull Request #6360 · feast-dev/feast
X Title: fix(bigquery): Prefer query over table in get_table_query_string by Jwrede · Pull Request #6360 · feast-dev/feast
Description: Summary Fixes #6200 When both table and query are set on a BigQuerySource, get_table_query_string() silently ignores query and always returns the table reference. This makes it impossible to use a custom read query (e.g., for deduplication via QUALIFY) on a PushSource, since PushSource requires table for offline writes. Root cause: get_table_query_string() checks if self.table first — since table is always truthy when set, query is never reached. Fix: Invert the priority — prefer query when present (it's more specific and intentionally provided), fall back to table. The write path (offline_write_batch()) accesses .table directly and is unaffected. Also applies the same fix to get_table_column_names_and_types() so schema inference uses the query when both are set, matching the actual read path. Changes bigquery_source.py: Swap condition order in get_table_query_string() and get_table_column_names_and_types() to prefer query over table test_bigquery.py: Add 4 unit tests covering table-only, query-only, both-set, and write-path-unaffected scenarios Test plan All 11 existing + new unit tests pass (pytest sdk/python/tests/unit/infra/offline_stores/test_bigquery.py) Integration test with BigQuery PushSource (requires GCP credentials)
Open Graph Description: Summary Fixes #6200 When both table and query are set on a BigQuerySource, get_table_query_string() silently ignores query and always returns the table reference. This makes it impossible to use a ...
X Description: Summary Fixes #6200 When both table and query are set on a BigQuerySource, get_table_query_string() silently ignores query and always returns the table reference. This makes it impossible to use a ...
Opengraph URL: https://github.com/feast-dev/feast/pull/6360
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a9cb7d2b-0b11-42f8-a535-f3fd0f2d1d81 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CA6C:645E3:B8C804:10F813C:6A4E2586 |
| html-safe-nonce | bf29e37a2b6907a09170a8ef195b52796e4d19d42148efe78d9d061f5d3022bf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTZDOjY0NUUzOkI4QzgwNDoxMEY4MTNDOjZBNEUyNTg2IiwidmlzaXRvcl9pZCI6IjI0MjQ2MTIzNzI5OTM2ODA3NzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0bfbd46cabda028d8f218eb95cfdf430f4b92244c6c2819f42fe6bd5729f95a8 |
| hovercard-subject-tag | pull_request:3618876968 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6360/files |
| twitter:image | https://avatars.githubusercontent.com/u/62910358?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/62910358?s=400&v=4 |
| og:image:alt | Summary Fixes #6200 When both table and query are set on a BigQuerySource, get_table_query_string() silently ignores query and always returns the table reference. This makes it impossible to use a ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d9dd20d38f8ae3c4cb6b597807431db300d0bd2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width