René's URL Explorer Experiment


Title: feat: Addresses performance issues in the Redis online store by ntkathole · Pull Request #6337 · feast-dev/feast · GitHub

Open Graph Title: feat: Addresses performance issues in the Redis online store by ntkathole · Pull Request #6337 · feast-dev/feast

X Title: feat: Addresses performance issues in the Redis online store by ntkathole · Pull Request #6337 · feast-dev/feast

Description: Summary Addresses several correctness and performance issues in the Redis online store identified in #3596. Changes 1. Batched get_online_features pipeline (read latency: O(N_fv) → O(1)) The base class get_online_features calls online_read once per feature view, each opening and executing its own Redis pipeline. Since all feature views for the same entity already share one Redis hash key, all HMGET commands across every feature view can be batched into a single pipeline execution. RedisOnlineStore now overrides get_online_features to pre-compute all entity keys and hash field keys, issue one pipeline.execute() for everything, then demultiplex results back per feature view. For a request spanning N feature views this cuts Redis round trips from N to 1. 2. Fixed delete_table N+1 query pattern The previous implementation called client.hgetall(key) synchronously inside the scan_iter loop — one blocking round trip per entity key. Replaced with a three-phase approach: Phase 1: collect all matching keys from SCAN (no per-key round trips) Phase 2: pipeline HKEYS for all collected keys (1 round trip) Phase 3: pipeline all HDEL/DEL commands (1 round trip) 3. skip_dedup config option for write throughput Added skip_dedup: bool = False to RedisOnlineStoreConfig. When enabled, online_write_batch skips the first timestamp-read pipeline and writes all rows in a single pass, halving round trips. Intended for initial bulk loads or append-only pipelines where concurrent out-of-order writes are not a concern. 4. online_write_batch_async implemented Previously raised NotImplementedError. Now fully implemented using the existing _get_client_async infrastructure, with skip_dedup support. Files Changed sdk/python/feast/infra/online_stores/redis.py — only file modified; base class OnlineStore and all other store implementations are untouched. Performance Impact Scenario Before After get_online_features with N feature views N Redis round trips 1 Redis round trip online_write_batch with skip_dedup=True 2 round trips 1 round trip delete_table with K entity keys K+1 round trips 3 round trips Async batch writes NotImplementedError Supported Related Fixes #3596

Open Graph Description: Summary Addresses several correctness and performance issues in the Redis online store identified in #3596. Changes 1. Batched get_online_features pipeline (read latency: O(N_fv) → O(1)) The base c...

X Description: Summary Addresses several correctness and performance issues in the Redis online store identified in #3596. Changes 1. Batched get_online_features pipeline (read latency: O(N_fv) → O(1)) The base c...

Opengraph URL: https://github.com/feast-dev/feast/pull/6337

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b8b489f1-03a3-6e06-7d66-b069e3033953
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC62:1C8D80:2332CA:2EBCB4:6AFE987F
html-safe-noncee4ef050fb35e052a6b9826b3a133e6ca4bad2d5e31d3b02190af4d1659872630
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzYyOjFDOEQ4MDoyMzMyQ0E6MkVCQ0I0OjZBRkU5ODdGIiwidmlzaXRvcl9pZCI6IjM5MjYxNjgxNzg4NjkyNjk3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac33e5940d26296a164c147ef3d7400677a6e46f17bf7b0ab07014812924aeb8c5
hovercard-subject-tagpull_request:3585665256
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6337/files
twitter:imagehttps://avatars.githubusercontent.com/u/16951913?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/16951913?s=400&v=4
og:image:altSummary Addresses several correctness and performance issues in the Redis online store identified in #3596. Changes 1. Batched get_online_features pipeline (read latency: O(N_fv) → O(1)) The base c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6337/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6337%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6337%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6337/files
Reloadhttps://github.com/feast-dev/feast/pull/6337/files
Reloadhttps://github.com/feast-dev/feast/pull/6337/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
ntkathole:redis_perf_improvehttps://github.com/ntkathole/feast/tree/redis_perf_improve
Conversation 1 https://github.com/feast-dev/feast/pull/6337
Commits 1 https://github.com/feast-dev/feast/pull/6337/commits
Checks 26 https://github.com/feast-dev/feast/pull/6337/checks
Files changed https://github.com/feast-dev/feast/pull/6337/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6337/files
feat: Addresses performance issues in the Redis online store https://github.com/feast-dev/feast/pull/6337/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6337/files
4471231 feat: Addresses performance issues in the Redis online store ntkathole Apr 26, 2026 https://github.com/feast-dev/feast/pull/6337/commits/4471231045518ccf10abf45f11e7e8d6b37db6c4
Clear filters https://github.com/feast-dev/feast/pull/6337/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6337/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6337/files
online-server-performance-tuning.md https://github.com/feast-dev/feast/pull/6337/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
running-feast-in-production.md https://github.com/feast-dev/feast/pull/6337/files#diff-c6d4f79f98c366867af7e7e14639e17dd5e1456fcd9df25ab820669401b9a518
feature-store-yaml.md https://github.com/feast-dev/feast/pull/6337/files#diff-6f65f62138b61a347dd86cd2e54e16fa2e607da821cecc2b41d9708e85467612
redis.md https://github.com/feast-dev/feast/pull/6337/files#diff-628d54de8459ecfbc0aa848f7223eacdcf8a6a3889b7dfe5ed935df9153d25a1
redis.py https://github.com/feast-dev/feast/pull/6337/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
test_redis.py https://github.com/feast-dev/feast/pull/6337/files#diff-c44a5a05d39122961f5a1df8728cafebc6cd7679bdf02a71d42461c238fa637f
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/how-to-guides/online-server-performance-tuning.mdhttps://github.com/feast-dev/feast/pull/6337/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
View file https://github.com/ntkathole/feast/blob/4471231045518ccf10abf45f11e7e8d6b37db6c4/docs/how-to-guides/online-server-performance-tuning.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6337/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6337/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/6337/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/6337/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/6337/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/6337/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/6337/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/6337/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/6337/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/6337/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/6337/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/6337/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/how-to-guides/running-feast-in-production.mdhttps://github.com/feast-dev/feast/pull/6337/files#diff-c6d4f79f98c366867af7e7e14639e17dd5e1456fcd9df25ab820669401b9a518
View file https://github.com/ntkathole/feast/blob/4471231045518ccf10abf45f11e7e8d6b37db6c4/docs/how-to-guides/running-feast-in-production.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6337/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6337/files#diff-c6d4f79f98c366867af7e7e14639e17dd5e1456fcd9df25ab820669401b9a518
https://github.com/feast-dev/feast/pull/6337/files#diff-c6d4f79f98c366867af7e7e14639e17dd5e1456fcd9df25ab820669401b9a518
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/reference/feature-repository/feature-store-yaml.mdhttps://github.com/feast-dev/feast/pull/6337/files#diff-6f65f62138b61a347dd86cd2e54e16fa2e607da821cecc2b41d9708e85467612
View file https://github.com/ntkathole/feast/blob/4471231045518ccf10abf45f11e7e8d6b37db6c4/docs/reference/feature-repository/feature-store-yaml.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6337/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6337/files#diff-6f65f62138b61a347dd86cd2e54e16fa2e607da821cecc2b41d9708e85467612
Please reload this pagehttps://github.com/feast-dev/feast/pull/6337/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6337/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.