Title: feat: Add versioning support to Milvus online store by makinzm · Pull Request #6330 · feast-dev/feast · GitHub
Open Graph Title: feat: Add versioning support to Milvus online store by makinzm · Pull Request #6330 · feast-dev/feast
X Title: feat: Add versioning support to Milvus online store by makinzm · Pull Request #6330 · feast-dev/feast
Description: What this PR does / why we need it: Adds feature view versioning support to the Milvus online store. When enable_online_feature_view_versioning is enabled in the registry config, the Milvus collection name now includes a version suffix (e.g. project_driver_stats_v2), allowing version-qualified feature references (e.g. driver_stats@v2:trips_today) to resolve to the correct versioned data. Changes: Updated _table_id() in milvus.py to accept enable_versioning and delegate to the shared compute_table_id() helper (same pattern as SQLite, Redis, PostgreSQL, etc.) Updated all 5 call sites of _table_id to pass config.registry.enable_online_feature_view_versioning Added MilvusOnlineStore to the supported types list in _check_versioned_read_support() so versioned reads no longer raise VersionedOnlineReadNotSupported Added unit tests covering versioned/non-versioned table name generation and versioned read support Which issue(s) this PR fixes: Fixes #6177 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Misc Implementation follows the existing pattern from sqlite.py and dynamodb.py. The compute_table_id() helper in helpers.py handles the version suffix logic, so no additional logic was needed in the Milvus store itself.
Open Graph Description: What this PR does / why we need it: Adds feature view versioning support to the Milvus online store. When enable_online_feature_view_versioning is enabled in the registry config, the Milvus collect...
X Description: What this PR does / why we need it: Adds feature view versioning support to the Milvus online store. When enable_online_feature_view_versioning is enabled in the registry config, the Milvus collect...
Opengraph URL: https://github.com/feast-dev/feast/pull/6330
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9b5787e4-2b45-1bb8-5374-a6e9d1c66367 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C576:3E6EAA:1455541:1C4B36F:6A4EA6F5 |
| html-safe-nonce | c00adb9b4d0deb4e6d31d4b0e7590fc4fef49a7624e51a5e61d07473312d321f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTc2OjNFNkVBQToxNDU1NTQxOjFDNEIzNkY6NkE0RUE2RjUiLCJ2aXNpdG9yX2lkIjoiNDM3MTY1MzkwNDQ5Mzg4MTA3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ae7c91204d8d35afa99362314346ae554fc05537383871bcc5e786946e7b842c |
| hovercard-subject-tag | pull_request:3582567730 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6330/files |
| twitter:image | https://avatars.githubusercontent.com/u/40193664?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40193664?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: Adds feature view versioning support to the Milvus online store. When enable_online_feature_view_versioning is enabled in the registry config, the Milvus collect... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width