Title: fix: Use SELECT * when feature_name_columns is empty in pull_all_from_table_or_query by abhijeet-dhumal · Pull Request #6311 · feast-dev/feast · GitHub
Open Graph Title: fix: Use SELECT * when feature_name_columns is empty in pull_all_from_table_or_query by abhijeet-dhumal · Pull Request #6311 · feast-dev/feast
X Title: fix: Use SELECT * when feature_name_columns is empty in pull_all_from_table_or_query by abhijeet-dhumal · Pull Request #6311 · feast-dev/feast
Description: What pull_all_from_table_or_query always builds an explicit SELECT projection from join_key_columns + feature_name_columns + timestamp_fields. When feature_name_columns=[] — the "read all source columns" signal already used by FeatureBuilder.get_column_info for ray and pandas transformation modes — the generated SQL becomes: SELECT user_id, event_timestamp FROM s3a://bucket/reviews/ WHERE event_timestamp BETWEEN ... All raw feature columns (rating, text, helpful_vote, etc.) are silently dropped. The UDF receives a 2-column DataFrame and every aggregation returns null or fails. Why it happens # no guard for empty feature_name_columns (fields_with_aliases, aliases) = _get_fields_with_aliases( fields=join_key_columns + feature_name_columns + timestamp_fields, ... ) fields_with_alias_string = ", ".join(fields_with_aliases) # → "user_id, event_timestamp" when feature_name_columns=[]
Open Graph Description: What pull_all_from_table_or_query always builds an explicit SELECT projection from join_key_columns + feature_name_columns + timestamp_fields. When feature_name_columns=[] — the "read all sour...
X Description: What pull_all_from_table_or_query always builds an explicit SELECT projection from join_key_columns + feature_name_columns + timestamp_fields. When feature_name_columns=[] — the "read all ...
Opengraph URL: https://github.com/feast-dev/feast/pull/6311
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6ee232f5-b7fc-cc44-6977-9059dcd66f66 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8460:8A2B5:2725953:362DBFB:6A4F5546 |
| html-safe-nonce | 07430d9ed9efdae04c71fd2071156d4faba9da3cf821963831c7a0bcab54df61 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDYwOjhBMkI1OjI3MjU5NTM6MzYyREJGQjo2QTRGNTU0NiIsInZpc2l0b3JfaWQiOiI4NDU0NzAxMDc1OTUzMzA4OTk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e4623fd380f6255925ad8b609f1b7ea105902a882d77ce0b21f4147bf337afe6 |
| hovercard-subject-tag | pull_request:3563936834 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6311/files |
| twitter:image | https://avatars.githubusercontent.com/u/84722973?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/84722973?s=400&v=4 |
| og:image:alt | What pull_all_from_table_or_query always builds an explicit SELECT projection from join_key_columns + feature_name_columns + timestamp_fields. When feature_name_columns=[] — the "read all sour... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width