Title: test: Expand MilvusOnlineStore integration test coverage by korbonits · Pull Request #6299 · feast-dev/feast · GitHub
Open Graph Title: test: Expand MilvusOnlineStore integration test coverage by korbonits · Pull Request #6299 · feast-dev/feast
X Title: test: Expand MilvusOnlineStore integration test coverage by korbonits · Pull Request #6299 · feast-dev/feast
Description: What does this PR do? Expands test_retrieve_online_milvus_documents (in sdk/python/tests/integration/online_store/test_universal_online.py) with three additional cases that exercise code paths adjacent to the bug fixes in #6275. The existing test covered a single L2 vector query on a 3-row dataset with top_k=2. This PR adds: 1. Empty-store query Queries retrieve_online_documents_v2 before write_to_online_store, so the Milvus collection exists but is empty. Asserts 0 rows returned. Exercises the "no hits" path of the v2 retrieval code. 2. Oversized top_k Queries with top_k=5 on a 3-row dataset. Asserts all 3 rows are returned. Exercises the hit-parsing loop when the result set is smaller than the requested top_k — adjacent to the territory of bug #4 from #6275 (the bytes.fromhex(None) crash on a hit with a missing composite key). 3. Cosine-metric variant Creates a second FeatureView (item_embeddings_cosine) with vector_search_metric="COSINE", writes the same dataset, and queries with distance_metric="COSINE". Verifies the cosine index is created and queried end to end. The existing test only covered the L2 path. Motivation Bug #4 in #6275 (TypeError: fromhex argument must be str, not None) was caught by a unit test (test_milvus_retrieve_online_documents_v2_missing_entity_key), but the universal integration test for Milvus retrieval did not exercise any of the adjacent edges (empty results, trailing hits, non-L2 metric). This PR closes that gap. Tests Verified locally against Milvus Lite: FEAST_LOCAL_ONLINE_CONTAINER=True pytest --integration \ sdk/python/tests/integration/online_store/test_universal_online.py::test_retrieve_online_milvus_documents 1 passed, 5 warnings in 1.79s No new imports are added; all types (FeatureView, Field, Array, Float32, String, timedelta, item) were already imported in the module. Out of scope Adding Milvus to the test_retrieve_online_documents_v2 universal parametrization: that test asserts a BM25-style text_rank contract that Milvus's current LIKE-based text search does not satisfy. A capability-matrix refactor of the universal v2 test is a larger design question and will be raised separately. 🤖 Generated with Claude Code
Open Graph Description: What does this PR do? Expands test_retrieve_online_milvus_documents (in sdk/python/tests/integration/online_store/test_universal_online.py) with three additional cases that exercise code paths adja...
X Description: What does this PR do? Expands test_retrieve_online_milvus_documents (in sdk/python/tests/integration/online_store/test_universal_online.py) with three additional cases that exercise code paths adja...
Opengraph URL: https://github.com/feast-dev/feast/pull/6299
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:77a9200a-9ac0-92ff-c8cd-4552efe21756 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D0B2:366857:3431A7B:479E098:6A4F2B43 |
| html-safe-nonce | c603195c0acc14bd9467a4639631c18fd8ae2131f281c8023b5652c7028f5d3c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMEIyOjM2Njg1NzozNDMxQTdCOjQ3OUUwOTg6NkE0RjJCNDMiLCJ2aXNpdG9yX2lkIjoiNTQ4MDU4Mzg0NTc5NDIyOTA1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9a992eed2256cdce56d61185cdd0dcd4645399249b1c0487c7618ca9c4125111 |
| hovercard-subject-tag | pull_request:3557646007 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6299/files |
| twitter:image | https://avatars.githubusercontent.com/u/5281694?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5281694?s=400&v=4 |
| og:image:alt | What does this PR do? Expands test_retrieve_online_milvus_documents (in sdk/python/tests/integration/online_store/test_universal_online.py) with three additional cases that exercise code paths adja... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width