Title: fix: Add project filter to apply_data_source and delete_data_source by mailtoboggavarapu-coder · Pull Request #6298 · feast-dev/feast · GitHub
Open Graph Title: fix: Add project filter to apply_data_source and delete_data_source by mailtoboggavarapu-coder · Pull Request #6298 · feast-dev/feast
X Title: fix: Add project filter to apply_data_source and delete_data_source by mailtoboggavarapu-coder · Pull Request #6298 · feast-dev/feast
Description: Problem Two methods in the shared registry were matching data sources by name only, without filtering by project. In multi-project registries where different projects share the same data source name (e.g. the default "vals_to_add"), this caused: apply_data_source: cross-project overwriting of data sources delete_data_source: deleting data sources from the wrong project Fixes #6206 Changes apply_data_source: already fixed — adds and existing_data_source_proto.project == project check (mirrors the pattern used in apply_entity, apply_feature_service, apply_feature_view) delete_data_source: now uses the same project-scoped filter for consistency Fix Unicode mojibake in comments (em dashes were stored as double-encoded Latin-1 bytes) Testing Existing registry tests cover this path. No new test added as the filter follows the exact pattern of other apply_* / delete_* methods in the same class.
Open Graph Description: Problem Two methods in the shared registry were matching data sources by name only, without filtering by project. In multi-project registries where different projects share the same data source nam...
X Description: Problem Two methods in the shared registry were matching data sources by name only, without filtering by project. In multi-project registries where different projects share the same data source nam...
Opengraph URL: https://github.com/feast-dev/feast/pull/6298
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9f6e49ce-1e1e-5684-46e0-fd5c9ebdbeed |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF32:2C2A02:16ADD4:1DD4CA:6A4ED070 |
| html-safe-nonce | 3bdac6619d68f858f4aa001c64ca55f13d9a02c69ae2bef0eac5b5de761d4c6c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjMyOjJDMkEwMjoxNkFERDQ6MURENENBOjZBNEVEMDcwIiwidmlzaXRvcl9pZCI6IjI0Mjc4NDM0MDAwNTg4OTEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b0022d062f1cb2ee9448e65115a7f0980c66904ce9ecacc39f05790bf69fcc82 |
| hovercard-subject-tag | pull_request:3556777526 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6298/files |
| twitter:image | https://avatars.githubusercontent.com/u/272960376?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/272960376?s=400&v=4 |
| og:image:alt | Problem Two methods in the shared registry were matching data sources by name only, without filtering by project. In multi-project registries where different projects share the same data source nam... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width