Title: fix: Include StreamFeatureView in freshness metric by Vperiodt · Pull Request #6269 · feast-dev/feast · GitHub
Open Graph Title: fix: Include StreamFeatureView in freshness metric by Vperiodt · Pull Request #6269 · feast-dev/feast
X Title: fix: Include StreamFeatureView in freshness metric by Vperiodt · Pull Request #6269 · feast-dev/feast
Description: What this PR does / why we need it: update_feature_freshness() only called store.list_feature_views(), which excluded StreamFeatureView from the feast_feature_freshness_seconds gauge. This adds store.list_stream_feature_views() so both batch and stream feature views are tracked Which issue(s) this PR fixes: Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Misc
Open Graph Description: What this PR does / why we need it: update_feature_freshness() only called store.list_feature_views(), which excluded StreamFeatureView from the feast_feature_freshness_seconds gauge. This adds st...
X Description: What this PR does / why we need it: update_feature_freshness() only called store.list_feature_views(), which excluded StreamFeatureView from the feast_feature_freshness_seconds gauge. This adds st...
Opengraph URL: https://github.com/feast-dev/feast/pull/6269
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:43c0dd52-0c2c-acc5-ab85-af3e84d0ff7a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A742:FE029:1EFC77D:2C71A14:6A4F8D3A |
| html-safe-nonce | 075086ee9b5b8cbd682cb284981a8418fdb2f68d07ada2c8fda0d2819e007244 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzQyOkZFMDI5OjFFRkM3N0Q6MkM3MUExNDo2QTRGOEQzQSIsInZpc2l0b3JfaWQiOiIzNDA5NTEzMDEzMjI0Mzc3NjU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d35f19561e729aedbbfa18ea6d654b418f41d84d71d222c0512d5a42a1589a54 |
| hovercard-subject-tag | pull_request:3523086961 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6269/files |
| twitter:image | https://avatars.githubusercontent.com/u/102902652?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/102902652?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: update_feature_freshness() only called store.list_feature_views(), which excluded StreamFeatureView from the feast_feature_freshness_seconds gauge. This adds st... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width