Title: feat: Add feature view versioning support to FAISS online store by YassinNouh21 · Pull Request #6256 · feast-dev/feast · GitHub
Open Graph Title: feat: Add feature view versioning support to FAISS online store by YassinNouh21 · Pull Request #6256 · feast-dev/feast
X Title: feat: Add feature view versioning support to FAISS online store by YassinNouh21 · Pull Request #6256 · feast-dev/feast
Description: Summary When enable_online_feature_view_versioning is enabled, FAISS indices are namespaced by versioned table keys (e.g. project_driver_stats_v2) so multiple feature view versions coexist in memory Refactored singleton _index/_in_memory_store to per-table dictionaries (_indices/_in_memory_stores) Reuses shared compute_table_id() from helpers.py for consistency with PostgreSQL and MySQL stores (#6193) Registered FaissOnlineStore in _check_versioned_read_support() gate What this PR does / why we need it Closes #6173 Feature view versioning was introduced in #6101, but version-qualified feature references (e.g. driver_stats@v2:trips_today) only worked with SQLite, PostgreSQL, and MySQL online stores. All other online stores raised VersionedOnlineReadNotSupported when a versioned ref was used. This PR adds versioned read/write support to the FAISS online store, following the same pattern as the PostgreSQL/MySQL implementation (#6193): Write path: when enable_online_feature_view_versioning is enabled, _table_id appends a _v{N} suffix to the in-memory key namespace, routing materialization to the correct versioned index Read path: version-qualified lookups (@v2) set projection.version_tag on the feature view; _table_id picks this up and routes to the correct index. projection.version_tag takes priority over current_version_number Multi-table support: replaced single class-level _index/_in_memory_store with per-table _indices/_in_memory_stores dicts Gate: _check_versioned_read_support in online_store.py now allows FaissOnlineStore through Which issue(s) this PR fixes Part of #2728 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Added 16 unit tests covering _table_id with versioning disabled/enabled, projection.version_tag priority over current_version_number, version 0 edge case, versioned read support gate, versioned write/read round trips, namespace isolation between versions, missing index handling, and teardown cleanup.
Open Graph Description: Summary When enable_online_feature_view_versioning is enabled, FAISS indices are namespaced by versioned table keys (e.g. project_driver_stats_v2) so multiple feature view versions coexist in memo...
X Description: Summary When enable_online_feature_view_versioning is enabled, FAISS indices are namespaced by versioned table keys (e.g. project_driver_stats_v2) so multiple feature view versions coexist in memo...
Opengraph URL: https://github.com/feast-dev/feast/pull/6256
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c68a0cb0-e26f-15d4-d927-7574943ac67e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A12A:3FF092:E182B2:13614A4:6A4DD500 |
| html-safe-nonce | 33b630293a20d3e28be6cb3264ed81c954b7a0fb2b353a96477a41d812febad2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTJBOjNGRjA5MjpFMTgyQjI6MTM2MTRBNDo2QTRERDUwMCIsInZpc2l0b3JfaWQiOiI4OTY3NTMwOTQ3MTY4NTU2Mjg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8658b95dad4806d6d079497aaccebb84afc462c82e113bb9a012ca97cd5efb38 |
| hovercard-subject-tag | pull_request:3513410173 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6256/files |
| twitter:image | https://avatars.githubusercontent.com/u/70436855?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/70436855?s=400&v=4 |
| og:image:alt | Summary When enable_online_feature_view_versioning is enabled, FAISS indices are namespaced by versioned table keys (e.g. project_driver_stats_v2) so multiple feature view versions coexist in memo... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width