Title: fix: Filter empty SQL commands at execute_snowflake_statement call sites by jials · Pull Request #6249 · feast-dev/feast · GitHub
Open Graph Title: fix: Filter empty SQL commands at execute_snowflake_statement call sites by jials · Pull Request #6249 · feast-dev/feast
X Title: fix: Filter empty SQL commands at execute_snowflake_statement call sites by jials · Pull Request #6249 · feast-dev/feast
Description: What this PR does / why we need it: When SnowflakeRegistry splits .sql files by ;, trailing semicolons produce empty strings that get passed to execute_snowflake_statement. The PR moves that filtering to the call sites, stripping and discarding empty commands before execution. Which issue(s) this PR fixes: Fixes #5204 (partially) Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Misc
Open Graph Description: What this PR does / why we need it: When SnowflakeRegistry splits .sql files by ;, trailing semicolons produce empty strings that get passed to execute_snowflake_statement. The PR moves that filter...
X Description: What this PR does / why we need it: When SnowflakeRegistry splits .sql files by ;, trailing semicolons produce empty strings that get passed to execute_snowflake_statement. The PR moves that filter...
Opengraph URL: https://github.com/feast-dev/feast/pull/6249
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a15c972b-59eb-edfd-d3a5-4d71126d79a3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C5C6:1BD3C:33378B:49DCDC:6A4E0329 |
| html-safe-nonce | 26cddec5c7577113d84e4c32b0637a098a75ca81eb1822525e21651708656970 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUM2OjFCRDNDOjMzMzc4Qjo0OURDREM6NkE0RTAzMjkiLCJ2aXNpdG9yX2lkIjoiNjIxMjIwODM2NjIwNDA5MzIyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 27b1f93a353c2c548043ab9ba3b9e9ed502688b5a51b2141395985ff0835520f |
| hovercard-subject-tag | pull_request:3506395890 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6249/files |
| twitter:image | https://avatars.githubusercontent.com/u/5955220?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5955220?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: When SnowflakeRegistry splits .sql files by ;, trailing semicolons produce empty strings that get passed to execute_snowflake_statement. The PR moves that filter... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | df0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 52bde38e24398476f8eb1e0760c81346c6a00812 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width