Title: fix: Correct project_id scoping in get_user_metadata and delete_project by Abhishek8108 · Pull Request #6248 · feast-dev/feast · GitHub
Open Graph Title: fix: Correct project_id scoping in get_user_metadata and delete_project by Abhishek8108 · Pull Request #6248 · feast-dev/feast
X Title: fix: Correct project_id scoping in get_user_metadata and delete_project by Abhishek8108 · Pull Request #6248 · feast-dev/feast
Description: Summary Two pre-existing SQL correctness bugs in SnowflakeRegistry, noticed while working on #6243. get_user_metadata (line 1119) The SELECT query filtered only by {fv_column_name}_name, without scoping to project_id. The primary key for feature view tables is (feature_view_name, project_id), so in a shared Snowflake registry this could return user metadata from a different project's feature view with the same name. Fixed by adding project_id = '{project}' to the WHERE clause — consistent with apply_user_metadata which already does this correctly. delete_project (line 1326) The DELETE query interpolated project, which is a Project object returned by self.get_project(name). Project.__str__ returns str(MessageToJson(self.to_proto())) — a JSON blob — which never matches any project_id stored in the database. This made delete_project a silent no-op: all DELETE statements executed successfully but matched zero rows. Fixed by using the name string parameter directly. Testing Both are SQL correctness fixes. The existing integration test suite in test_universal_registry.py covers both methods end-to-end; no new unit test surface is introduced by these changes. Relates to #6243.
Open Graph Description: Summary Two pre-existing SQL correctness bugs in SnowflakeRegistry, noticed while working on #6243. get_user_metadata (line 1119) The SELECT query filtered only by {fv_column_name}_name, without sc...
X Description: Summary Two pre-existing SQL correctness bugs in SnowflakeRegistry, noticed while working on #6243. get_user_metadata (line 1119) The SELECT query filtered only by {fv_column_name}_name, without sc...
Opengraph URL: https://github.com/feast-dev/feast/pull/6248
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1ed1aeea-4bf0-a13b-d295-7b18002e52db |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D7EE:18BA88:3F77612:57FE8A7:6A4F5C27 |
| html-safe-nonce | e907c8c2d6eae43e843f4897984c0aeb9466aa7ed2aa0b129320a96eca678944 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0VFOjE4QkE4ODozRjc3NjEyOjU3RkU4QTc6NkE0RjVDMjciLCJ2aXNpdG9yX2lkIjoiNzUzODk2MzUzNTMzNTc0MjUwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6489188b2d840b2827ae1f88a4efea2c61c72d0544cb4e0f19a225e5df55a109 |
| hovercard-subject-tag | pull_request:3505317654 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6248/files |
| twitter:image | https://avatars.githubusercontent.com/u/87538407?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/87538407?s=400&v=4 |
| og:image:alt | Summary Two pre-existing SQL correctness bugs in SnowflakeRegistry, noticed while working on #6243. get_user_metadata (line 1119) The SELECT query filtered only by {fv_column_name}_name, without sc... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width