Title: fix: Add project_id filter to SnowflakeRegistry UPDATE path by Abhishek8108 · Pull Request #6243 · feast-dev/feast · GitHub
Open Graph Title: fix: Add project_id filter to SnowflakeRegistry UPDATE path by Abhishek8108 · Pull Request #6243 · feast-dev/feast
X Title: fix: Add project_id filter to SnowflakeRegistry UPDATE path by Abhishek8108 · Pull Request #6243 · feast-dev/feast
Description: Summary Fixes #6208. SnowflakeRegistry._apply_object had a missing project_id clause in the UPDATE branch's WHERE condition. In a shared Snowflake registry, this allowed a feast apply in one project to silently overwrite a same-named object belonging to a different project. Root cause: The helper has two SQL branches: SELECT (existence check) — correctly scoped: WHERE project_id = '{project}' AND {id_field} = '{name}' UPDATE (overwrite) — was missing project_id: WHERE {id_field} = '{name}' The fix brings the UPDATE path in line with the SELECT and DELETE paths, which already scoped by project_id correctly. Impact: Affects all resource types routed through _apply_object — entities, data sources, feature views, feature services, saved datasets, validation references, permissions, and infrastructure objects. Changes sdk/python/feast/infra/registry/snowflake.py — add project_id = '{project}' AND to the UPDATE WHERE clause (one line) sdk/python/tests/unit/infra/registry/test_snowflake_registry.py — new regression test; mocks the Snowflake connection, drives _apply_object into the UPDATE path, and asserts project_id appears in the WHERE clause Test plan New regression test passes: pytest sdk/python/tests/unit/infra/registry/test_snowflake_registry.py -v All existing registry unit tests pass: pytest sdk/python/tests/unit/infra/registry/ -v Manually verified UPDATE query now reads: WHERE project_id = '{project}' AND {id_field} = '{name}'
Open Graph Description: Summary Fixes #6208. SnowflakeRegistry._apply_object had a missing project_id clause in the UPDATE branch's WHERE condition. In a shared Snowflake registry, this allowed a feast apply in one pr...
X Description: Summary Fixes #6208. SnowflakeRegistry._apply_object had a missing project_id clause in the UPDATE branch's WHERE condition. In a shared Snowflake registry, this allowed a feast apply in on...
Opengraph URL: https://github.com/feast-dev/feast/pull/6243
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:28f98abd-07ab-39c4-3c29-2c6824e860f7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D10E:18C93:333FE25:46C0CEF:6A4F2B49 |
| html-safe-nonce | f2af9cffb882094e7e1a88f43ad8a762230cdc27a9af55ff3ebf141c4818e77b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTBFOjE4QzkzOjMzM0ZFMjU6NDZDMENFRjo2QTRGMkI0OSIsInZpc2l0b3JfaWQiOiIxMjgxNzk5MjM3MTI2Nzk0MDU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 318adc53b460fba7fb437dce977f0ffba8c0827d8c9c08343733149e3538c53c |
| hovercard-subject-tag | pull_request:3504974853 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6243/files |
| twitter:image | https://avatars.githubusercontent.com/u/87538407?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/87538407?s=400&v=4 |
| og:image:alt | Summary Fixes #6208. SnowflakeRegistry._apply_object had a missing project_id clause in the UPDATE branch's WHERE condition. In a shared Snowflake registry, this allowed a feast apply in one pr... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width