Title: fix: scope data source operations by project in shared registry by mango766 · Pull Request #6207 · feast-dev/feast · GitHub
Open Graph Title: fix: scope data source operations by project in shared registry by mango766 · Pull Request #6207 · feast-dev/feast
X Title: fix: scope data source operations by project in shared registry by mango766 · Pull Request #6207 · feast-dev/feast
Description: Summary Fixes #6206 apply_data_source and delete_data_source in Registry match data sources by name only, without filtering by project. When multiple projects share the same registry and have data sources with the same name (e.g. the default vals_to_add), this causes cross-project overwrites. Fix Add the project filter to both methods, consistent with how apply_entity (line 349-352), apply_feature_service (line 447-451), and apply_feature_view (line 779-781) already scope their lookups. apply_data_source: existing_data_source_proto.name == data_source.name and existing_data_source_proto.project == project delete_data_source: data_source_proto.name == name and data_source_proto.project == project Test plan feast apply for project A with data source vals_to_add does not overwrite project B's vals_to_add feast apply for the same project still correctly updates existing data sources Deleting a data source only removes the one in the specified project
Open Graph Description: Summary Fixes #6206 apply_data_source and delete_data_source in Registry match data sources by name only, without filtering by project. When multiple projects share the same registry and have data ...
X Description: Summary Fixes #6206 apply_data_source and delete_data_source in Registry match data sources by name only, without filtering by project. When multiple projects share the same registry and have data ...
Opengraph URL: https://github.com/feast-dev/feast/pull/6207
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3e641af8-6d9a-c3f6-a559-908fe857f5a4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 85A6:3F60C6:2782C60:36F528E:6A4F5533 |
| html-safe-nonce | a65e75977b9dff1b2f08d420eb4fb7448c97bb78ee340845fb211b17b56c2a44 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUE2OjNGNjBDNjoyNzgyQzYwOjM2RjUyOEU6NkE0RjU1MzMiLCJ2aXNpdG9yX2lkIjoiNTg5NTcyMTYyNzg0NTM1MDcwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4e05a91ce3fc5cb1952b21a2a0a6af0b1e8ae1a1785a1daffc782abaaeab6a67 |
| hovercard-subject-tag | pull_request:3475274839 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6207/files |
| twitter:image | https://avatars.githubusercontent.com/u/85663565?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/85663565?s=400&v=4 |
| og:image:alt | Summary Fixes #6206 apply_data_source and delete_data_source in Registry match data sources by name only, without filtering by project. When multiple projects share the same registry and have data ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width