Title: feat: Add versioning support for DynamoDB online store by rpathade · Pull Request #6191 · feast-dev/feast · GitHub
Open Graph Title: feat: Add versioning support for DynamoDB online store by rpathade · Pull Request #6191 · feast-dev/feast
X Title: feat: Add versioning support for DynamoDB online store by rpathade · Pull Request #6191 · feast-dev/feast
Description: What this PR does / why we need it Closes #6163 Feature view versioning was introduced in #6101, but version-qualified feature references (e.g. driver_stats@v2:trips_today) only worked with the SQLite online store. All other online stores raised VersionedOnlineReadNotSupported when a versioned ref was used. This PR adds versioned read/write support to the DynamoDB online store, following the same pattern as the SQLite reference implementation: Write path: when enable_online_feature_view_versioning is enabled, _get_table_name appends a _v{N} suffix to the DynamoDB table name (e.g. project.driver_stats_v2), routing materialization to the correct versioned table Read path: version-qualified lookups (@v2) set projection.version_tag on the feature view before online_read is called; _get_table_name picks this up and routes to the correct table. projection.version_tag takes priority over current_version_number so explicit version requests are always honoured Gate: _check_versioned_read_support in online_store.py now allows DynamoDBOnlineStore through, covering both sync and async read paths All existing read/write/update/teardown methods are covered by the single change to _get_table_name since every method routes through it. Which issue(s) this PR fixes Part of #2728 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests — 6 new unit tests for _get_table_name covering: versioning disabled, projection.version_tag priority, current_version_number fallback, version 0 edge case, no version info, custom template Manual tests — end-to-end smoke test using moto (mocked DynamoDB) exercising write → read round trips across v1/v2 isolation, fallback behaviour, and missing entity handling Misc The version suffix is composed before the table_name_template is applied, so custom table_name_template values (e.g. "{project}__{table_name}") continue to work correctly with versioning enabled.
Open Graph Description: What this PR does / why we need it Closes #6163 Feature view versioning was introduced in #6101, but version-qualified feature references (e.g. driver_stats@v2:trips_today) only worked with the SQL...
X Description: What this PR does / why we need it Closes #6163 Feature view versioning was introduced in #6101, but version-qualified feature references (e.g. driver_stats@v2:trips_today) only worked with the SQL...
Opengraph URL: https://github.com/feast-dev/feast/pull/6191
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:289f2df4-6f14-d3ae-dd94-d63a1f36b0cf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9DEE:1BDC7:CB78F9:11A6D4A:6A4DE5DE |
| html-safe-nonce | 1b093ea3ad4b6f9a92e699751ab23fc55fe73836c92a5615ac30c0500cf5bcee |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REVFOjFCREM3OkNCNzhGOToxMUE2RDRBOjZBNERFNURFIiwidmlzaXRvcl9pZCI6IjQ4NTY4NjA4MjY2ODg5Mzk0ODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 80093f645f66d63e7401aff368fcc2cc45c92ff8469932bce2b0a2b14b2ef3fe |
| hovercard-subject-tag | pull_request:3462006818 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6191/files |
| twitter:image | https://avatars.githubusercontent.com/u/73137503?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/73137503?s=400&v=4 |
| og:image:alt | What this PR does / why we need it Closes #6163 Feature view versioning was introduced in #6101, but version-qualified feature references (e.g. driver_stats@v2:trips_today) only worked with the SQL... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width