René's URL Explorer Experiment


Title: fix: ODFV output projection in offline retrieval (#6099) by jyejare · Pull Request #6140 · feast-dev/feast · GitHub

Open Graph Title: fix: ODFV output projection in offline retrieval (#6099) by jyejare · Pull Request #6140 · feast-dev/feast

X Title: fix: ODFV output projection in offline retrieval (#6099) by jyejare · Pull Request #6140 · feast-dev/feast

Description: Summary Fixes #6099 - Ensures offline retrieval honors ODFV feature projection, matching online retrieval behavior. Problem When requesting a subset of features from an OnDemandFeatureView: Online retrieval ✅ Returns only requested features Offline retrieval ❌ Returns ALL ODFV output features (before this fix) This caused schema mismatches between training and serving pipelines. Solution Modified RetrievalJob.to_arrow() in offline_store.py to: Parse requested features from metadata.features Build a mapping of ODFV name → requested feature names Filter ODFV transformation output to only include requested columns Example Before this fix: features = ["my_odfv:feature_a"] offline_result = store.get_historical_features(features=features, ...) # Columns: driver_id, event_timestamp, feature_a, feature_b, feature_c ❌ After this fix: features = ["my_odfv:feature_a"] offline_result = store.get_historical_features(features=features, ...) # Columns: driver_id, event_timestamp, feature_a ✅ Changes Modified: sdk/python/feast/infra/offline_stores/offline_store.py Updated RetrievalJob.to_arrow() method (lines 140-184) Added filtering logic for ODFV output projection Maintains backward compatibility Added: Test in sdk/python/tests/integration/offline_store/test_universal_historical_retrieval.py test_odfv_projection() - Comprehensive test verifying: Single feature request returns only that feature Multiple feature request returns only requested features Unrequested features are NOT included Offline and online retrieval have consistent behavior Parametrized for both full_feature_names=True and False Testing The new test test_odfv_projection verifies: ✅ Requesting 1 out of 3 ODFV features → returns only that 1 feature ✅ Requesting 2 out of 3 ODFV features → returns only those 2 features ✅ Unrequested features are NOT included in the result ✅ Offline and online retrieval return consistent schemas Backward Compatibility ✅ Falls back to old behavior if metadata is unavailable ✅ No breaking changes to existing functionality ✅ Only affects ODFV feature projection Impact This fix ensures: ✅ Consistent behavior between online and offline retrieval ✅ No schema mismatches in ML pipelines ✅ More efficient - doesn't compute/return unnecessary features ✅ Matches user expectations - returns exactly what was requested

Open Graph Description: Summary Fixes #6099 - Ensures offline retrieval honors ODFV feature projection, matching online retrieval behavior. Problem When requesting a subset of features from an OnDemandFeatureView: Online...

X Description: Summary Fixes #6099 - Ensures offline retrieval honors ODFV feature projection, matching online retrieval behavior. Problem When requesting a subset of features from an OnDemandFeatureView: Online...

Opengraph URL: https://github.com/feast-dev/feast/pull/6140

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4ada9a2f-3bd6-ce3b-1ade-e317d6128248
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCCE0:2826BD:11BB8F0:1766466:6AFEA270
html-safe-noncef1ef854847d3638c08d5d39209674e8140f13cf3408af6b63a6f821113242f91
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0UwOjI4MjZCRDoxMUJCOEYwOjE3NjY0NjY6NkFGRUEyNzAiLCJ2aXNpdG9yX2lkIjoiMTg5OTQ2NzUxNjI5MjI3Njg0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb3f21a1da7c28c17a99b3e3915a2352c69f60443d251ee8001cfb2cb50e81024
hovercard-subject-tagpull_request:3432738330
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6140/files
twitter:imagehttps://avatars.githubusercontent.com/u/11752425?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11752425?s=400&v=4
og:image:altSummary Fixes #6099 - Ensures offline retrieval honors ODFV feature projection, matching online retrieval behavior. Problem When requesting a subset of features from an OnDemandFeatureView: Online...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3f25273206cd841171bca0002261ae4c9757d934
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6140/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6140%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6140%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6140/files
Reloadhttps://github.com/feast-dev/feast/pull/6140/files
Reloadhttps://github.com/feast-dev/feast/pull/6140/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
jyejare:fix/odfv-output-projection-6099https://github.com/jyejare/feast/tree/fix/odfv-output-projection-6099
Conversation 13 https://github.com/feast-dev/feast/pull/6140
Commits 1 https://github.com/feast-dev/feast/pull/6140/commits
Checks 25 https://github.com/feast-dev/feast/pull/6140/checks
Files changed https://github.com/feast-dev/feast/pull/6140/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6140/files
fix: ODFV output projection in offline retrieval (#6099) https://github.com/feast-dev/feast/pull/6140/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6140/files
f9a2751 Fix ODFV output projection in offline retrieval (#6099) Mar 23, 2026 https://github.com/feast-dev/feast/pull/6140/commits/f9a27514eb6159ad0918a72b3da86601e939007f
Clear filters https://github.com/feast-dev/feast/pull/6140/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6140/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6140/files
feature_store.py https://github.com/feast-dev/feast/pull/6140/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
offline_store.py https://github.com/feast-dev/feast/pull/6140/files#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
utils.py https://github.com/feast-dev/feast/pull/6140/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
test_universal_historical_retrieval.py https://github.com/feast-dev/feast/pull/6140/files#diff-3bb5de0560a06ec0e2cc747437f20195a574512498e0e628382bf74134e8542b
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/feature_store.pyhttps://github.com/feast-dev/feast/pull/6140/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
View file https://github.com/jyejare/feast/blob/f9a27514eb6159ad0918a72b3da86601e939007f/sdk/python/feast/feature_store.py
Open in desktop https://desktop.github.com
devin-ai-integrationhttps://github.com/apps/devin-ai-integration
Apr 2, 2026https://github.com/feast-dev/feast/pull/6140/files#r3026376743
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://app.devin.ai/review/feast-dev/feast/pull/6140
Please reload this pagehttps://github.com/feast-dev/feast/pull/6140/files
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6140/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6140/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/6140/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/6140/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L23
sdk/python/feast/infra/offline_stores/offline_store.pyhttps://github.com/feast-dev/feast/pull/6140/files#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
View file https://github.com/jyejare/feast/blob/f9a27514eb6159ad0918a72b3da86601e939007f/sdk/python/feast/infra/offline_stores/offline_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6140/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6140/files#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
https://github.com/feast-dev/feast/pull/6140/files#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/utils.pyhttps://github.com/feast-dev/feast/pull/6140/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
View file https://github.com/jyejare/feast/blob/f9a27514eb6159ad0918a72b3da86601e939007f/sdk/python/feast/utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6140/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6140/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/pull/6140/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/integration/offline_store/test_universal_historical_retrieval.pyhttps://github.com/feast-dev/feast/pull/6140/files#diff-3bb5de0560a06ec0e2cc747437f20195a574512498e0e628382bf74134e8542b
View file https://github.com/jyejare/feast/blob/f9a27514eb6159ad0918a72b3da86601e939007f/sdk/python/tests/integration/offline_store/test_universal_historical_retrieval.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6140/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6140/files#diff-3bb5de0560a06ec0e2cc747437f20195a574512498e0e628382bf74134e8542b
Please reload this pagehttps://github.com/feast-dev/feast/pull/6140/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.