René's URL Explorer Experiment


Title: fix(postgres): Use end_date in synthetic entity_df for non-entity retrieval by YassinNouh21 · Pull Request #6110 · feast-dev/feast · GitHub

Open Graph Title: fix(postgres): Use end_date in synthetic entity_df for non-entity retrieval by YassinNouh21 · Pull Request #6110 · feast-dev/feast

X Title: fix(postgres): Use end_date in synthetic entity_df for non-entity retrieval by YassinNouh21 · Pull Request #6110 · feast-dev/feast

Description: Summary The non-entity retrieval path (entity_df=None) created a synthetic entity_df using pd.date_range(start=start_date, ...)[:1], which placed start_date as the event timestamp Since PIT joins use MAX(entity_timestamp) as the upper bound, using start_date made end_date unreachable — no features after start_date would be returned Fix: use [end_date] directly, matching the ClickHouse (#6066) and Dask implementations Test plan Added regression test test_non_entity_entity_df_uses_end_date that captures the synthetic entity_df and asserts its timestamp equals end_date All existing TestNonEntityRetrieval tests pass No changes to the query template or other code paths Fixes the bug identified during review of #6066, referenced in #6057.

Open Graph Description: Summary The non-entity retrieval path (entity_df=None) created a synthetic entity_df using pd.date_range(start=start_date, ...)[:1], which placed start_date as the event timestamp Since PIT joins ...

X Description: Summary The non-entity retrieval path (entity_df=None) created a synthetic entity_df using pd.date_range(start=start_date, ...)[:1], which placed start_date as the event timestamp Since PIT joins ...

Opengraph URL: https://github.com/feast-dev/feast/pull/6110

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:97ad9599-36c9-510f-eaac-ddbf2de45d82
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8FA4:35267D:37565:4AE85:6A4D90C7
html-safe-noncee2b09c863ec0bec40997f0f34a309f27f95e0a289760e4e87f50f0c4731e97aa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RkE0OjM1MjY3RDozNzU2NTo0QUU4NTo2QTREOTBDNyIsInZpc2l0b3JfaWQiOiIyMjk3MjkwOTM2NTQxODc2NDIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac66c0472364efbe13cb73986b70eb3c36ea53456f3b1c3a0d7da8d699ab14ef26
hovercard-subject-tagpull_request:3401470452
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6110/files
twitter:imagehttps://avatars.githubusercontent.com/u/70436855?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/70436855?s=400&v=4
og:image:altSummary The non-entity retrieval path (entity_df=None) created a synthetic entity_df using pd.date_range(start=start_date, ...)[:1], which placed start_date as the event timestamp Since PIT joins ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release74e2a9c78f1e38588de4f25885878349d721eedf
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6110/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6110%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6110%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6110/files
Reloadhttps://github.com/feast-dev/feast/pull/6110/files
Reloadhttps://github.com/feast-dev/feast/pull/6110/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6110/files
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.4k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 7.1k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 213 https://github.com/feast-dev/feast/issues
Pull requests 172 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security and quality 1 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security and quality https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
franciscojavierarceohttps://github.com/franciscojavierarceo
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
YassinNouh21:fix/postgres-entity-df-timestamphttps://github.com/YassinNouh21/feast/tree/fix/postgres-entity-df-timestamp
Conversation 5 https://github.com/feast-dev/feast/pull/6110
Commits 6 https://github.com/feast-dev/feast/pull/6110/commits
Checks 25 https://github.com/feast-dev/feast/pull/6110/checks
Files changed https://github.com/feast-dev/feast/pull/6110/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6110/files
fix(postgres): Use end_date in synthetic entity_df for non-entity retrieval https://github.com/feast-dev/feast/pull/6110/files#top
Show all changes 6 commits https://github.com/feast-dev/feast/pull/6110/files
558e864 fix(postgres): Use end_date instead of start_date in synthetic entity… YassinNouh21 Mar 15, 2026 https://github.com/feast-dev/feast/pull/6110/commits/558e8642bf349ad5ff7e70234696f53255147bbd
e82371d fix: preserve timestamp range for min_event_timestamp and fix formatting YassinNouh21 Mar 15, 2026 https://github.com/feast-dev/feast/pull/6110/commits/e82371d475b12a9c2b06876db0046d785e051140
4feb935 Merge branch 'master' into fix/postgres-entity-df-timestamp YassinNouh21 Mar 16, 2026 https://github.com/feast-dev/feast/pull/6110/commits/4feb93516a5a54c177b067606031401a65c79f64
7a4b365 Merge branch 'master' into fix/postgres-entity-df-timestamp YassinNouh21 Mar 16, 2026 https://github.com/feast-dev/feast/pull/6110/commits/7a4b365a9fc3a67b59c501fcfbaea5101d278354
271825e test: add integration test for non-entity retrieval YassinNouh21 Mar 16, 2026 https://github.com/feast-dev/feast/pull/6110/commits/271825e3225dd4825e1285988ae421febcba3122
f06f660 Merge branch 'master' into fix/postgres-entity-df-timestamp franciscojavierarceo Mar 17, 2026 https://github.com/feast-dev/feast/pull/6110/commits/f06f66079b4a48e8457f912e79cc27c5dc80a20c
Clear filters https://github.com/feast-dev/feast/pull/6110/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6110/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6110/files
postgres.py https://github.com/feast-dev/feast/pull/6110/files#diff-a994d03a46cff3078563437b7f11cce95d7919665760e53f86a4cd5bad471c56
test_universal_historical_retrieval.py https://github.com/feast-dev/feast/pull/6110/files#diff-3bb5de0560a06ec0e2cc747437f20195a574512498e0e628382bf74134e8542b
test_postgres.py https://github.com/feast-dev/feast/pull/6110/files#diff-a5a255620ee9fc4e7a42457ec896ced17a8323cf729ca8e2a6d9490732411eeb
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.pyhttps://github.com/feast-dev/feast/pull/6110/files#diff-a994d03a46cff3078563437b7f11cce95d7919665760e53f86a4cd5bad471c56
View file https://github.com/YassinNouh21/feast/blob/f06f66079b4a48e8457f912e79cc27c5dc80a20c/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6110/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6110/files#diff-a994d03a46cff3078563437b7f11cce95d7919665760e53f86a4cd5bad471c56
Please reload this pagehttps://github.com/feast-dev/feast/pull/6110/files
https://github.com/feast-dev/feast/pull/6110/files#diff-a994d03a46cff3078563437b7f11cce95d7919665760e53f86a4cd5bad471c56
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/integration/offline_store/test_universal_historical_retrieval.pyhttps://github.com/feast-dev/feast/pull/6110/files#diff-3bb5de0560a06ec0e2cc747437f20195a574512498e0e628382bf74134e8542b
View file https://github.com/YassinNouh21/feast/blob/f06f66079b4a48e8457f912e79cc27c5dc80a20c/sdk/python/tests/integration/offline_store/test_universal_historical_retrieval.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6110/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6110/files#diff-3bb5de0560a06ec0e2cc747437f20195a574512498e0e628382bf74134e8542b
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/offline_stores/contrib/postgres_offline_store/test_postgres.pyhttps://github.com/feast-dev/feast/pull/6110/files#diff-a5a255620ee9fc4e7a42457ec896ced17a8323cf729ca8e2a6d9490732411eeb
View file https://github.com/YassinNouh21/feast/blob/f06f66079b4a48e8457f912e79cc27c5dc80a20c/sdk/python/tests/unit/infra/offline_stores/contrib/postgres_offline_store/test_postgres.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6110/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6110/files#diff-a5a255620ee9fc4e7a42457ec896ced17a8323cf729ca8e2a6d9490732411eeb
https://github.com/feast-dev/feast/pull/6110/files#diff-a5a255620ee9fc4e7a42457ec896ced17a8323cf729ca8e2a6d9490732411eeb
Please reload this pagehttps://github.com/feast-dev/feast/pull/6110/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.