Title: fix: Remote Online Store Type Inference Error with All-NULL Columns by yuan1j · Pull Request #6063 · feast-dev/feast · GitHub
Open Graph Title: fix: Remote Online Store Type Inference Error with All-NULL Columns by yuan1j · Pull Request #6063 · feast-dev/feast
X Title: fix: Remote Online Store Type Inference Error with All-NULL Columns by yuan1j · Pull Request #6063 · feast-dev/feast
Description: What this PR does / why we need it
📋 Problem Description
When reading features from a Feast Remote Online Store, a TypeError is raised if an entire feature column contains only NULL/NaN values. The error occurs in the python_values_to_proto_values() function when it cannot infer the value type from empty data.
🔍 Root Cause Analysis
Component
Issue
Location
feast/type_map.py - python_values_to_proto_values() function
Trigger
Entire feature column contains NULL/NaN values
Reason
Type inference fails when all values are empty, resulting in UNKNOWN value type
Current Behavior
Raises TypeError: Couldn't infer value type from empty value
Impact
Remote online feature reading fails completely
📊 Test Data Example
event_timestamp driver_id conv_rate acc_rate avg_daily_trips
0 2026-03-04 16:17:44+00:00 1001 NaN 1.000000 1000.0
1 2026-02-17 16:00:00+00:00 1005 NaN 0.708060 395.0
2 2026-02-17 17:00:00+00:00 1005 NaN 0.451616 145.0
⚠️ Note: The conv_rate column contains all NaN values.
💡 Solution
Modify the type inference logic to handle UNKNOWN value types gracefully:
Key Changes
✅ Do not raise error when value type is UNKNOWN
✅ Preserve schema-defined type from FeatureView definition
✅ Return proper NULL values in the response while maintaining type information
Code Change Summary
# Before
if value_type is UNKNOWN:
raise TypeError("Couldn't infer value type from empty value")
# After
# Remove this part code, and use schema-defined type or skip type inference for NULL-only columns
✨ Expected Behavior
After this fix:
✅ Remote online store can read columns with all-NULL values
✅ Feature schema type is preserved from FeatureView definition
✅ NULL values are returned correctly to the client
✅ No breaking changes to existing functionality
Which issue(s) this PR fixes
Fixes: Remote Online Store Type Inference Error with All-NULL Columns
Related Error:
Traceback (most recent call last):
File "C:\svn\project\feature_store\feast\remote\test_workflow.py", line 130, in
Open Graph Description: What this PR does / why we need it 📋 Problem Description When reading features from a Feast Remote Online Store, a TypeError is raised if an entire feature column contains only NULL/NaN values. The...
X Description: What this PR does / why we need it 📋 Problem Description When reading features from a Feast Remote Online Store, a TypeError is raised if an entire feature column contains only NULL/NaN values. The...
Opengraph URL: https://github.com/feast-dev/feast/pull/6063
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b3814bc8-d1a4-732b-e946-514136a4d9a2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8190:1C7367:13C4970:1CC76AD:6A4E464A |
| html-safe-nonce | c48a706c792ad533a597291aa8e4becb303304485b9788db3e88acdf368c80a7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTkwOjFDNzM2NzoxM0M0OTcwOjFDQzc2QUQ6NkE0RTQ2NEEiLCJ2aXNpdG9yX2lkIjoiNDQ4MDQ5MzQzOTU0MDkzODMxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ec53f54ef1fc5fc3a72585776b3606cbb8f395f9ff6a343fe23e022709e551f2 |
| hovercard-subject-tag | pull_request:3353922254 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6063/files |
| twitter:image | https://avatars.githubusercontent.com/u/50416975?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/50416975?s=400&v=4 |
| og:image:alt | What this PR does / why we need it 📋 Problem Description When reading features from a Feast Remote Online Store, a TypeError is raised if an entire feature column contains only NULL/NaN values. The... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9fabff9b8b127e686a3ec86f91422e818056ca2c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width