René's URL Explorer Experiment


Title: Clean up OnlineServingService code by zhilingc · Pull Request #605 · feast-dev/feast · GitHub

Open Graph Title: Clean up OnlineServingService code by zhilingc · Pull Request #605 · feast-dev/feast

X Title: Clean up OnlineServingService code by zhilingc · Pull Request #605 · feast-dev/feast

Description: What this PR does / why we need it: Additional tweaks to the Storage Refactor PR #567. Addresses @ches 's comments to the PR.

Open Graph Description: What this PR does / why we need it: Additional tweaks to the Storage Refactor PR #567. Addresses @ches 's comments to the PR.

X Description: What this PR does / why we need it: Additional tweaks to the Storage Refactor PR #567. Addresses @ches 's comments to the PR.

Opengraph URL: https://github.com/feast-dev/feast/pull/605

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7590f103-2137-7fe7-94e7-bab714fdc523
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB44:281812:15FF8EC:1DE35A9:697A952E
html-safe-nonce5671418f800c7fa0938b02e107462fab201a4bd0422feb85db4af33a86fc7beb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjQ0OjI4MTgxMjoxNUZGOEVDOjFERTM1QTk6Njk3QTk1MkUiLCJ2aXNpdG9yX2lkIjoiODk5MzgwNTE0NzU5NDk4Njc5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac55a9c5441e4f09b8b31811abf36ae22d6dfe5a3d7e30ce2996a17224da93db88
hovercard-subject-tagpull_request:398865929
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/605/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/04cf5ce93307cc02743e0ab4391f0ee3a84120c7e2c0e5a4e15778974224223e/feast-dev/feast/pull/605
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/04cf5ce93307cc02743e0ab4391f0ee3a84120c7e2c0e5a4e15778974224223e/feast-dev/feast/pull/605
og:image:altWhat this PR does / why we need it: Additional tweaks to the Storage Refactor PR #567. Addresses @ches 's comments to the PR.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezhilingc
hostnamegithub.com
expected-hostnamegithub.com
None0912f2a9aa0160e08239520d461a4b4c4ce1caa972a8370b7442b94a38a194c5
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef8f5270c10a913bfa56f2dad4b864f1cda383754
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/605#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F605
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F605
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/605
Reloadhttps://github.com/feast-dev/feast/pull/605
Reloadhttps://github.com/feast-dev/feast/pull/605
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 183 https://github.com/feast-dev/feast/issues
Pull requests 68 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast/pull/605#issue-comment-box
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:storage-refactorhttps://github.com/feast-dev/feast/tree/storage-refactor
zhilingc:storage-refactor-fixeshttps://github.com/zhilingc/feast/tree/storage-refactor-fixes
Clean up OnlineServingService code https://github.com/feast-dev/feast/pull/605#top
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:storage-refactorhttps://github.com/feast-dev/feast/tree/storage-refactor
zhilingc:storage-refactor-fixeshttps://github.com/zhilingc/feast/tree/storage-refactor-fixes
Conversation 2 https://github.com/feast-dev/feast/pull/605
Commits 2 https://github.com/feast-dev/feast/pull/605/commits
Checks 0 https://github.com/feast-dev/feast/pull/605/checks
Files changed https://github.com/feast-dev/feast/pull/605/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/605
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Apr 5, 2020https://github.com/feast-dev/feast/pull/605#issue-594215686
#567https://github.com/feast-dev/feast/pull/567
@cheshttps://github.com/ches
Please reload this pagehttps://github.com/feast-dev/feast/pull/605
Clean up OnlineServingService code to be more readablehttps://github.com/feast-dev/feast/pull/605/commits/dbf6215490a55e41258fb8abc040ab1e7a18d033
dbf6215https://github.com/feast-dev/feast/pull/605/commits/dbf6215490a55e41258fb8abc040ab1e7a18d033
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
davidheryantohttps://github.com/davidheryanto
khorshuhenghttps://github.com/khorshuheng
pradithyahttps://github.com/pradithya
woophttps://github.com/woop
code ownershttps://github.com/feast-dev/feast/blob/7d0c95fe69fdf91792d5cd70ca2229c9eb7783bf/.github/CODEOWNERS#L4
April 5, 2020 02:17https://github.com/feast-dev/feast/pull/605#event-3200802975
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Apr 5, 2020https://github.com/feast-dev/feast/pull/605#issuecomment-609126855
zhilingchttps://github.com/gojek/feast/pull/605
herehttps://go.k8s.io/bot-commands?repo=gojek%2Ffeast
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/gojek/feast/blob/storage-refactor/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast/pull/605
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
Apr 5, 2020https://github.com/feast-dev/feast/pull/605#event-3200803028
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
cheshttps://github.com/ches
davidheryantohttps://github.com/davidheryanto
khorshuhenghttps://github.com/khorshuheng
pradithyahttps://github.com/pradithya
April 5, 2020 02:18https://github.com/feast-dev/feast/pull/605#event-3200803207
Revert Metricshttps://github.com/feast-dev/feast/pull/605/commits/18a1b4e82bfabc69d82d7936ba78bc807ef5530b
18a1b4ehttps://github.com/feast-dev/feast/pull/605/commits/18a1b4e82bfabc69d82d7936ba78bc807ef5530b
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
size/M https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FM
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
Apr 5, 2020https://github.com/feast-dev/feast/pull/605#event-3200807723
https://github.com/woop
woophttps://github.com/woop
Apr 6, 2020https://github.com/feast-dev/feast/pull/605#issuecomment-609590266
Please reload this pagehttps://github.com/feast-dev/feast/pull/605
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
woophttps://github.com/woop
Apr 6, 2020https://github.com/feast-dev/feast/pull/605#event-3203807817
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
Apr 6, 2020https://github.com/feast-dev/feast/pull/605#event-3203807875
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Apr 6, 2020https://github.com/feast-dev/feast/pull/605#event-3203809939
zhilingchttps://github.com/zhilingc
Apr 7, 2020 https://github.com/feast-dev/feast/pull/605#ref-commit-fa87a42
Clean up OnlineServingService code (https://github.com/feast-dev/feast/commit/fa87a42b991221690fe25067fb31ca37010f4fa1
#605https://github.com/feast-dev/feast/pull/605
)https://github.com/feast-dev/feast/commit/fa87a42b991221690fe25067fb31ca37010f4fa1
fa87a42https://github.com/feast-dev/feast/commit/fa87a42b991221690fe25067fb31ca37010f4fa1
feast-ci-bothttps://github.com/feast-ci-bot
Apr 7, 2020 https://github.com/feast-dev/feast/pull/605#ref-commit-e4f8fe9
Add general storage API and refactor existing store implementations (https://github.com/feast-dev/feast/commit/e4f8fe905d3c182416e1b69bf60bfbc0e8348f8a
#…https://github.com/feast-dev/feast/pull/567
e4f8fe9https://github.com/feast-dev/feast/commit/e4f8fe905d3c182416e1b69bf60bfbc0e8348f8a
…567https://github.com/feast-dev/feast/pull/567
#529https://github.com/feast-dev/feast/pull/529
#546https://github.com/feast-dev/feast/pull/546
#547https://github.com/feast-dev/feast/pull/547
#553https://github.com/feast-dev/feast/pull/553
#569https://github.com/feast-dev/feast/pull/569
#586https://github.com/feast-dev/feast/pull/586
#601https://github.com/feast-dev/feast/pull/601
#607https://github.com/feast-dev/feast/pull/607
#605https://github.com/feast-dev/feast/pull/605
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F605
https://github.com/woop
woop https://github.com/woop
https://github.com/ches
ches https://github.com/ches
https://github.com/woop
woop https://github.com/woop
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
size/M https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FM
Please reload this pagehttps://github.com/feast-dev/feast/pull/605
https://github.com/zhilingc
https://github.com/feast-ci-bot
https://github.com/woop
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.