René's URL Explorer Experiment


Title: Add better code docs to storage refactor by zhilingc · Pull Request #601 · feast-dev/feast · GitHub

Open Graph Title: Add better code docs to storage refactor by zhilingc · Pull Request #601 · feast-dev/feast

X Title: Add better code docs to storage refactor by zhilingc · Pull Request #601 · feast-dev/feast

Description: What this PR does / why we need it: Reopening this after rebasing on master. Addresses most of @woop 's comments on PR #567

Open Graph Description: What this PR does / why we need it: Reopening this after rebasing on master. Addresses most of @woop 's comments on PR #567

X Description: What this PR does / why we need it: Reopening this after rebasing on master. Addresses most of @woop 's comments on PR #567

Opengraph URL: https://github.com/feast-dev/feast/pull/601

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:eb0219e7-181d-331d-03ad-d9bd058ea03a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C62:31CCA9:1164415:1714A57:697D11FD
html-safe-noncef646073856063292a17d0e80a87be5cc08386a93ac44efa63a5561aa29b26dff
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzYyOjMxQ0NBOToxMTY0NDE1OjE3MTRBNTc6Njk3RDExRkQiLCJ2aXNpdG9yX2lkIjoiNTA0MjU3NjQ1ODA5NDgwOTU5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4a94683de9eaf78de23dd35d46b5c9920a41d7ef3bd9f68b675a4ebcdb343417
hovercard-subject-tagpull_request:398151175
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/601/files
twitter:imagehttps://avatars.githubusercontent.com/u/15104168?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15104168?s=400&v=4
og:image:altWhat this PR does / why we need it: Reopening this after rebasing on master. Addresses most of @woop 's comments on PR #567
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef4270289760ed79c539b4df0bf901fb752ee16d6a98c6589b1c6b6d5d4e1a000
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7add7da55b3463f73608a5dd149b156c4e76f2b8
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/601/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F601%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F601%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/601/files
Reloadhttps://github.com/feast-dev/feast/pull/601/files
Reloadhttps://github.com/feast-dev/feast/pull/601/files
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 182 https://github.com/feast-dev/feast/issues
Pull requests 68 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:storage-refactorhttps://github.com/feast-dev/feast/tree/storage-refactor
zhilingc:storage-refactor-fix-2https://github.com/zhilingc/feast/tree/storage-refactor-fix-2
Conversation 6 https://github.com/feast-dev/feast/pull/601
Commits 3 https://github.com/feast-dev/feast/pull/601/commits
Checks 0 https://github.com/feast-dev/feast/pull/601/checks
Files changed https://github.com/feast-dev/feast/pull/601/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/601/files
Add better code docs to storage refactor https://github.com/feast-dev/feast/pull/601/files#top
Show all changes 3 commits https://github.com/feast-dev/feast/pull/601/files
9201f7d Add better code documentation, make GetFeastServingInfo independent o… Apr 3, 2020 https://github.com/feast-dev/feast/pull/601/commits/9201f7d93271685c784bc5886c09ff411fe461b5
e690071 Make getStagingLocation method of historical retriever Apr 4, 2020 https://github.com/feast-dev/feast/pull/601/commits/e69007115f142df3e82b51d48176123d564b8bba
2bf0f0b Apply spotless Apr 4, 2020 https://github.com/feast-dev/feast/pull/601/commits/2bf0f0b87874c00534ff5585ab12b066dc15bf72
Clear filters https://github.com/feast-dev/feast/pull/601/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/601/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/601/files
HistoricalServingService.java https://github.com/feast-dev/feast/pull/601/files#diff-a97c9f4389285f43f623c10954e091e55553a16623c9313c0d6e82e7f3f3e4e2
OnlineServingService.java https://github.com/feast-dev/feast/pull/601/files#diff-c4e505e88f47ba8f2bc3821177d88c62afcdfcac8c08be139038a42266038de5
ServingService.java https://github.com/feast-dev/feast/pull/601/files#diff-1138d2178c63a310eea720381043dbfbd922f3ec641ddf13bed6f5da48a8d665
HistoricalRetriever.java https://github.com/feast-dev/feast/pull/601/files#diff-dfd1293ea71ffd918ffb01c08f0e1d35cbfb8ec4925b8b6b7bae96103d82c169
BigQueryHistoricalRetriever.java https://github.com/feast-dev/feast/pull/601/files#diff-71b4aa482bcfa9e394abf10bf735eaa0bca5529fb8f3235e7b4ed7b18b19d3f7
serving/src/main/java/feast/serving/service/HistoricalServingService.javahttps://github.com/feast-dev/feast/pull/601/files#diff-a97c9f4389285f43f623c10954e091e55553a16623c9313c0d6e82e7f3f3e4e2
View file https://github.com/zhilingc/feast/blob/2bf0f0b87874c00534ff5585ab12b066dc15bf72/serving/src/main/java/feast/serving/service/HistoricalServingService.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/601/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/601/files#diff-a97c9f4389285f43f623c10954e091e55553a16623c9313c0d6e82e7f3f3e4e2
https://github.com/feast-dev/feast/pull/601/files#diff-a97c9f4389285f43f623c10954e091e55553a16623c9313c0d6e82e7f3f3e4e2
https://github.com/feast-dev/feast/pull/601/files#diff-a97c9f4389285f43f623c10954e091e55553a16623c9313c0d6e82e7f3f3e4e2
serving/src/main/java/feast/serving/service/OnlineServingService.javahttps://github.com/feast-dev/feast/pull/601/files#diff-c4e505e88f47ba8f2bc3821177d88c62afcdfcac8c08be139038a42266038de5
View file https://github.com/zhilingc/feast/blob/2bf0f0b87874c00534ff5585ab12b066dc15bf72/serving/src/main/java/feast/serving/service/OnlineServingService.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/601/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/601/files#diff-c4e505e88f47ba8f2bc3821177d88c62afcdfcac8c08be139038a42266038de5
https://github.com/feast-dev/feast/pull/601/files#diff-c4e505e88f47ba8f2bc3821177d88c62afcdfcac8c08be139038a42266038de5
https://github.com/feast-dev/feast/pull/601/files#diff-c4e505e88f47ba8f2bc3821177d88c62afcdfcac8c08be139038a42266038de5
https://github.com/feast-dev/feast/pull/601/files#diff-c4e505e88f47ba8f2bc3821177d88c62afcdfcac8c08be139038a42266038de5
serving/src/main/java/feast/serving/service/ServingService.javahttps://github.com/feast-dev/feast/pull/601/files#diff-1138d2178c63a310eea720381043dbfbd922f3ec641ddf13bed6f5da48a8d665
View file https://github.com/zhilingc/feast/blob/2bf0f0b87874c00534ff5585ab12b066dc15bf72/serving/src/main/java/feast/serving/service/ServingService.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/601/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/601/files#diff-1138d2178c63a310eea720381043dbfbd922f3ec641ddf13bed6f5da48a8d665
storage/api/src/main/java/feast/storage/api/retrieval/HistoricalRetriever.javahttps://github.com/feast-dev/feast/pull/601/files#diff-dfd1293ea71ffd918ffb01c08f0e1d35cbfb8ec4925b8b6b7bae96103d82c169
View file https://github.com/zhilingc/feast/blob/2bf0f0b87874c00534ff5585ab12b066dc15bf72/storage/api/src/main/java/feast/storage/api/retrieval/HistoricalRetriever.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/601/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/601/files#diff-dfd1293ea71ffd918ffb01c08f0e1d35cbfb8ec4925b8b6b7bae96103d82c169
https://github.com/feast-dev/feast/pull/601/files#diff-dfd1293ea71ffd918ffb01c08f0e1d35cbfb8ec4925b8b6b7bae96103d82c169
...rc/main/java/feast/storage/connectors/bigquery/retrieval/BigQueryHistoricalRetriever.javahttps://github.com/feast-dev/feast/pull/601/files#diff-71b4aa482bcfa9e394abf10bf735eaa0bca5529fb8f3235e7b4ed7b18b19d3f7
View file https://github.com/zhilingc/feast/blob/2bf0f0b87874c00534ff5585ab12b066dc15bf72/storage/connectors/bigquery/src/main/java/feast/storage/connectors/bigquery/retrieval/BigQueryHistoricalRetriever.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/601/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/601/files#diff-71b4aa482bcfa9e394abf10bf735eaa0bca5529fb8f3235e7b4ed7b18b19d3f7
https://github.com/feast-dev/feast/pull/601/files#diff-71b4aa482bcfa9e394abf10bf735eaa0bca5529fb8f3235e7b4ed7b18b19d3f7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.