René's URL Explorer Experiment


Title: Add better code docs to storage refactor by zhilingc · Pull Request #601 · feast-dev/feast · GitHub

Open Graph Title: Add better code docs to storage refactor by zhilingc · Pull Request #601 · feast-dev/feast

X Title: Add better code docs to storage refactor by zhilingc · Pull Request #601 · feast-dev/feast

Description: What this PR does / why we need it: Reopening this after rebasing on master. Addresses most of @woop 's comments on PR #567

Open Graph Description: What this PR does / why we need it: Reopening this after rebasing on master. Addresses most of @woop 's comments on PR #567

X Description: What this PR does / why we need it: Reopening this after rebasing on master. Addresses most of @woop 's comments on PR #567

Opengraph URL: https://github.com/feast-dev/feast/pull/601

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:95dcacd2-0aa2-0759-3885-53e8f8285953
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD7CC:136B13:23E1B62:2FFB87D:697C4F43
html-safe-noncee4c1205dbfd4a558d99643be0f8158229635b06a1877c02d4b8fb54b11fae0aa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0NDOjEzNkIxMzoyM0UxQjYyOjJGRkI4N0Q6Njk3QzRGNDMiLCJ2aXNpdG9yX2lkIjoiMzk5MzI4NTU0MzYwODQ3MTM2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc6b3dc411f26381bcb388707d081cfe7004b2211fe62d641e054d6d8af5c65ad
hovercard-subject-tagpull_request:398151175
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/601/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8b6049bd8d581481f1a3cabcfadec5eaa7f02caff2773945cbc581a7b6e75397/feast-dev/feast/pull/601
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8b6049bd8d581481f1a3cabcfadec5eaa7f02caff2773945cbc581a7b6e75397/feast-dev/feast/pull/601
og:image:altWhat this PR does / why we need it: Reopening this after rebasing on master. Addresses most of @woop 's comments on PR #567
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezhilingc
hostnamegithub.com
expected-hostnamegithub.com
Noneda4f0ee56809799586f8ee546b27f94fe9b5893edfbf87732e82be45be013b52
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release787d8d274e314f52ce6d846c7581f9476d8dc736
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/601#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F601
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F601
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/601
Reloadhttps://github.com/feast-dev/feast/pull/601
Reloadhttps://github.com/feast-dev/feast/pull/601
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 182 https://github.com/feast-dev/feast/issues
Pull requests 66 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast/pull/601#issue-comment-box
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:storage-refactorhttps://github.com/feast-dev/feast/tree/storage-refactor
zhilingc:storage-refactor-fix-2https://github.com/zhilingc/feast/tree/storage-refactor-fix-2
Add better code docs to storage refactor https://github.com/feast-dev/feast/pull/601#top
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:storage-refactorhttps://github.com/feast-dev/feast/tree/storage-refactor
zhilingc:storage-refactor-fix-2https://github.com/zhilingc/feast/tree/storage-refactor-fix-2
Conversation 6 https://github.com/feast-dev/feast/pull/601
Commits 3 https://github.com/feast-dev/feast/pull/601/commits
Checks 0 https://github.com/feast-dev/feast/pull/601/checks
Files changed https://github.com/feast-dev/feast/pull/601/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/601
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Apr 3, 2020https://github.com/feast-dev/feast/pull/601#issue-593355176
@woophttps://github.com/woop
#567https://github.com/feast-dev/feast/pull/567
Please reload this pagehttps://github.com/feast-dev/feast/pull/601
Add better code documentation, make GetFeastServingInfo independent o…https://github.com/feast-dev/feast/pull/601/commits/9201f7d93271685c784bc5886c09ff411fe461b5
9201f7dhttps://github.com/feast-dev/feast/pull/601/commits/9201f7d93271685c784bc5886c09ff411fe461b5
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
davidheryantohttps://github.com/davidheryanto
khorshuhenghttps://github.com/khorshuheng
pradithyahttps://github.com/pradithya
woophttps://github.com/woop
code ownershttps://github.com/feast-dev/feast/blob/1decc2a1d9cc9584eb16d73eee0d6b2e6593a42e/.github/CODEOWNERS#L4
April 3, 2020 12:42https://github.com/feast-dev/feast/pull/601#event-3196233492
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
size/XXL https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXXL
Apr 3, 2020https://github.com/feast-dev/feast/pull/601#event-3196233757
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
April 3, 2020 12:42https://github.com/feast-dev/feast/pull/601#event-3196234481
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
size/XXL https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXXL
Apr 3, 2020https://github.com/feast-dev/feast/pull/601#event-3196235226
https://github.com/woop
woophttps://github.com/woop
Apr 3, 2020https://github.com/feast-dev/feast/pull/601#issuecomment-608464334
Please reload this pagehttps://github.com/feast-dev/feast/pull/601
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Apr 3, 2020https://github.com/feast-dev/feast/pull/601#issuecomment-608549062
Please reload this pagehttps://github.com/feast-dev/feast/pull/601
https://github.com/woop
woophttps://github.com/woop
Apr 4, 2020 https://github.com/feast-dev/feast/pull/601#pullrequestreview-387655772
View reviewed changes https://github.com/feast-dev/feast/pull/601/files/9201f7d93271685c784bc5886c09ff411fe461b5
serving/src/main/java/feast/serving/configuration/ServingServiceConfig.javahttps://github.com/feast-dev/feast/pull/601/files/9201f7d93271685c784bc5886c09ff411fe461b5#diff-bcf8f96d70267ff79ce93460a4b6cafc162194efa4927dd380b95caccf6e978b
Please reload this pagehttps://github.com/feast-dev/feast/pull/601
Make getStagingLocation method of historical retrieverhttps://github.com/feast-dev/feast/pull/601/commits/e69007115f142df3e82b51d48176123d564b8bba
e690071https://github.com/feast-dev/feast/pull/601/commits/e69007115f142df3e82b51d48176123d564b8bba
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Apr 4, 2020https://github.com/feast-dev/feast/pull/601#issuecomment-608961758
zhilingchttps://github.com/gojek/feast/pull/601
herehttps://go.k8s.io/bot-commands?repo=gojek%2Ffeast
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/gojek/feast/blob/storage-refactor/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast/pull/601
Apply spotlesshttps://github.com/feast-dev/feast/pull/601/commits/2bf0f0b87874c00534ff5585ab12b066dc15bf72
2bf0f0bhttps://github.com/feast-dev/feast/pull/601/commits/2bf0f0b87874c00534ff5585ab12b066dc15bf72
https://github.com/woop
woophttps://github.com/woop
Apr 4, 2020https://github.com/feast-dev/feast/pull/601#issuecomment-608968358
Please reload this pagehttps://github.com/feast-dev/feast/pull/601
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
woophttps://github.com/woop
Apr 4, 2020https://github.com/feast-dev/feast/pull/601#event-3198769655
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
Apr 4, 2020https://github.com/feast-dev/feast/pull/601#event-3198769663
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
7d0c95fhttps://github.com/feast-dev/feast/commit/7d0c95fe69fdf91792d5cd70ca2229c9eb7783bf
Apr 4, 2020https://github.com/feast-dev/feast/pull/601#event-3198770005
zhilingchttps://github.com/zhilingc
Apr 7, 2020 https://github.com/feast-dev/feast/pull/601#ref-commit-986e337
Add better code docs to storage refactor (https://github.com/feast-dev/feast/commit/986e337ed44ba070f4fddb982e4eb65411170c7c
#601https://github.com/feast-dev/feast/pull/601
)https://github.com/feast-dev/feast/commit/986e337ed44ba070f4fddb982e4eb65411170c7c
986e337https://github.com/feast-dev/feast/commit/986e337ed44ba070f4fddb982e4eb65411170c7c
feast-ci-bothttps://github.com/feast-ci-bot
Apr 7, 2020 https://github.com/feast-dev/feast/pull/601#ref-commit-e4f8fe9
Add general storage API and refactor existing store implementations (https://github.com/feast-dev/feast/commit/e4f8fe905d3c182416e1b69bf60bfbc0e8348f8a
#…https://github.com/feast-dev/feast/pull/567
e4f8fe9https://github.com/feast-dev/feast/commit/e4f8fe905d3c182416e1b69bf60bfbc0e8348f8a
…567https://github.com/feast-dev/feast/pull/567
#529https://github.com/feast-dev/feast/pull/529
#546https://github.com/feast-dev/feast/pull/546
#547https://github.com/feast-dev/feast/pull/547
#553https://github.com/feast-dev/feast/pull/553
#569https://github.com/feast-dev/feast/pull/569
#586https://github.com/feast-dev/feast/pull/586
#601https://github.com/feast-dev/feast/pull/601
#607https://github.com/feast-dev/feast/pull/607
#605https://github.com/feast-dev/feast/pull/605
https://github.com/tsenhungwu
tsenhungwuhttps://github.com/tsenhungwu
Feb 15, 2023 https://github.com/feast-dev/feast/pull/601#ref-issue-1585993694
Failed on fetching historical feature values with get_historical_features python API #3495 https://github.com/feast-dev/feast/issues/3495
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F601
https://github.com/woop
woop https://github.com/woop
https://github.com/feast-dev/feast/pull/601/files/9201f7d93271685c784bc5886c09ff411fe461b5
https://github.com/davidheryanto
davidheryanto https://github.com/davidheryanto
https://github.com/khorshuheng
khorshuheng https://github.com/khorshuheng
https://github.com/pradithya
pradithya https://github.com/pradithya
https://github.com/woop
woop https://github.com/woop
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
Please reload this pagehttps://github.com/feast-dev/feast/pull/601
https://github.com/zhilingc
https://github.com/woop
https://github.com/feast-ci-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.