Title: fix: Disable materialized odfvs for historical retrieval by astronautas · Pull Request #5880 · feast-dev/feast · GitHub
Open Graph Title: fix: Disable materialized odfvs for historical retrieval by astronautas · Pull Request #5880 · feast-dev/feast
X Title: fix: Disable materialized odfvs for historical retrieval by astronautas · Pull Request #5880 · feast-dev/feast
Description: What this PR does / why we need it: See here. In essence, makes sure ODFV with write_to_online_store=True - meaning, cached - (on-demand feature views) get actually computed when querying offline store (get_historical_features) for training set generating, since as per docs (and generic expectation), offline stores do not store precomputed on demand feature view historical values (only online stores store their latest values). Which issue(s) this PR fixes: #5776
Open Graph Description: What this PR does / why we need it: See here. In essence, makes sure ODFV with write_to_online_store=True - meaning, cached - (on-demand feature views) get actually computed when querying offline...
X Description: What this PR does / why we need it: See here. In essence, makes sure ODFV with write_to_online_store=True - meaning, cached - (on-demand feature views) get actually computed when querying offline...
Opengraph URL: https://github.com/feast-dev/feast/pull/5880
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7236887f-f9a7-1c7a-02d6-7b124d586dde |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D2DC:2E0B3C:F490EB:1661840:6A4E342B |
| html-safe-nonce | d9202cc39575966dcac23f4a8d4d2fce5764eb79b1cc507bb3f73e45c6b32093 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkRDOjJFMEIzQzpGNDkwRUI6MTY2MTg0MDo2QTRFMzQyQiIsInZpc2l0b3JfaWQiOiIyNTkxNDU2ODE1NzYyNzgxMjI3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d4644018cf55f3f411a0c78217605a852a13f071ae8a7e891a3e3ccc8bc34cae |
| hovercard-subject-tag | pull_request:3186595466 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/5880/files |
| twitter:image | https://avatars.githubusercontent.com/u/13065760?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/13065760?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: See here. In essence, makes sure ODFV with write_to_online_store=True - meaning, cached - (on-demand feature views) get actually computed when querying offline... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 42a6d378d7587a44c93aca255096cd66b7c8eb2d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width