René's URL Explorer Experiment


Title: feat: Pass requested On-Demand Feature Views to Provider `get_historical_features` by Shizoqua · Pull Request #5803 · feast-dev/feast · GitHub

Open Graph Title: feat: Pass requested On-Demand Feature Views to Provider `get_historical_features` by Shizoqua · Pull Request #5803 · feast-dev/feast

X Title: feat: Pass requested On-Demand Feature Views to Provider `get_historical_features` by Shizoqua · Pull Request #5803 · feast-dev/feast

Description: Summary This PR fixes an interface/plumbing gap in historical retrieval by explicitly passing the requested On-Demand Feature Views (ODFVs) from FeatureStore.get_historical_features() into the provider’s get_historical_features() implementation. What changed Updated Provider.get_historical_features(...) signature to include: on_demand_feature_views: List[OnDemandFeatureView] Updated FeatureStore.get_historical_features() to pass the computed on_demand_feature_views list into the provider call. Updated PassthroughProvider.get_historical_features() to accept the new argument (ignored for passthrough delegation). Updated the test FooProvider implementation to match the new provider interface. Added a unit test that asserts the provider receives the expected ODFVs list: sdk/python/tests/unit/test_feature_store_passes_odfvs_to_provider.py Why Providers may need the explicit set of requested ODFVs to correctly handle or route historical retrieval logic. Previously, only the combined feature_views list was passed, which made it awkward/impossible for providers to distinguish which ODFVs were requested. Testing Added unit test test_feature_store_passes_on_demand_feature_views_to_provider.

Open Graph Description: Summary This PR fixes an interface/plumbing gap in historical retrieval by explicitly passing the requested On-Demand Feature Views (ODFVs) from FeatureStore.get_historical_features() into the prov...

X Description: Summary This PR fixes an interface/plumbing gap in historical retrieval by explicitly passing the requested On-Demand Feature Views (ODFVs) from FeatureStore.get_historical_features() into the prov...

Opengraph URL: https://github.com/feast-dev/feast/pull/5803

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a4112176-3bbb-d2eb-9dd8-481262b5bd90
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CF6:230337:568114:743D76:6AFEA86B
html-safe-nonce1925558cb4b3ab1a869fda912866262c6e27c52ada3671cbdf1e888f8313d0ee
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0Y2OjIzMDMzNzo1NjgxMTQ6NzQzRDc2OjZBRkVBODZCIiwidmlzaXRvcl9pZCI6Ijg2MTg4NzgzOTk4Nzc2NTQ2MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf5cb6e40f660c0885f55030aa4071accb4eeb7ebfb36aac1c3d8702ce8b936bd
hovercard-subject-tagpull_request:3138114189
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/5803/files
twitter:imagehttps://avatars.githubusercontent.com/u/136805224?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/136805224?s=400&v=4
og:image:altSummary This PR fixes an interface/plumbing gap in historical retrieval by explicitly passing the requested On-Demand Feature Views (ODFVs) from FeatureStore.get_historical_features() into the prov...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3f25273206cd841171bca0002261ae4c9757d934
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/5803/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F5803%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F5803%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/5803/files
Reloadhttps://github.com/feast-dev/feast/pull/5803/files
Reloadhttps://github.com/feast-dev/feast/pull/5803/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Shizoquahttps://github.com/Shizoqua
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Shizoqua:feat/pass-odfvs-to-providerhttps://github.com/Shizoqua/feast/tree/feat/pass-odfvs-to-provider
Conversation 16 https://github.com/feast-dev/feast/pull/5803
Commits 6 https://github.com/feast-dev/feast/pull/5803/commits
Checks 25 https://github.com/feast-dev/feast/pull/5803/checks
Files changed https://github.com/feast-dev/feast/pull/5803/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/5803/files
feat: Pass requested On-Demand Feature Views to Provider get_historical_features https://github.com/feast-dev/feast/pull/5803/files#top
Show all changes 6 commits https://github.com/feast-dev/feast/pull/5803/files
4f03d48 feat: pass ODFVs to provider for historical retrieval Shizoqua Dec 30, 2025 https://github.com/feast-dev/feast/pull/5803/commits/4f03d482df4aad333f181df9a9da3d0143eba41a
7dcf9bf feat: pass requested ODFVs into provider.get_historical_features Shizoqua Dec 31, 2025 https://github.com/feast-dev/feast/pull/5803/commits/7dcf9bf61be1821e8eaf384a680bd2c2736bec15
f352fd6 chore: fix ruff lint in ODFV provider tests Shizoqua Jan 1, 2026 https://github.com/feast-dev/feast/pull/5803/commits/f352fd6a2038ad2d1813081f2cd6782efe1031f0
05024d2 style: format ODFV provider test Shizoqua Jan 12, 2026 https://github.com/feast-dev/feast/pull/5803/commits/05024d2627bbd467d185e6e15aa5cebba5e202af
970cd02 docs: add TODO for long-term historical retrieval API cleanup Shizoqua Jan 22, 2026 https://github.com/feast-dev/feast/pull/5803/commits/970cd021bde18325d17fe78d487c2994c06b5a42
65fb480 Merge branch 'master' into feat/pass-odfvs-to-provider Shizoqua Mar 18, 2026 https://github.com/feast-dev/feast/pull/5803/commits/65fb480bb76506f59aed1c9205a5503f2c5a3480
Clear filters https://github.com/feast-dev/feast/pull/5803/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/5803/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/5803/files
feature_store.py https://github.com/feast-dev/feast/pull/5803/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
passthrough_provider.py https://github.com/feast-dev/feast/pull/5803/files#diff-d9f79a3598724f611628ace828bfb01721e6ffe34cc8f16e313ed9fdd48e8ab2
provider.py https://github.com/feast-dev/feast/pull/5803/files#diff-465c56d60ad11aa485727982ae4b7adf6e1eca816f610442078f871ddd9357a5
foo_provider.py https://github.com/feast-dev/feast/pull/5803/files#diff-3e70f7efad4646b336a001b3aff21b3fd292abb0c1037aa895eb7a2798b5150f
test_feature_store_passes_odfvs_to_provider.py https://github.com/feast-dev/feast/pull/5803/files#diff-056800f1f94783e3347ecbd66d49c705e5de1043d8bddfd39863e5541520581d
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/feature_store.pyhttps://github.com/feast-dev/feast/pull/5803/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
View file https://github.com/feast-dev/feast/blob/65fb480bb76506f59aed1c9205a5503f2c5a3480/sdk/python/feast/feature_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/5803/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/5803/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/5803/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/5803/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/5803/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/5803/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/passthrough_provider.pyhttps://github.com/feast-dev/feast/pull/5803/files#diff-d9f79a3598724f611628ace828bfb01721e6ffe34cc8f16e313ed9fdd48e8ab2
View file https://github.com/feast-dev/feast/blob/65fb480bb76506f59aed1c9205a5503f2c5a3480/sdk/python/feast/infra/passthrough_provider.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/5803/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/5803/files#diff-d9f79a3598724f611628ace828bfb01721e6ffe34cc8f16e313ed9fdd48e8ab2
Please reload this pagehttps://github.com/feast-dev/feast/pull/5803/files
https://github.com/feast-dev/feast/pull/5803/files#diff-d9f79a3598724f611628ace828bfb01721e6ffe34cc8f16e313ed9fdd48e8ab2
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/provider.pyhttps://github.com/feast-dev/feast/pull/5803/files#diff-465c56d60ad11aa485727982ae4b7adf6e1eca816f610442078f871ddd9357a5
View file https://github.com/feast-dev/feast/blob/65fb480bb76506f59aed1c9205a5503f2c5a3480/sdk/python/feast/infra/provider.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/5803/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/5803/files#diff-465c56d60ad11aa485727982ae4b7adf6e1eca816f610442078f871ddd9357a5
https://github.com/feast-dev/feast/pull/5803/files#diff-465c56d60ad11aa485727982ae4b7adf6e1eca816f610442078f871ddd9357a5
https://github.com/feast-dev/feast/pull/5803/files#diff-465c56d60ad11aa485727982ae4b7adf6e1eca816f610442078f871ddd9357a5
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/foo_provider.pyhttps://github.com/feast-dev/feast/pull/5803/files#diff-3e70f7efad4646b336a001b3aff21b3fd292abb0c1037aa895eb7a2798b5150f
View file https://github.com/feast-dev/feast/blob/65fb480bb76506f59aed1c9205a5503f2c5a3480/sdk/python/tests/foo_provider.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/5803/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/5803/files#diff-3e70f7efad4646b336a001b3aff21b3fd292abb0c1037aa895eb7a2798b5150f
https://github.com/feast-dev/feast/pull/5803/files#diff-3e70f7efad4646b336a001b3aff21b3fd292abb0c1037aa895eb7a2798b5150f
https://github.com/feast-dev/feast/pull/5803/files#diff-3e70f7efad4646b336a001b3aff21b3fd292abb0c1037aa895eb7a2798b5150f
https://github.com/feast-dev/feast/pull/5803/files#diff-3e70f7efad4646b336a001b3aff21b3fd292abb0c1037aa895eb7a2798b5150f
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_feature_store_passes_odfvs_to_provider.pyhttps://github.com/feast-dev/feast/pull/5803/files#diff-056800f1f94783e3347ecbd66d49c705e5de1043d8bddfd39863e5541520581d
View file https://github.com/feast-dev/feast/blob/65fb480bb76506f59aed1c9205a5503f2c5a3480/sdk/python/tests/unit/test_feature_store_passes_odfvs_to_provider.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/5803/{{ revealButtonHref }}
Please reload this pagehttps://github.com/feast-dev/feast/pull/5803/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.