René's URL Explorer Experiment


Title: fix: Thread safe Clickhouse offline store by astronautas · Pull Request #5710 · feast-dev/feast · GitHub

Open Graph Title: fix: Thread safe Clickhouse offline store by astronautas · Pull Request #5710 · feast-dev/feast

X Title: fix: Thread safe Clickhouse offline store by astronautas · Pull Request #5710 · feast-dev/feast

Description: What this PR does / why we need it: PR adjusts the Clickhouse offline store to be thread safe. Issue with the current implementation results in the issue as follows: raise ProgrammingError('Attemp...

Open Graph Description: What this PR does / why we need it: PR adjusts the Clickhouse offline store to be thread safe. Issue with the current implementation results in the issue as follows: raise ProgrammingError('At...

X Description: What this PR does / why we need it: PR adjusts the Clickhouse offline store to be thread safe. Issue with the current implementation results in the issue as follows: raise ProgrammingError(&#3...

Opengraph URL: https://github.com/feast-dev/feast/pull/5710

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:407f0cb1-3047-fd54-3278-239a5f10b4b4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED60:C9A7:27AE7B0:34B5BAB:696F0B8D
html-safe-nonce1540149351604ff68cbb4a517e53d2c8e913b1f71918c8c4d118839abb2a1aa6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDYwOkM5QTc6MjdBRTdCMDozNEI1QkFCOjY5NkYwQjhEIiwidmlzaXRvcl9pZCI6IjcwNDQ4ODExNDkxMDgwOTU4ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0d60c4b5a3d6c296f79f8400794237e14c408ff0fb9b3b7d50ecc29d8988187b
hovercard-subject-tagpull_request:2977054346
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/5710/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/02de32ea0dded253c08df98a8c6b7c6c9ff761cd50af958e8e643921bcc6e81a/feast-dev/feast/pull/5710
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/02de32ea0dded253c08df98a8c6b7c6c9ff761cd50af958e8e643921bcc6e81a/feast-dev/feast/pull/5710
og:image:altWhat this PR does / why we need it: PR adjusts the Clickhouse offline store to be thread safe. Issue with the current implementation results in the issue as follows: raise ProgrammingError('At...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameastronautas
hostnamegithub.com
expected-hostnamegithub.com
Noneb278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release39aed5006635ab6f45e6b77d23e73b08a00272a3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/5710#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F5710
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F5710
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/5710
Reloadhttps://github.com/feast-dev/feast/pull/5710
Reloadhttps://github.com/feast-dev/feast/pull/5710
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.6k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 176 https://github.com/feast-dev/feast/issues
Pull requests 58 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/feast-dev/feast/security
Please reload this pagehttps://github.com/feast-dev/feast/pull/5710
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast/pull/5710#issue-comment-box
franciscojavierarceohttps://github.com/franciscojavierarceo
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
astronautas:fix/thread-safe-clickhouse-offline-store-2https://github.com/astronautas/feast/tree/fix/thread-safe-clickhouse-offline-store-2
fix: Thread safe Clickhouse offline store https://github.com/feast-dev/feast/pull/5710#top
franciscojavierarceohttps://github.com/franciscojavierarceo
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
astronautas:fix/thread-safe-clickhouse-offline-store-2https://github.com/astronautas/feast/tree/fix/thread-safe-clickhouse-offline-store-2
Conversation 1 https://github.com/feast-dev/feast/pull/5710
Commits 5 https://github.com/feast-dev/feast/pull/5710/commits
Checks 22 https://github.com/feast-dev/feast/pull/5710/checks
Files changed https://github.com/feast-dev/feast/pull/5710/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/5710
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
https://github.com/astronautas
astronautashttps://github.com/astronautas
Nov 4, 2025https://github.com/feast-dev/feast/pull/5710#issue-3587071848
Please reload this pagehttps://github.com/feast-dev/feast/pull/5710
herehttps://clickhouse.com/docs/integrations/language-clients/python/advanced-usage#multithreaded-multiprocess-and-asyncevent-driven-use-cases
Please reload this pagehttps://github.com/feast-dev/feast/pull/5710
astronautashttps://github.com/astronautas
October 15, 2025 19:55https://github.com/feast-dev/feast/pull/5710#commits-pushed-1752a4f
https://github.com/astronautas
https://github.com/ntkathole
add pull_all_from_table_or_query for clickhouse, to align with new ma…https://github.com/feast-dev/feast/pull/5710/commits/1752a4fc72f72ac5e7c059f028940e656db5b50b
1752a4fhttps://github.com/feast-dev/feast/pull/5710/commits/1752a4fc72f72ac5e7c059f028940e656db5b50b
Merge branch 'feast-dev:master' into masterhttps://github.com/feast-dev/feast/pull/5710/commits/a6fcf5ed3b19a82515adeb9e5054e3ea673f7933
a6fcf5ehttps://github.com/feast-dev/feast/pull/5710/commits/a6fcf5ed3b19a82515adeb9e5054e3ea673f7933
Merge branch 'feast-dev:master' into masterhttps://github.com/feast-dev/feast/pull/5710/commits/c7cf0da3c73aa70c928a978b5476921bcdba269c
c7cf0dahttps://github.com/feast-dev/feast/pull/5710/commits/c7cf0da3c73aa70c928a978b5476921bcdba269c
https://github.com/astronautas
make sure get client is thread-local, since client is thread-unsafehttps://github.com/feast-dev/feast/pull/5710/commits/7c7686940639a24b7a50da19a35a518a8ae64aea
7c76869https://github.com/feast-dev/feast/pull/5710/commits/7c7686940639a24b7a50da19a35a518a8ae64aea
https://github.com/astronautas
astronautashttps://github.com/astronautas
code ownerhttps://github.com/feast-dev/feast/blob/ad3275654226f614fa4a40411440d16634f6971c/CODEOWNERS#L10
November 4, 2025 15:25https://github.com/feast-dev/feast/pull/5710#event-20705880485
https://github.com/astronautas
cleanuphttps://github.com/feast-dev/feast/pull/5710/commits/50ad3d12f0020bf36b4a0edd72007f3ddc7d15e7
50ad3d1https://github.com/feast-dev/feast/pull/5710/commits/50ad3d12f0020bf36b4a0edd72007f3ddc7d15e7
https://github.com/franciscojavierarceo
franciscojavierarceohttps://github.com/franciscojavierarceo
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
Nov 4, 2025https://github.com/feast-dev/feast/pull/5710#event-20707169924
https://github.com/franciscojavierarceo
franciscojavierarceohttps://github.com/franciscojavierarceo
Nov 4, 2025 https://github.com/feast-dev/feast/pull/5710#pullrequestreview-3417650916
View reviewed changes https://github.com/feast-dev/feast/pull/5710/files/50ad3d12f0020bf36b4a0edd72007f3ddc7d15e7
franciscojavierarceohttps://github.com/franciscojavierarceo
https://github.com/feast-dev/feast/pull/5710#pullrequestreview-3417650916
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/5710
https://github.com/franciscojavierarceo
franciscojavierarceohttps://github.com/franciscojavierarceo
5f446edhttps://github.com/feast-dev/feast/commit/5f446ede403e778264e6a44266ba72e1174e1db9
Nov 4, 2025https://github.com/feast-dev/feast/pull/5710#event-20708512622
Please reload this pagehttps://github.com/feast-dev/feast/pull/5710
HaoXuAIhttps://github.com/HaoXuAI
Nov 12, 2025 https://github.com/feast-dev/feast/pull/5710#ref-commit-5a5ccde
https://github.com/astronautas
fix: Thread safe Clickhouse offline store (https://github.com/feast-dev/feast/commit/5a5ccde0078ea823e6b02649c6da4bca08580463
#5710https://github.com/feast-dev/feast/pull/5710
)https://github.com/feast-dev/feast/commit/5a5ccde0078ea823e6b02649c6da4bca08580463
5a5ccdehttps://github.com/feast-dev/feast/commit/5a5ccde0078ea823e6b02649c6da4bca08580463
franciscojavierarceohttps://github.com/franciscojavierarceo
Nov 13, 2025 https://github.com/feast-dev/feast/pull/5710#ref-commit-cc39768
https://github.com/feast-ci-bot
chore(release): release 0.57.0https://github.com/feast-dev/feast/commit/cc3976883f677a48e9312fff89a0966ae6ff8211
cc39768https://github.com/feast-dev/feast/commit/cc3976883f677a48e9312fff89a0966ae6ff8211
v0.56.0...v0.57.0https://github.com/feast-dev/feast/compare/v0.56.0...v0.57.0
#5691https://github.com/feast-dev/feast/pull/5691
#5691https://github.com/feast-dev/feast/pull/5691
f855ad2https://github.com/feast-dev/feast/commit/f855ad245f1800cb5e591ad0370903f361641037
f855ad2https://github.com/feast-dev/feast/commit/f855ad245f1800cb5e591ad0370903f361641037
#5716https://github.com/feast-dev/feast/pull/5716
#5716https://github.com/feast-dev/feast/pull/5716
1b050b3https://github.com/feast-dev/feast/commit/1b050b32fefd1190044087dec504acdcb43a51d5
1b050b3https://github.com/feast-dev/feast/commit/1b050b32fefd1190044087dec504acdcb43a51d5
#5703https://github.com/feast-dev/feast/pull/5703
#5703https://github.com/feast-dev/feast/pull/5703
ad32756https://github.com/feast-dev/feast/commit/ad3275654226f614fa4a40411440d16634f6971c
ad32756https://github.com/feast-dev/feast/commit/ad3275654226f614fa4a40411440d16634f6971c
#5710https://github.com/feast-dev/feast/pull/5710
#5710https://github.com/feast-dev/feast/pull/5710
5f446edhttps://github.com/feast-dev/feast/commit/5f446ede403e778264e6a44266ba72e1174e1db9
5f446edhttps://github.com/feast-dev/feast/commit/5f446ede403e778264e6a44266ba72e1174e1db9
#5701https://github.com/feast-dev/feast/pull/5701
#5701https://github.com/feast-dev/feast/pull/5701
be6e6c2https://github.com/feast-dev/feast/commit/be6e6c2752df669d030ed2c8b66dd2229448490e
be6e6c2https://github.com/feast-dev/feast/commit/be6e6c2752df669d030ed2c8b66dd2229448490e
#5699https://github.com/feast-dev/feast/pull/5699
#5699https://github.com/feast-dev/feast/pull/5699
3cfe4ebhttps://github.com/feast-dev/feast/commit/3cfe4ebfa9de589fa03c020cadcb4d9de504affa
3cfe4ebhttps://github.com/feast-dev/feast/commit/3cfe4ebfa9de589fa03c020cadcb4d9de504affa
#5713https://github.com/feast-dev/feast/pull/5713
#5713https://github.com/feast-dev/feast/pull/5713
8d77b72https://github.com/feast-dev/feast/commit/8d77b7287b9dea11acad56fed1dada453150785c
8d77b72https://github.com/feast-dev/feast/commit/8d77b7287b9dea11acad56fed1dada453150785c
#5650https://github.com/feast-dev/feast/pull/5650
#5650https://github.com/feast-dev/feast/pull/5650
2915ad1https://github.com/feast-dev/feast/commit/2915ad18735ee4f749c2e63a6bbf0dd2a922bc96
2915ad1https://github.com/feast-dev/feast/commit/2915ad18735ee4f749c2e63a6bbf0dd2a922bc96
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F5710
https://github.com/franciscojavierarceo
franciscojavierarceo https://github.com/franciscojavierarceo
https://github.com/feast-dev/feast/pull/5710/files/50ad3d12f0020bf36b4a0edd72007f3ddc7d15e7
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
Please reload this pagehttps://github.com/feast-dev/feast/pull/5710
https://github.com/astronautas
https://github.com/franciscojavierarceo
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.