Title: fix: Support historical feature retrieval with start_date/end_date in RemoteOfflineStore by aniketpalu · Pull Request #5703 · feast-dev/feast · GitHub
Open Graph Title: fix: Support historical feature retrieval with start_date/end_date in RemoteOfflineStore by aniketpalu · Pull Request #5703 · feast-dev/feast
X Title: fix: Support historical feature retrieval with start_date/end_date in RemoteOfflineStore by aniketpalu · Pull Request #5703 · feast-dev/feast
Description: What this PR does / why we need it: Problem get_historical_features() with start_date/end_date parameters (no entity_df) works in local mode but fails in remote mode with: EntityTimestampInferenceException: Please provide an entity_df with a column named event_timestamp Root Cause Remote client sends mock table {"key": "mock_key"} when entity_df is None Server treats mock table as valid entity_df, which lacks event_timestamp column Server doesn't forward start_date/end_date to underlying offline store Changes Client (remote.py): Handle None entity_df in _create_retrieval_metadata() and _get_entity_schema() Server (offline_server.py): Detect and discard mock tables (single 'key' column) Create minimal entity_df with event_timestamp from start_date/end_date Forward start_date/end_date kwargs to underlying offline store Use pd.to_datetime() and utils.make_tzaware() for proper timestamp types Which issue(s) this PR fixes: Misc
Open Graph Description: What this PR does / why we need it: Problem get_historical_features() with start_date/end_date parameters (no entity_df) works in local mode but fails in remote mode with: EntityTimestampInferen...
X Description: What this PR does / why we need it: Problem get_historical_features() with start_date/end_date parameters (no entity_df) works in local mode but fails in remote mode with: EntityTimestampInferen...
Opengraph URL: https://github.com/feast-dev/feast/pull/5703
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1c91a6f3-7a2f-969b-892b-a97f2d426d2b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9150:18D1D3:95A9A19:C63B0C6:696E042A |
| html-safe-nonce | c39c8d3f3e557ebe86a2d7796d5cd643e9349a8d5762293f0d2b9e888a11929e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTUwOjE4RDFEMzo5NUE5QTE5OkM2M0IwQzY6Njk2RTA0MkEiLCJ2aXNpdG9yX2lkIjoiMTYxMzgzOTU0MjQwMzMzNTIxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 77dd83ed19faaf33a6baa7a7c48402dd3088941d2a8a18c1fb72a98d26f501c9 |
| hovercard-subject-tag | pull_request:2957682813 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/5703/files |
| twitter:image | https://avatars.githubusercontent.com/u/64416568?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/64416568?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: Problem get_historical_features() with start_date/end_date parameters (no entity_df) works in local mode but fails in remote mode with: EntityTimestampInferen... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b5131b207ddd175abf059a848d5f4302ec0606b02211b989013be49cf08593e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8590a63bfc8093b241930ca57d536c9a50f9680 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width