Title: fix: Date wise remote offline store historical data retrieval by aniketpalu · Pull Request #5686 · feast-dev/feast · GitHub
Open Graph Title: fix: Date wise remote offline store historical data retrieval by aniketpalu · Pull Request #5686 · feast-dev/feast
X Title: fix: Date wise remote offline store historical data retrieval by aniketpalu · Pull Request #5686 · feast-dev/feast
Description: What this PR does / why we need it: When using a remote offline store with PostgreSQL backend, calling get_historical_features() with start_date and end_date parameters fails with: TypeError: Got an unexpected keyword argument 'start_date' / 'end_date' for RemoteOfflineStore The implementation follows the same pattern used by local PostgreSQL based offline stores ensuring consistency across the codebase: Client-side changes (remote.py): Add **kwargs parameter to RemoteOfflineStore.get_historical_features() method signature Extract start_date and end_date from kwargs and serialize them to ISO format strings Include serialized dates in api_parameters for transmission over Arrow Flight Server-side changes (offline_server.py): Extract start_date and end_date from the command dict (if present) Deserialize ISO format strings back to timezone-aware datetime objects Pass extracted dates as **kwargs to the underlying offline store Which issue(s) this PR fixes: Misc
Open Graph Description: What this PR does / why we need it: When using a remote offline store with PostgreSQL backend, calling get_historical_features() with start_date and end_date parameters fails with: TypeError: Got...
X Description: What this PR does / why we need it: When using a remote offline store with PostgreSQL backend, calling get_historical_features() with start_date and end_date parameters fails with: TypeError: Got...
Opengraph URL: https://github.com/feast-dev/feast/pull/5686
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:18e4a64b-7d13-26da-83ac-5ac62837ba58 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C4F0:2445E2:4E214AE:68BAF56:696E046B |
| html-safe-nonce | 25d3c7c1ffc5cf266138b8deb4a3110a90663a668f6b4d39e0131fcfaa35bec9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNEYwOjI0NDVFMjo0RTIxNEFFOjY4QkFGNTY6Njk2RTA0NkIiLCJ2aXNpdG9yX2lkIjoiNDIxMzk3MjQ3ODA4MzMzNTI3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3518818d0cf1bae7400ddff6f74d69c0cfadfefe427d15389e2413c4956fd8ca |
| hovercard-subject-tag | pull_request:2933170087 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/5686/files |
| twitter:image | https://avatars.githubusercontent.com/u/64416568?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/64416568?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: When using a remote offline store with PostgreSQL backend, calling get_historical_features() with start_date and end_date parameters fails with: TypeError: Got... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b5131b207ddd175abf059a848d5f4302ec0606b02211b989013be49cf08593e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8590a63bfc8093b241930ca57d536c9a50f9680 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width