Title: fix: Correct column list polars materialization engine by danbaron63 · Pull Request #5595 · feast-dev/feast · GitHub
Open Graph Title: fix: Correct column list polars materialization engine by danbaron63 · Pull Request #5595 · feast-dev/feast
X Title: fix: Correct column list polars materialization engine by danbaron63 · Pull Request #5595 · feast-dev/feast
Description: What this PR does / why we need it: Currently materialization fails when using the PolarsBackend as the columns method has no implementation. Worse still, rather than raising a NotImplementedError it fails silently by returning nothing which gets interpreted as None. This provides a valid implementation that allows the feast materialize ... command to run successfully. Which issue(s) this PR fixes: N/a Misc N/a
Open Graph Description: What this PR does / why we need it: Currently materialization fails when using the PolarsBackend as the columns method has no implementation. Worse still, rather than raising a NotImplementedError ...
X Description: What this PR does / why we need it: Currently materialization fails when using the PolarsBackend as the columns method has no implementation. Worse still, rather than raising a NotImplementedError ...
Opengraph URL: https://github.com/feast-dev/feast/pull/5595
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bd54d3ab-6103-0bc2-84d1-1bcdaaae1496 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E416:335652:2C9D940:3D1022F:696E0435 |
| html-safe-nonce | 6efaf01d07eda79f8175c9946ed4adda0c723dc525b0d681625331af924bfea3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDE2OjMzNTY1MjoyQzlEOTQwOjNEMTAyMkY6Njk2RTA0MzUiLCJ2aXNpdG9yX2lkIjoiOTIxNzU4NTc5ODU1Mjg4MDE4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 761094fade113e2bc86930ae5b7873d786db8e204358c90d9deae2b015c2749b |
| hovercard-subject-tag | pull_request:2796495024 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/5595/files |
| twitter:image | https://avatars.githubusercontent.com/u/84331438?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/84331438?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: Currently materialization fails when using the PolarsBackend as the columns method has no implementation. Worse still, rather than raising a NotImplementedError ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b5131b207ddd175abf059a848d5f4302ec0606b02211b989013be49cf08593e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8590a63bfc8093b241930ca57d536c9a50f9680 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width