René's URL Explorer Experiment


Title: fix: Fixed filtering based on data_source for ODFVs by ntkathole · Pull Request #5593 · feast-dev/feast · GitHub

Open Graph Title: fix: Fixed filtering based on data_source for ODFVs by ntkathole · Pull Request #5593 · feast-dev/feast

X Title: fix: Fixed filtering based on data_source for ODFVs by ntkathole · Pull Request #5593 · feast-dev/feast

Description: What this PR does / why we need it: This PR fixed the filtering issue for On-demand feature view when filtering by request source data source. There was an issue in the filtering of the data in the...

Open Graph Description: What this PR does / why we need it: This PR fixed the filtering issue for On-demand feature view when filtering by request source data source. There was an issue in the filtering of the data in the...

X Description: What this PR does / why we need it: This PR fixed the filtering issue for On-demand feature view when filtering by request source data source. There was an issue in the filtering of the data in the...

Opengraph URL: https://github.com/feast-dev/feast/pull/5593

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fc4e45dc-c4ae-e732-ede4-0361388a9176
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB160:1DB988:FB1B:14225:696E872F
html-safe-nonced8046f426346a00caee094156629edb81edb99e7911c797b384ad153d919f166
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTYwOjFEQjk4ODpGQjFCOjE0MjI1OjY5NkU4NzJGIiwidmlzaXRvcl9pZCI6IjEzMTE4NjgyMjU4NDE5NTY2NTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac53495f296186d88ec0b9ea3ca2fe0c0d141d9cb929b8a291bb5e1ca1e4e41e06
hovercard-subject-tagpull_request:2792530809
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/5593/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bfbec96bc4a926ae398eaaeec438ec985e9a5faef7ecfea85930a2c45f5b3594/feast-dev/feast/pull/5593
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bfbec96bc4a926ae398eaaeec438ec985e9a5faef7ecfea85930a2c45f5b3594/feast-dev/feast/pull/5593
og:image:altWhat this PR does / why we need it: This PR fixed the filtering issue for On-demand feature view when filtering by request source data source. There was an issue in the filtering of the data in the...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamentkathole
hostnamegithub.com
expected-hostnamegithub.com
Nonefdad15fd2ad43212aa8b8be5f2c2725550f8374ceeeb154a999ad9145b43f3f7
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release27b23bc056eb973d350fc95afc848757edb9e7a9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/5593#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F5593
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F5593
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/5593
Reloadhttps://github.com/feast-dev/feast/pull/5593
Reloadhttps://github.com/feast-dev/feast/pull/5593
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.6k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 176 https://github.com/feast-dev/feast/issues
Pull requests 58 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/feast-dev/feast/security
Please reload this pagehttps://github.com/feast-dev/feast/pull/5593
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast/pull/5593#issue-comment-box
franciscojavierarceohttps://github.com/franciscojavierarceo
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
ntkathole:fix_ondemandfv_filteringhttps://github.com/ntkathole/feast/tree/fix_ondemandfv_filtering
fix: Fixed filtering based on data_source for ODFVs https://github.com/feast-dev/feast/pull/5593#top
franciscojavierarceohttps://github.com/franciscojavierarceo
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
ntkathole:fix_ondemandfv_filteringhttps://github.com/ntkathole/feast/tree/fix_ondemandfv_filtering
Conversation 0 https://github.com/feast-dev/feast/pull/5593
Commits 1 https://github.com/feast-dev/feast/pull/5593/commits
Checks 19 https://github.com/feast-dev/feast/pull/5593/checks
Files changed 2 https://github.com/feast-dev/feast/pull/5593/files
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
Sep 2, 2025https://github.com/feast-dev/feast/pull/5593#issue-3375870161
Please reload this pagehttps://github.com/feast-dev/feast/pull/5593
https://github.com/ntkathole
fix: Fixed filtering based on data_source for ODFVshttps://github.com/feast-dev/feast/pull/5593/commits/e01a3461277b8c9795f855335514e283ca0a8e3f
e01a346https://github.com/feast-dev/feast/pull/5593/commits/e01a3461277b8c9795f855335514e283ca0a8e3f
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
Sep 2, 2025https://github.com/feast-dev/feast/pull/5593#event-19459522007
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
code ownerhttps://github.com/feast-dev/feast/blob/00527540499adb03e53ea0ba30866e71664dbca6/CODEOWNERS#L10
September 2, 2025 12:41https://github.com/feast-dev/feast/pull/5593#event-19459522175
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
Sep 2, 2025https://github.com/feast-dev/feast/pull/5593#event-19459522314
https://github.com/franciscojavierarceo
franciscojavierarceohttps://github.com/franciscojavierarceo
Sep 2, 2025 https://github.com/feast-dev/feast/pull/5593#pullrequestreview-3176571559
View reviewed changes https://github.com/feast-dev/feast/pull/5593/files/e01a3461277b8c9795f855335514e283ca0a8e3f
https://github.com/franciscojavierarceo
franciscojavierarceohttps://github.com/franciscojavierarceo
c3e6c56https://github.com/feast-dev/feast/commit/c3e6c56239377384dcd9e062b1cf910e2b0e173e
Sep 2, 2025https://github.com/feast-dev/feast/pull/5593#event-19460531597
Please reload this pagehttps://github.com/feast-dev/feast/pull/5593
franciscojavierarceohttps://github.com/franciscojavierarceo
Sep 30, 2025 https://github.com/feast-dev/feast/pull/5593#ref-commit-99a321a
https://github.com/feast-ci-bot
chore(release): release 0.54.0https://github.com/feast-dev/feast/commit/99a321a8cb6647ac06ce54bd7c4f4a7bf72ff260
99a321ahttps://github.com/feast-dev/feast/commit/99a321a8cb6647ac06ce54bd7c4f4a7bf72ff260
v0.53.0...v0.54.0https://github.com/feast-dev/feast/compare/v0.53.0...v0.54.0
#5621https://github.com/feast-dev/feast/pull/5621
#5621https://github.com/feast-dev/feast/pull/5621
e8eae71https://github.com/feast-dev/feast/commit/e8eae71a3141748df7e7460bcf95cf0943a69e75
e8eae71https://github.com/feast-dev/feast/commit/e8eae71a3141748df7e7460bcf95cf0943a69e75
#5595https://github.com/feast-dev/feast/pull/5595
#5595https://github.com/feast-dev/feast/pull/5595
39aeb0chttps://github.com/feast-dev/feast/commit/39aeb0c443f43844978678f258567bea851f0e15
39aeb0chttps://github.com/feast-dev/feast/commit/39aeb0c443f43844978678f258567bea851f0e15
#5622https://github.com/feast-dev/feast/pull/5622
#5622https://github.com/feast-dev/feast/pull/5622
5ab18a6https://github.com/feast-dev/feast/commit/5ab18a6a2ad77723a823e9a0f28b7b2f3d3f06ce
5ab18a6https://github.com/feast-dev/feast/commit/5ab18a6a2ad77723a823e9a0f28b7b2f3d3f06ce
#5610https://github.com/feast-dev/feast/pull/5610
#5610https://github.com/feast-dev/feast/pull/5610
8f0e22dhttps://github.com/feast-dev/feast/commit/8f0e22d839860d331f835e35f56272b965fd34eb
8f0e22dhttps://github.com/feast-dev/feast/commit/8f0e22d839860d331f835e35f56272b965fd34eb
#5593https://github.com/feast-dev/feast/pull/5593
#5593https://github.com/feast-dev/feast/pull/5593
c3e6c56https://github.com/feast-dev/feast/commit/c3e6c56239377384dcd9e062b1cf910e2b0e173e
c3e6c56https://github.com/feast-dev/feast/commit/c3e6c56239377384dcd9e062b1cf910e2b0e173e
#5602https://github.com/feast-dev/feast/pull/5602
#5602https://github.com/feast-dev/feast/pull/5602
02c3006https://github.com/feast-dev/feast/commit/02c300662387ef2c4c2c24543217c9c9b10000fa
02c3006https://github.com/feast-dev/feast/commit/02c300662387ef2c4c2c24543217c9c9b10000fa
#5604https://github.com/feast-dev/feast/pull/5604
#5604https://github.com/feast-dev/feast/pull/5604
3c7a022https://github.com/feast-dev/feast/commit/3c7a022ec72defe9673b4ef9b72ba785fc090684
3c7a022https://github.com/feast-dev/feast/commit/3c7a022ec72defe9673b4ef9b72ba785fc090684
#5617https://github.com/feast-dev/feast/pull/5617
#5617https://github.com/feast-dev/feast/pull/5617
51c16b1https://github.com/feast-dev/feast/commit/51c16b1f448c26ded0a41e0404fd0311f2cdb6d7
51c16b1https://github.com/feast-dev/feast/commit/51c16b1f448c26ded0a41e0404fd0311f2cdb6d7
#5588https://github.com/feast-dev/feast/pull/5588
#5588https://github.com/feast-dev/feast/pull/5588
0052754https://github.com/feast-dev/feast/commit/00527540499adb03e53ea0ba30866e71664dbca6
0052754https://github.com/feast-dev/feast/commit/00527540499adb03e53ea0ba30866e71664dbca6
#5632https://github.com/feast-dev/feast/pull/5632
#5632https://github.com/feast-dev/feast/pull/5632
a24e06ehttps://github.com/feast-dev/feast/commit/a24e06e0b6e84fa8c3aafb338ff75e2156a02138
a24e06ehttps://github.com/feast-dev/feast/commit/a24e06e0b6e84fa8c3aafb338ff75e2156a02138
#5580https://github.com/feast-dev/feast/pull/5580
#5580https://github.com/feast-dev/feast/pull/5580
d56baf4https://github.com/feast-dev/feast/commit/d56baf4aca917a2965a4d77e06462138a7b52de0
d56baf4https://github.com/feast-dev/feast/commit/d56baf4aca917a2965a4d77e06462138a7b52de0
#5626https://github.com/feast-dev/feast/pull/5626
#5626https://github.com/feast-dev/feast/pull/5626
76590bfhttps://github.com/feast-dev/feast/commit/76590bf4424f20f8fdb9ef7882fc24b2af0f88cc
76590bfhttps://github.com/feast-dev/feast/commit/76590bf4424f20f8fdb9ef7882fc24b2af0f88cc
#5629https://github.com/feast-dev/feast/pull/5629
#5629https://github.com/feast-dev/feast/pull/5629
8715ae8https://github.com/feast-dev/feast/commit/8715ae85a94c62b5a58e233cb850b12b0c403208
8715ae8https://github.com/feast-dev/feast/commit/8715ae85a94c62b5a58e233cb850b12b0c403208
#5640https://github.com/feast-dev/feast/pull/5640
#5640https://github.com/feast-dev/feast/pull/5640
51a0ee6https://github.com/feast-dev/feast/commit/51a0ee61719ef893a2d2165a0a38edc1734034a2
51a0ee6https://github.com/feast-dev/feast/commit/51a0ee61719ef893a2d2165a0a38edc1734034a2
7128024https://github.com/feast-dev/feast/commit/7128024db08c0f8b880de5bdd614545339ced1b1
7128024https://github.com/feast-dev/feast/commit/7128024db08c0f8b880de5bdd614545339ced1b1
#5577https://github.com/feast-dev/feast/pull/5577
#5577https://github.com/feast-dev/feast/pull/5577
56c5910https://github.com/feast-dev/feast/commit/56c59108a5d9ffdc35eaf31960556be894c2a38d
56c5910https://github.com/feast-dev/feast/commit/56c59108a5d9ffdc35eaf31960556be894c2a38d
#5625https://github.com/feast-dev/feast/pull/5625
#5625https://github.com/feast-dev/feast/pull/5625
eb51f00https://github.com/feast-dev/feast/commit/eb51f005dddba8aedd528032d62d966166c028eb
eb51f00https://github.com/feast-dev/feast/commit/eb51f005dddba8aedd528032d62d966166c028eb
#5611https://github.com/feast-dev/feast/pull/5611
#5611https://github.com/feast-dev/feast/pull/5611
2ce4198https://github.com/feast-dev/feast/commit/2ce4198cfb41f0395a3d56ae20e2bef193617f88
2ce4198https://github.com/feast-dev/feast/commit/2ce4198cfb41f0395a3d56ae20e2bef193617f88
#5612https://github.com/feast-dev/feast/pull/5612
#5612https://github.com/feast-dev/feast/pull/5612
1d08786https://github.com/feast-dev/feast/commit/1d0878663cd93f0123a1a150cf306e1923d1aca5
1d08786https://github.com/feast-dev/feast/commit/1d0878663cd93f0123a1a150cf306e1923d1aca5
#5599https://github.com/feast-dev/feast/pull/5599
#5599https://github.com/feast-dev/feast/pull/5599
728589ahttps://github.com/feast-dev/feast/commit/728589a80735b4b5641fbbccbe6092bb4b5ed1fa
728589ahttps://github.com/feast-dev/feast/commit/728589a80735b4b5641fbbccbe6092bb4b5ed1fa
#5635https://github.com/feast-dev/feast/pull/5635
#5635https://github.com/feast-dev/feast/pull/5635
5e4b9fdhttps://github.com/feast-dev/feast/commit/5e4b9fd5ca490bcd52710fa8691ad5fa6f5680dc
5e4b9fdhttps://github.com/feast-dev/feast/commit/5e4b9fd5ca490bcd52710fa8691ad5fa6f5680dc
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F5593
https://github.com/franciscojavierarceo
franciscojavierarceo https://github.com/franciscojavierarceo
https://github.com/feast-dev/feast/pull/5593/files/e01a3461277b8c9795f855335514e283ca0a8e3f
https://github.com/ntkathole
ntkathole https://github.com/ntkathole
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
Please reload this pagehttps://github.com/feast-dev/feast/pull/5593
https://github.com/ntkathole
https://github.com/franciscojavierarceo
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.