| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f33c3c4e-4789-de69-b7b1-c287a8b603aa |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E4E8:2B554C:11602D6:188596A:697B8B82 |
| html-safe-nonce | b3133c183b73b6303057f26bdc356827f195ff42c7f65ae6f41e517dfa9979f7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEU4OjJCNTU0QzoxMTYwMkQ2OjE4ODU5NkE6Njk3QjhCODIiLCJ2aXNpdG9yX2lkIjoiNzc4MzYxMzgxMzM3MTQwMDk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | fca96a6164e2e5bcd827b6c2e0cf40e87abf82f01efb1f4abe0190d5e3a332f0 |
| hovercard-subject-tag | pull_request:391377852 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/554/files |
| twitter:image | https://avatars.githubusercontent.com/u/6728866?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/6728866?s=400&v=4 |
| og:image:alt | What this PR does / why we need it:
First implementation of auth for Feast (related to #504 minimal implementation).
Adds authentication to Feast Core (with support for different implementations).... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 86b3730167656228ed8d24c4f0770806131d1f695bff36b9485630bb7443aa64 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6adfecb5bc9d8f1aac645d1f3797aca9d302dd85 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/554/changes#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F554%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F554%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/554/changes |
| Reload | https://github.com/feast-dev/feast/pull/554/changes |
| Reload | https://github.com/feast-dev/feast/pull/554/changes |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
182
| https://github.com/feast-dev/feast/issues |
|
Pull requests
66
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| woop | https://github.com/woop |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| woop:auth | https://github.com/woop/feast/tree/auth |
|
Conversation
18
| https://github.com/feast-dev/feast/pull/554 |
|
Commits
10
| https://github.com/feast-dev/feast/pull/554/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/554/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/554/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/554/changes |
|
Add support for authentication and authorization
| https://github.com/feast-dev/feast/pull/554/changes#top |
|
Show all changes
10 commits
| https://github.com/feast-dev/feast/pull/554/files |
|
05c4af9
Add project service tests
Mar 20, 2020
| https://github.com/feast-dev/feast/pull/554/commits/05c4af9cc8179ea92586dd342bdd0f966fdb5fc7 |
|
5991fd3
Add authentication and authorization
woop Mar 20, 2020
| https://github.com/feast-dev/feast/pull/554/commits/5991fd3cefcec64641a1ea2f5363a245e36814c2 |
|
04b5979
Add comments and remove unnecessary config
woop Mar 20, 2020
| https://github.com/feast-dev/feast/pull/554/commits/04b59799b7afa162b8c33ce8c6b482b96c58c1a8 |
|
c61cab1
Fix broken auth tests and allow for static token to be set
woop Mar 21, 2020
| https://github.com/feast-dev/feast/pull/554/commits/c61cab160dd339b800dc3f9975e5811d48a97199 |
|
9c7ff64
Implement static token configuration and fix broken tests
woop Mar 23, 2020
| https://github.com/feast-dev/feast/pull/554/commits/9c7ff64b04c9b26255fca598a0dc80242a0c9973 |
|
dc727bc
Fix e2e tests
woop Mar 23, 2020
| https://github.com/feast-dev/feast/pull/554/commits/dc727bcfdc4af2363dfaf9cbb0b5a9abac640dcc |
|
4d40e9a
Fix e2e test indent
woop Mar 23, 2020
| https://github.com/feast-dev/feast/pull/554/commits/4d40e9aa183831e62a43af3ca46e258e5ba49c25 |
|
8900350
Fix e2e test indent
woop Mar 23, 2020
| https://github.com/feast-dev/feast/pull/554/commits/89003500a112cac3cd3b48a307ca9420aa42f613 |
|
6254f79
Fix e2e test indent
woop Mar 23, 2020
| https://github.com/feast-dev/feast/pull/554/commits/6254f79a8df6017944351b92c97cb04f41eff047 |
|
4997694
Update configuration comments and add disable option to enable auth f…
woop Mar 29, 2020
| https://github.com/feast-dev/feast/pull/554/commits/49976945a1d208b2b0bc084034ccd1ba0231282e |
|
Clear filters
| https://github.com/feast-dev/feast/pull/554/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/554/changes |
| Please reload this page | https://github.com/feast-dev/feast/pull/554/changes |
|
.gitignore
| https://github.com/feast-dev/feast/pull/554/changes#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947 |
|
pom.xml
| https://github.com/feast-dev/feast/pull/554/changes#diff-8d04401f1cc51365fe3e32f019cd720135ba920a1a7da7f19e9c9208478701fc |
|
GoogleOpenIDAuthenticationProvider.java
| https://github.com/feast-dev/feast/pull/554/changes#diff-241661c905a1726cd0bd3f8ae2e4bfb525e731adc564b5e602849e0c45cc3c8c |
|
AuthorizationProvider.java
| https://github.com/feast-dev/feast/pull/554/changes#diff-173d6d873f09eb8711772d39a98b75d720a120f2706feae8f4c99bcd604f077b |
|
KetoAuthorizationProvider.java
| https://github.com/feast-dev/feast/pull/554/changes#diff-32d30738a8ce5acc7372ae608e00497fbd5e998ac3517e6f6d8883a3ddc87bc9 |
|
CoreGRpcServerBuilderConfig.java
| https://github.com/feast-dev/feast/pull/554/changes#diff-91e179a4803ea3a7f1a5ef5fbe97ce1a0942746c55cfabad199dff71b78a33fa |
|
FeastProperties.java
| https://github.com/feast-dev/feast/pull/554/changes#diff-674a079771ed44b6277492ff09f03b398a7741e3407b282d8babcddc4e3871d7 |
|
SecurityConfig.java
| https://github.com/feast-dev/feast/pull/554/changes#diff-5442937cbbb3f1966a3049b7c05bfd8e050f272a5e826792d7d07c5f49e1025a |
|
CoreServiceImpl.java
| https://github.com/feast-dev/feast/pull/554/changes#diff-6e976bad6796b538be1a2442c0358640b5177a7ef390376bc2d44d8c0edffe5d |
|
ProjectService.java
| https://github.com/feast-dev/feast/pull/554/changes#diff-12f1ebdf4fde087ebb0e29de2202a6860908d9cad518b879bea4e7b4aef4f60c |
|
application.yml
| https://github.com/feast-dev/feast/pull/554/changes#diff-cb96a7758543958bd30e0c4d1ceec43619c0a4fbd7da783119275ea2a4cd797b |
|
CoreServiceAuthTest.java
| https://github.com/feast-dev/feast/pull/554/changes#diff-b57b9bc4c4c7cccc93d3d7226e9b318adee13f6c597ac74ba7ec79c93f866f93 |
|
ProjectServiceTest.java
| https://github.com/feast-dev/feast/pull/554/changes#diff-531d66d2f951bd624476eaa19f3c05731827dbb1c00e73aa2869d3d774d2312f |
|
test-end-to-end-batch.sh
| https://github.com/feast-dev/feast/pull/554/changes#diff-0d9c3baeec60e68ac632b6a14b287e704dd8621b136c53ddee4dbcc7526bb863 |
|
test-end-to-end.sh
| https://github.com/feast-dev/feast/pull/554/changes#diff-96753c291ff35a31678e391948d981ccba2b46f20eaa3e976a9390599b6f65e8 |
|
client.py
| https://github.com/feast-dev/feast/pull/554/changes#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379 |
|
config.py
| https://github.com/feast-dev/feast/pull/554/changes#diff-2de30c3264f96278e49d3c18e94fd5c05f180693d6b73b5dd6a4e9d23b29e83b |
|
constants.py
| https://github.com/feast-dev/feast/pull/554/changes#diff-d2ece60a745d0f95c6bf2757d8ab5a351fbe9e96b3e78a63802c39f1ef31d9ac |
|
auth.py
| https://github.com/feast-dev/feast/pull/554/changes#diff-f13d1828c62710dfe2665d3e896993811d7581636dbccaeb737e35f01ad1be42 |
|
grpc.py
| https://github.com/feast-dev/feast/pull/554/changes#diff-37b9ffe005ae1a32d6060c624dc8714411bc84653e16a27587665be307592699 |
|
feast_core_server.py
| https://github.com/feast-dev/feast/pull/554/changes#diff-6e1f8f386939497b864ceccbb0f1345218204d696133a9bacdf6a67a17f01b79 |
|
test_client.py
| https://github.com/feast-dev/feast/pull/554/changes#diff-dd9aaf4113915b368515057d8c42402d3ba8ed6614985497d58887982304e3ca |
| .gitignore | https://github.com/feast-dev/feast/pull/554/changes#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947 |
|
View file
| https://github.com/woop/feast/blob/49976945a1d208b2b0bc084034ccd1ba0231282e/.gitignore |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/554/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/554/changes#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947 |
| Please reload this page | https://github.com/feast-dev/feast/pull/554/changes |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |