René's URL Explorer Experiment


Title: Add Redis storage implementation by zhilingc · Pull Request #547 · feast-dev/feast · GitHub

Open Graph Title: Add Redis storage implementation by zhilingc · Pull Request #547 · feast-dev/feast

X Title: Add Redis storage implementation by zhilingc · Pull Request #547 · feast-dev/feast

Description: What this PR does / why we need it: Moves redis storage code for reading and writing to the storage module. A huge todo is to figure out how to expose metrics to the caller here - would love some h...

Open Graph Description: What this PR does / why we need it: Moves redis storage code for reading and writing to the storage module. A huge todo is to figure out how to expose metrics to the caller here - would love some h...

X Description: What this PR does / why we need it: Moves redis storage code for reading and writing to the storage module. A huge todo is to figure out how to expose metrics to the caller here - would love some h...

Opengraph URL: https://github.com/feast-dev/feast/pull/547

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3d222ed0-631a-e257-f1ff-32963634c82b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE138:275B2E:24BE16E:3147FD8:697AC346
html-safe-nonce17a2d1901cec55b60a1e5a171d0728878273e1de0f40039042257558284d747e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTM4OjI3NUIyRToyNEJFMTZFOjMxNDdGRDg6Njk3QUMzNDYiLCJ2aXNpdG9yX2lkIjoiMzI1NDc3OTY4NjcyNjMyMDk2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf4601ba7f71c001f2be1b8a3025338a49a054ce0d5e8cec9709e0c434591c09a
hovercard-subject-tagpull_request:390183206
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/547/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9d2de44a151dd41f59ffc897b369d2f55cdaa0f63b18e5f97757964ca99307a7/feast-dev/feast/pull/547
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9d2de44a151dd41f59ffc897b369d2f55cdaa0f63b18e5f97757964ca99307a7/feast-dev/feast/pull/547
og:image:altWhat this PR does / why we need it: Moves redis storage code for reading and writing to the storage module. A huge todo is to figure out how to expose metrics to the caller here - would love some h...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezhilingc
hostnamegithub.com
expected-hostnamegithub.com
None37b00135a01848812420158e49744eb9715c1ef534ee4552f790d6ef33807fc2
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release78685bd12c01954e3a0e08fc52173e9b3e48215d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/547#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F547
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F547
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/547
Reloadhttps://github.com/feast-dev/feast/pull/547
Reloadhttps://github.com/feast-dev/feast/pull/547
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 183 https://github.com/feast-dev/feast/issues
Pull requests 68 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast/pull/547#issue-comment-box
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:storage-refactorhttps://github.com/feast-dev/feast/tree/storage-refactor
zhilingc:storage-refactor-redishttps://github.com/zhilingc/feast/tree/storage-refactor-redis
Add Redis storage implementation https://github.com/feast-dev/feast/pull/547#top
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:storage-refactorhttps://github.com/feast-dev/feast/tree/storage-refactor
zhilingc:storage-refactor-redishttps://github.com/zhilingc/feast/tree/storage-refactor-redis
Conversation 8 https://github.com/feast-dev/feast/pull/547
Commits 5 https://github.com/feast-dev/feast/pull/547/commits
Checks 0 https://github.com/feast-dev/feast/pull/547/checks
Files changed https://github.com/feast-dev/feast/pull/547/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/547
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Mar 18, 2020https://github.com/feast-dev/feast/pull/547#issue-583425112
Please reload this pagehttps://github.com/feast-dev/feast/pull/547
herehttps://github.com/gojek/feast/blob/b9bf8e8222bf6cf18e8a35bd40083936ca63c432/storage/connectors/redis/src/main/java/feast/storage/connectors/redis/retrieval/RedisOnlineRetriever.java#L149
Please reload this pagehttps://github.com/feast-dev/feast/pull/547
Add Redis storagehttps://github.com/feast-dev/feast/pull/547/commits/b9bf8e8222bf6cf18e8a35bd40083936ca63c432
b9bf8e8https://github.com/feast-dev/feast/pull/547/commits/b9bf8e8222bf6cf18e8a35bd40083936ca63c432
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
davidheryantohttps://github.com/davidheryanto
khorshuhenghttps://github.com/khorshuheng
pradithyahttps://github.com/pradithya
woophttps://github.com/woop
code ownershttps://github.com/feast-dev/feast/blob/8d8737a28f1de55aa0f7eb905b1027e1b49f86da/.github/CODEOWNERS#L4
March 18, 2020 02:50https://github.com/feast-dev/feast/pull/547#event-3139754676
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Mar 18, 2020https://github.com/feast-dev/feast/pull/547#issuecomment-600397575
zhilingchttps://github.com/gojek/feast/pull/547
herehttps://go.k8s.io/bot-commands?repo=gojek%2Ffeast
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/gojek/feast/blob/storage-refactor/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast/pull/547
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
size/XXL https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXXL
Mar 18, 2020https://github.com/feast-dev/feast/pull/547#event-3139754794
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Mar 18, 2020https://github.com/feast-dev/feast/pull/547#issuecomment-600397978
Please reload this pagehttps://github.com/feast-dev/feast/pull/547
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
do-not-merge/hold https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fhold
Mar 18, 2020https://github.com/feast-dev/feast/pull/547#event-3139757748
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Mar 18, 2020https://github.com/feast-dev/feast/pull/547#issuecomment-600407315
Please reload this pagehttps://github.com/feast-dev/feast/pull/547
Remove staleness check; can be checked at the service levelhttps://github.com/feast-dev/feast/pull/547/commits/1b0bb9ffcb020b3a96ca883578883a279a9b2d28
1b0bb9fhttps://github.com/feast-dev/feast/pull/547/commits/1b0bb9ffcb020b3a96ca883578883a279a9b2d28
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Mar 19, 2020https://github.com/feast-dev/feast/pull/547#issuecomment-600963067
Please reload this pagehttps://github.com/feast-dev/feast/pull/547
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
do-not-merge/hold https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fhold
Mar 19, 2020https://github.com/feast-dev/feast/pull/547#event-3143890832
Remove staleness related testshttps://github.com/feast-dev/feast/pull/547/commits/797e6ec9fea5529d32deff78a6210c9c32109361
797e6echttps://github.com/feast-dev/feast/pull/547/commits/797e6ec9fea5529d32deff78a6210c9c32109361
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Mar 19, 2020https://github.com/feast-dev/feast/pull/547#issuecomment-600967513
Please reload this pagehttps://github.com/feast-dev/feast/pull/547
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Mar 19, 2020https://github.com/feast-dev/feast/pull/547#issuecomment-600969988
Please reload this pagehttps://github.com/feast-dev/feast/pull/547
March 19, 2020 11:51https://github.com/feast-dev/feast/pull/547#commits-pushed-ba65460
Add dependencies to top level pomhttps://github.com/feast-dev/feast/pull/547/commits/ba6546079b30465f06d1a3794a329874615c6ae6
ba65460https://github.com/feast-dev/feast/pull/547/commits/ba6546079b30465f06d1a3794a329874615c6ae6
Clean up codehttps://github.com/feast-dev/feast/pull/547/commits/a64e42501fdc7c3e6a5b6cd2f031f0ab9653ea21
a64e425https://github.com/feast-dev/feast/pull/547/commits/a64e42501fdc7c3e6a5b6cd2f031f0ab9653ea21
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Mar 19, 2020https://github.com/feast-dev/feast/pull/547#issuecomment-601009854
Please reload this pagehttps://github.com/feast-dev/feast/pull/547
https://github.com/woop
woophttps://github.com/woop
Mar 19, 2020https://github.com/feast-dev/feast/pull/547#issuecomment-601010219
Please reload this pagehttps://github.com/feast-dev/feast/pull/547
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
woophttps://github.com/woop
Mar 19, 2020https://github.com/feast-dev/feast/pull/547#event-3144222384
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
Mar 19, 2020https://github.com/feast-dev/feast/pull/547#event-3144222413
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Mar 19, 2020https://github.com/feast-dev/feast/pull/547#event-3144282273
zhilingchttps://github.com/zhilingc
Mar 19, 2020 https://github.com/feast-dev/feast/pull/547#ref-commit-ac711e1
Add Redis storage implementation (https://github.com/feast-dev/feast/commit/ac711e133c64c35ba4e11c2c3c2c2cdaa7737826
#547https://github.com/feast-dev/feast/pull/547
)https://github.com/feast-dev/feast/commit/ac711e133c64c35ba4e11c2c3c2c2cdaa7737826
ac711e1https://github.com/feast-dev/feast/commit/ac711e133c64c35ba4e11c2c3c2c2cdaa7737826
zhilingchttps://github.com/zhilingc
Mar 23, 2020 https://github.com/feast-dev/feast/pull/547#ref-commit-27b3c91
Add Redis storage implementation (https://github.com/feast-dev/feast/commit/27b3c9193fcf968df6e5f8d67b8d5fec8475155d
#547https://github.com/feast-dev/feast/pull/547
)https://github.com/feast-dev/feast/commit/27b3c9193fcf968df6e5f8d67b8d5fec8475155d
27b3c91https://github.com/feast-dev/feast/commit/27b3c9193fcf968df6e5f8d67b8d5fec8475155d
zhilingchttps://github.com/zhilingc
Mar 29, 2020 https://github.com/feast-dev/feast/pull/547#ref-commit-490e0a7
Add Redis storage implementation (https://github.com/feast-dev/feast/commit/490e0a77be57ba548aebe0adddb7fabc414bf5bf
#547https://github.com/feast-dev/feast/pull/547
)https://github.com/feast-dev/feast/commit/490e0a77be57ba548aebe0adddb7fabc414bf5bf
490e0a7https://github.com/feast-dev/feast/commit/490e0a77be57ba548aebe0adddb7fabc414bf5bf
zhilingchttps://github.com/zhilingc
Apr 3, 2020 https://github.com/feast-dev/feast/pull/547#ref-commit-b2c5750
Add Redis storage implementation (https://github.com/feast-dev/feast/commit/b2c5750e8bf6ceec9d1b6ea26e9ff5985937cfe8
#547https://github.com/feast-dev/feast/pull/547
)https://github.com/feast-dev/feast/commit/b2c5750e8bf6ceec9d1b6ea26e9ff5985937cfe8
b2c5750https://github.com/feast-dev/feast/commit/b2c5750e8bf6ceec9d1b6ea26e9ff5985937cfe8
zhilingchttps://github.com/zhilingc
Apr 7, 2020 https://github.com/feast-dev/feast/pull/547#ref-commit-8b00ad9
Add Redis storage implementation (https://github.com/feast-dev/feast/commit/8b00ad9743fa7f32cfc5972374d0cd37719bec7d
#547https://github.com/feast-dev/feast/pull/547
)https://github.com/feast-dev/feast/commit/8b00ad9743fa7f32cfc5972374d0cd37719bec7d
8b00ad9https://github.com/feast-dev/feast/commit/8b00ad9743fa7f32cfc5972374d0cd37719bec7d
feast-ci-bothttps://github.com/feast-ci-bot
Apr 7, 2020 https://github.com/feast-dev/feast/pull/547#ref-commit-e4f8fe9
Add general storage API and refactor existing store implementations (https://github.com/feast-dev/feast/commit/e4f8fe905d3c182416e1b69bf60bfbc0e8348f8a
#…https://github.com/feast-dev/feast/pull/567
e4f8fe9https://github.com/feast-dev/feast/commit/e4f8fe905d3c182416e1b69bf60bfbc0e8348f8a
…567https://github.com/feast-dev/feast/pull/567
#529https://github.com/feast-dev/feast/pull/529
#546https://github.com/feast-dev/feast/pull/546
#547https://github.com/feast-dev/feast/pull/547
#553https://github.com/feast-dev/feast/pull/553
#569https://github.com/feast-dev/feast/pull/569
#586https://github.com/feast-dev/feast/pull/586
#601https://github.com/feast-dev/feast/pull/601
#607https://github.com/feast-dev/feast/pull/607
#605https://github.com/feast-dev/feast/pull/605
https://github.com/ches
cheshttps://github.com/ches
v0.5.0https://github.com/feast-dev/feast/milestone/2
Apr 26, 2020https://github.com/feast-dev/feast/pull/547#event-3273216041
https://github.com/woop
woophttps://github.com/woop
May 20, 2021 https://github.com/feast-dev/feast/pull/547#ref-issue-896636108
Feast 0.10 on onpremise k8s environment #1567 https://github.com/feast-dev/feast/issues/1567
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F547
https://github.com/davidheryanto
davidheryanto https://github.com/davidheryanto
https://github.com/khorshuheng
khorshuheng https://github.com/khorshuheng
https://github.com/pradithya
pradithya https://github.com/pradithya
https://github.com/woop
woop https://github.com/woop
https://github.com/woop
woop https://github.com/woop
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
size/XXL https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXXL
v0.5.0 https://github.com/feast-dev/feast/milestone/2
Please reload this pagehttps://github.com/feast-dev/feast/pull/547
https://github.com/zhilingc
https://github.com/feast-ci-bot
https://github.com/woop
https://github.com/ches
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.