René's URL Explorer Experiment


Title: Encode feature row before storing in Redis by khorshuheng · Pull Request #530 · feast-dev/feast · GitHub

Open Graph Title: Encode feature row before storing in Redis by khorshuheng · Pull Request #530 · feast-dev/feast

X Title: Encode feature row before storing in Redis by khorshuheng · Pull Request #530 · feast-dev/feast

Description: What this PR does / why we need it: Currently, feature names are stored together with the values in Redis, which result in excessive memory foot print in cases where feature names are long strings....

Open Graph Description: What this PR does / why we need it: Currently, feature names are stored together with the values in Redis, which result in excessive memory foot print in cases where feature names are long strings....

X Description: What this PR does / why we need it: Currently, feature names are stored together with the values in Redis, which result in excessive memory foot print in cases where feature names are long strings....

Opengraph URL: https://github.com/feast-dev/feast/pull/530

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9434c97c-4ef3-3aa5-d9c1-ffa063e20d67
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA578:203DE7:14E1BB9:1DB0465:697A3D04
html-safe-nonce840b8f3141bea531f119f01d37c4b4a839f49893463ea16d21f99cfedca9157e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTc4OjIwM0RFNzoxNEUxQkI5OjFEQjA0NjU6Njk3QTNEMDQiLCJ2aXNpdG9yX2lkIjoiODY1NzY4NzExNzQ5NTE2NTQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac451ae535208a0e976e0a9fd3fe21afaa7c126a605a0b21cd8f2d37144213c6be
hovercard-subject-tagpull_request:386543202
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/530/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5a7e2f5aa86869e8affffdef4223f31a4496a9c709d1df97ad2a249090df46b9/feast-dev/feast/pull/530
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5a7e2f5aa86869e8affffdef4223f31a4496a9c709d1df97ad2a249090df46b9/feast-dev/feast/pull/530
og:image:altWhat this PR does / why we need it: Currently, feature names are stored together with the values in Redis, which result in excessive memory foot print in cases where feature names are long strings....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekhorshuheng
hostnamegithub.com
expected-hostnamegithub.com
None4a0b4010ae0a1c23b415e9254044ae36042a44c358266cc9a18f32128faad1cf
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release751738b6aa7c947aef1bb025fad420093c6e3c81
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/530#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F530
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F530
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/530
Reloadhttps://github.com/feast-dev/feast/pull/530
Reloadhttps://github.com/feast-dev/feast/pull/530
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 181 https://github.com/feast-dev/feast/issues
Pull requests 69 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast/pull/530#issue-comment-box
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
khorshuheng:reduce-memory-footprinthttps://github.com/khorshuheng/feast/tree/reduce-memory-footprint
Encode feature row before storing in Redis https://github.com/feast-dev/feast/pull/530#top
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
khorshuheng:reduce-memory-footprinthttps://github.com/khorshuheng/feast/tree/reduce-memory-footprint
Conversation 16 https://github.com/feast-dev/feast/pull/530
Commits 2 https://github.com/feast-dev/feast/pull/530/commits
Checks 0 https://github.com/feast-dev/feast/pull/530/checks
Files changed https://github.com/feast-dev/feast/pull/530/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/530
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
Mar 11, 2020https://github.com/feast-dev/feast/pull/530#issue-579082422
#515https://github.com/feast-dev/feast/issues/515
Please reload this pagehttps://github.com/feast-dev/feast/pull/530
https://github.com/khorshuheng
Encode feature row before storing in Redishttps://github.com/feast-dev/feast/pull/530/commits/67f5bc951e25a8323f2e1bad7ac118b7db376c49
67f5bc9https://github.com/feast-dev/feast/pull/530/commits/67f5bc951e25a8323f2e1bad7ac118b7db376c49
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
pradithyahttps://github.com/pradithya
zhilingchttps://github.com/zhilingc
code ownershttps://github.com/feast-dev/feast/blob/40b67c05a21c5af8cfdeaa1a445f5eb730e5dd48/.github/CODEOWNERS#L6
March 11, 2020 08:15https://github.com/feast-dev/feast/pull/530#event-3117727018
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
size/XL https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXL
Mar 11, 2020https://github.com/feast-dev/feast/pull/530#event-3117727659
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
Mar 11, 2020https://github.com/feast-dev/feast/pull/530#issuecomment-597503321
Please reload this pagehttps://github.com/feast-dev/feast/pull/530
https://github.com/woop
woophttps://github.com/woop
Mar 11, 2020 https://github.com/feast-dev/feast/pull/530#pullrequestreview-372555196
View reviewed changes https://github.com/feast-dev/feast/pull/530/files/67f5bc951e25a8323f2e1bad7ac118b7db376c49
ingestion/src/main/java/feast/store/serving/redis/FeatureRowToRedisMutationDoFn.javahttps://github.com/feast-dev/feast/pull/530/files/67f5bc951e25a8323f2e1bad7ac118b7db376c49#diff-7cfd41a015d3ef196409141cdf89c4fb9f7d515c31ae1239fe7713bf33ea11a7
Please reload this pagehttps://github.com/feast-dev/feast/pull/530
https://github.com/woop
woophttps://github.com/woop
Mar 11, 2020 https://github.com/feast-dev/feast/pull/530#pullrequestreview-372555405
View reviewed changes https://github.com/feast-dev/feast/pull/530/files/67f5bc951e25a8323f2e1bad7ac118b7db376c49
ingestion/src/main/java/feast/store/serving/redis/FeatureRowToRedisMutationDoFn.javahttps://github.com/feast-dev/feast/pull/530/files/67f5bc951e25a8323f2e1bad7ac118b7db376c49#diff-7cfd41a015d3ef196409141cdf89c4fb9f7d515c31ae1239fe7713bf33ea11a7
woophttps://github.com/woop
Mar 11, 2020https://github.com/feast-dev/feast/pull/530#discussion_r390811179
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/530
khorshuhenghttps://github.com/khorshuheng
Mar 11, 2020https://github.com/feast-dev/feast/pull/530#discussion_r390814432
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/530
https://github.com/woop
woophttps://github.com/woop
Mar 11, 2020 https://github.com/feast-dev/feast/pull/530#pullrequestreview-372560539
View reviewed changes https://github.com/feast-dev/feast/pull/530/files/67f5bc951e25a8323f2e1bad7ac118b7db376c49
serving/src/main/java/feast/serving/encoding/FeatureRowDecoder.javahttps://github.com/feast-dev/feast/pull/530/files/67f5bc951e25a8323f2e1bad7ac118b7db376c49#diff-52171b203ad1bd91ce0fcdec32d80f58a6735e07cb08b3e711bbb06b232f3ef5
woophttps://github.com/woop
Mar 11, 2020https://github.com/feast-dev/feast/pull/530#discussion_r390815504
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/530
khorshuhenghttps://github.com/khorshuheng
Mar 11, 2020https://github.com/feast-dev/feast/pull/530#discussion_r390860877
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#515https://github.com/feast-dev/feast/issues/515
Please reload this pagehttps://github.com/feast-dev/feast/pull/530
cheshttps://github.com/ches
May 4, 2020https://github.com/feast-dev/feast/pull/530#discussion_r419341208
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/530
cheshttps://github.com/ches
May 4, 2020https://github.com/feast-dev/feast/pull/530#discussion_r419346399
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@zhilingchttps://github.com/zhilingc
in a comment thread on her versions removal RFChttps://docs.google.com/document/d/1P44LHd724JloQtpn10naAg5MlzcrkeOlN3QzAn9O8uY/edit?disco=AAAAJReHWQM
Please reload this pagehttps://github.com/feast-dev/feast/pull/530
https://github.com/khorshuheng
Include encoding as part of RedisMutationDoFnhttps://github.com/feast-dev/feast/pull/530/commits/9252360a31f637186ceab6c33e1d91ea47288e43
9252360https://github.com/feast-dev/feast/pull/530/commits/9252360a31f637186ceab6c33e1d91ea47288e43
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
size/XL https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXL
Mar 11, 2020https://github.com/feast-dev/feast/pull/530#event-3118033326
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
Mar 11, 2020https://github.com/feast-dev/feast/pull/530#issuecomment-597544465
Please reload this pagehttps://github.com/feast-dev/feast/pull/530
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Mar 13, 2020https://github.com/feast-dev/feast/pull/530#issuecomment-598530311
Please reload this pagehttps://github.com/feast-dev/feast/pull/530
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
zhilingchttps://github.com/zhilingc
Mar 13, 2020https://github.com/feast-dev/feast/pull/530#event-3125259494
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
Mar 13, 2020https://github.com/feast-dev/feast/pull/530#event-3125259516
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Mar 13, 2020https://github.com/feast-dev/feast/pull/530#issuecomment-598580996
Please reload this pagehttps://github.com/feast-dev/feast/pull/530
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Mar 13, 2020https://github.com/feast-dev/feast/pull/530#issuecomment-598581018
khorshuhenghttps://github.com/gojek/feast/pull/530
zhilingchttps://github.com/gojek/feast/pull/530#issuecomment-598580996
herehttps://go.k8s.io/bot-commands?repo=gojek%2Ffeast
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/gojek/feast/blob/master/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast/pull/530
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
Mar 13, 2020https://github.com/feast-dev/feast/pull/530#event-3125615947
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
e7a1a39https://github.com/feast-dev/feast/commit/e7a1a39a3756ddf646bef177e76f8d6252cfbc33
Mar 13, 2020https://github.com/feast-dev/feast/pull/530#event-3125617464
khorshuhenghttps://github.com/khorshuheng
Mar 16, 2020 https://github.com/feast-dev/feast/pull/530#ref-commit-f3a4886
https://github.com/khorshuheng
Encode feature row before storing in Redis (https://github.com/khorshuheng/feast/commit/f3a48867ec179359fc4a95a734935e8189ecc332
feast-dev#530https://github.com/feast-dev/feast/pull/530
)https://github.com/khorshuheng/feast/commit/f3a48867ec179359fc4a95a734935e8189ecc332
f3a4886https://github.com/khorshuheng/feast/commit/f3a48867ec179359fc4a95a734935e8189ecc332
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
Mar 16, 2020 https://github.com/feast-dev/feast/pull/530#ref-pullrequest-582118648
Encode feature row before storing in Redis (#530) #540 https://github.com/feast-dev/feast/pull/540
khorshuhenghttps://github.com/khorshuheng
Mar 16, 2020 https://github.com/feast-dev/feast/pull/530#ref-commit-2e9b93a
https://github.com/khorshuheng
Encode feature row before storing in Redis (https://github.com/feast-dev/feast/commit/2e9b93a8992529439d4232a4629d1257f9c7d9d8
#530https://github.com/feast-dev/feast/pull/530
)https://github.com/feast-dev/feast/commit/2e9b93a8992529439d4232a4629d1257f9c7d9d8
2e9b93ahttps://github.com/feast-dev/feast/commit/2e9b93a8992529439d4232a4629d1257f9c7d9d8
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
Mar 18, 2020 https://github.com/feast-dev/feast/pull/530#ref-issue-576662419
Optimize Redis memory foot print for ingestion / serving #515 https://github.com/feast-dev/feast/issues/515
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F530
https://github.com/ches
ches https://github.com/ches
https://github.com/feast-dev/feast/pull/530/files/9252360a31f637186ceab6c33e1d91ea47288e43
https://github.com/woop
woop https://github.com/woop
https://github.com/feast-dev/feast/pull/530/files/67f5bc951e25a8323f2e1bad7ac118b7db376c49
https://github.com/pradithya
pradithya https://github.com/pradithya
https://github.com/zhilingc
zhilingc https://github.com/zhilingc
https://github.com/zhilingc
zhilingc https://github.com/zhilingc
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
Optimize Redis memory foot print for ingestion / serving https://github.com/feast-dev/feast/issues/515
Please reload this pagehttps://github.com/feast-dev/feast/pull/530
https://github.com/khorshuheng
https://github.com/zhilingc
https://github.com/feast-ci-bot
https://github.com/ches
https://github.com/woop
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.