Title: Enforce JDK 11 for development, but build Ingestion to target Java 8 by ches · Pull Request #518 · feast-dev/feast · GitHub
Open Graph Title: Enforce JDK 11 for development, but build Ingestion to target Java 8 by ches · Pull Request #518 · feast-dev/feast
X Title: Enforce JDK 11 for development, but build Ingestion to target Java 8 by ches · Pull Request #518 · feast-dev/feast
Description: What this PR does / why we need it: This is a PoC for the idea in #517 that Ingestion could be easily built for Java 8 while other components continue to target 11. $ mvn clean compile $ javap -v ingestion/target/classes/feast/ingestion/ImportJob.class | grep major major version: 52 $ javap -v serving/target/classes/feast/serving/ServingApplication.class | grep major major version: 55 Which issue(s) this PR fixes: Addresses #517, speculatively and not completely. Does this PR introduce a user-facing change?: Feast Ingestion is again built for Java 8, for more certain Beam runner compatibility.
Open Graph Description: What this PR does / why we need it: This is a PoC for the idea in #517 that Ingestion could be easily built for Java 8 while other components continue to target 11. $ mvn clean compile $ javap -v ...
X Description: What this PR does / why we need it: This is a PoC for the idea in #517 that Ingestion could be easily built for Java 8 while other components continue to target 11. $ mvn clean compile $ javap -v ...
Opengraph URL: https://github.com/feast-dev/feast/pull/518
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:95ae90cc-150a-c8b7-a929-5387875f0b57 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | B71C:96916:C7554A:115D1E5:697C8157 |
| html-safe-nonce | 158240e15867120c1ed2d8c6fae001dc6a380f67003ea2680025eb198ecbb38e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzFDOjk2OTE2OkM3NTU0QToxMTVEMUU1OjY5N0M4MTU3IiwidmlzaXRvcl9pZCI6IjcxNTQ2MDA5NzYzNTgwODA4NTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 11b4249e0b55d88767f1a4e7eeb04dcbd4cd791c6c3fffe5cbe5b3ab00c19255 |
| hovercard-subject-tag | pull_request:385160642 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/518/checks |
| twitter:image | https://avatars.githubusercontent.com/u/13277?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/13277?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: This is a PoC for the idea in #517 that Ingestion could be easily built for Java 8 while other components continue to target 11. $ mvn clean compile $ javap -v ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2278434408c65352e7fb6b4e69575369fa9b682ba3050384c8238b8af14b4851 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 97213a8fa33501931569c2bd088937acd48952ff |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width