René's URL Explorer Experiment


Title: Rename metric name for request latency in feast serving by davidheryanto · Pull Request #488 · feast-dev/feast · GitHub

Open Graph Title: Rename metric name for request latency in feast serving by davidheryanto · Pull Request #488 · feast-dev/feast

X Title: Rename metric name for request latency in feast serving by davidheryanto · Pull Request #488 · feast-dev/feast

Description: What this PR does / why we need it: So that it is consistent with the actual unit of timing being measured. And recommended metric names in Prometheus https://prometheus.io/docs/practices/naming/#metric-names Which issue(s) this PR fixes: NONE Does this PR introduce a user-facing change?: NONE

Open Graph Description: What this PR does / why we need it: So that it is consistent with the actual unit of timing being measured. And recommended metric names in Prometheus https://prometheus.io/docs/practices/naming/#m...

X Description: What this PR does / why we need it: So that it is consistent with the actual unit of timing being measured. And recommended metric names in Prometheus https://prometheus.io/docs/practices/naming/#m...

Opengraph URL: https://github.com/feast-dev/feast/pull/488

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:63acd4db-49ee-373d-a2ef-4b033ff63b1a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE2F2:5F4A4:1F28CD1:29C2997:697AAFA6
html-safe-nonce042922bda252ab7616920051e478c95eb81ddf14864f121333e2dd7c64bebe81
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkYyOjVGNEE0OjFGMjhDRDE6MjlDMjk5Nzo2OTdBQUZBNiIsInZpc2l0b3JfaWQiOiI3MTc2NTMxODQzODc1NTE2MzI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3ab96b0c0e5a97a6d017b48dba15b9a46958f6e1cb51aa0ed818bec35e0943cc
hovercard-subject-tagpull_request:378803273
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/488/files
twitter:imagehttps://avatars.githubusercontent.com/u/5300554?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5300554?s=400&v=4
og:image:altWhat this PR does / why we need it: So that it is consistent with the actual unit of timing being measured. And recommended metric names in Prometheus https://prometheus.io/docs/practices/naming/#m...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None33acda8ebf71b04c9d33b494d2b6e0db48193ec89eb3ad92a9539d491fa9a3da
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4f714a84d3384e467839505ed65f968fc01aedf1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/488/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F488%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F488%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/488/files
Reloadhttps://github.com/feast-dev/feast/pull/488/files
Reloadhttps://github.com/feast-dev/feast/pull/488/files
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 183 https://github.com/feast-dev/feast/issues
Pull requests 68 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
davidheryanto:fix-prometheus-metric-name-in-feast-servinghttps://github.com/davidheryanto/feast/tree/fix-prometheus-metric-name-in-feast-serving
Conversation 9 https://github.com/feast-dev/feast/pull/488
Commits 1 https://github.com/feast-dev/feast/pull/488/commits
Checks 0 https://github.com/feast-dev/feast/pull/488/checks
Files changed https://github.com/feast-dev/feast/pull/488/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/488/files
Rename metric name for request latency in feast serving https://github.com/feast-dev/feast/pull/488/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/488/files
3e5be55 Rename metric name for request latency in feast serving davidheryanto Feb 24, 2020 https://github.com/feast-dev/feast/pull/488/commits/3e5be55927393a5f5ac31f60f0528bb3dd65141d
Clear filters https://github.com/feast-dev/feast/pull/488/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/488/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/488/files
RedisServingService.java https://github.com/feast-dev/feast/pull/488/files#diff-9c2f121520389255e097958299147c65fc10cfa496d098a82d30b280497ecb97
Metrics.java https://github.com/feast-dev/feast/pull/488/files#diff-bb3919ec873fbc8fd850864a34ab37ab39abc65e37dd1d9ab817a2d2188c89e5
serving/src/main/java/feast/serving/service/RedisServingService.javahttps://github.com/feast-dev/feast/pull/488/files#diff-9c2f121520389255e097958299147c65fc10cfa496d098a82d30b280497ecb97
View file https://github.com/davidheryanto/feast/blob/3e5be55927393a5f5ac31f60f0528bb3dd65141d/serving/src/main/java/feast/serving/service/RedisServingService.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/488/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/488/files#diff-9c2f121520389255e097958299147c65fc10cfa496d098a82d30b280497ecb97
https://github.com/feast-dev/feast/pull/488/files#diff-9c2f121520389255e097958299147c65fc10cfa496d098a82d30b280497ecb97
serving/src/main/java/feast/serving/util/Metrics.javahttps://github.com/feast-dev/feast/pull/488/files#diff-bb3919ec873fbc8fd850864a34ab37ab39abc65e37dd1d9ab817a2d2188c89e5
View file https://github.com/davidheryanto/feast/blob/3e5be55927393a5f5ac31f60f0528bb3dd65141d/serving/src/main/java/feast/serving/util/Metrics.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/488/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/488/files#diff-bb3919ec873fbc8fd850864a34ab37ab39abc65e37dd1d9ab817a2d2188c89e5
https://github.com/feast-dev/feast/pull/488/files#diff-bb3919ec873fbc8fd850864a34ab37ab39abc65e37dd1d9ab817a2d2188c89e5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.