René's URL Explorer Experiment


Title: Rename metric name for request latency in feast serving by davidheryanto · Pull Request #488 · feast-dev/feast · GitHub

Open Graph Title: Rename metric name for request latency in feast serving by davidheryanto · Pull Request #488 · feast-dev/feast

X Title: Rename metric name for request latency in feast serving by davidheryanto · Pull Request #488 · feast-dev/feast

Description: What this PR does / why we need it: So that it is consistent with the actual unit of timing being measured. And recommended metric names in Prometheus https://prometheus.io/docs/practices/naming/#m...

Open Graph Description: What this PR does / why we need it: So that it is consistent with the actual unit of timing being measured. And recommended metric names in Prometheus https://prometheus.io/docs/practices/naming/#m...

X Description: What this PR does / why we need it: So that it is consistent with the actual unit of timing being measured. And recommended metric names in Prometheus https://prometheus.io/docs/practices/naming/#m...

Opengraph URL: https://github.com/feast-dev/feast/pull/488

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:58612895-22f9-5bbc-3683-d64134b3d8dc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABBE:369489:E2C6C5:136E11E:697A7D09
html-safe-nonce8781dd96b61635cb4268f47f1570b82fcc952ad5e4dac954216b09e3ee534382
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkJFOjM2OTQ4OTpFMkM2QzU6MTM2RTExRTo2OTdBN0QwOSIsInZpc2l0b3JfaWQiOiI1MDU0NDkxOTYwMDk0MTI5NDE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9e862c4881ab481aee8b0e0d55a4c0fae0445872c0937f0db2154c178dd3af53
hovercard-subject-tagpull_request:378803273
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/488/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5e3866ab3317b609358ae970b3b5dbd6a7b5dceef8f8785888057db629d90fb7/feast-dev/feast/pull/488
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5e3866ab3317b609358ae970b3b5dbd6a7b5dceef8f8785888057db629d90fb7/feast-dev/feast/pull/488
og:image:altWhat this PR does / why we need it: So that it is consistent with the actual unit of timing being measured. And recommended metric names in Prometheus https://prometheus.io/docs/practices/naming/#m...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedavidheryanto
hostnamegithub.com
expected-hostnamegithub.com
Nonea9d1eabfb8cf0cb510bcf598032681675ad29b7ee4cb3bfb9a0a088a12803628
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31bacebc3305d80609c1b175449c3d314bd1a855
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/488#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F488
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F488
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/488
Reloadhttps://github.com/feast-dev/feast/pull/488
Reloadhttps://github.com/feast-dev/feast/pull/488
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 183 https://github.com/feast-dev/feast/issues
Pull requests 68 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast/pull/488#issue-comment-box
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
davidheryanto:fix-prometheus-metric-name-in-feast-servinghttps://github.com/davidheryanto/feast/tree/fix-prometheus-metric-name-in-feast-serving
Rename metric name for request latency in feast serving https://github.com/feast-dev/feast/pull/488#top
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
davidheryanto:fix-prometheus-metric-name-in-feast-servinghttps://github.com/davidheryanto/feast/tree/fix-prometheus-metric-name-in-feast-serving
Conversation 9 https://github.com/feast-dev/feast/pull/488
Commits 1 https://github.com/feast-dev/feast/pull/488/commits
Checks 0 https://github.com/feast-dev/feast/pull/488/checks
Files changed https://github.com/feast-dev/feast/pull/488/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/488
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
https://github.com/davidheryanto
davidheryantohttps://github.com/davidheryanto
Feb 24, 2020https://github.com/feast-dev/feast/pull/488#issue-569627851
https://prometheus.io/docs/practices/naming/#metric-nameshttps://prometheus.io/docs/practices/naming/#metric-names
Please reload this pagehttps://github.com/feast-dev/feast/pull/488
https://github.com/davidheryanto
Rename metric name for request latency in feast servinghttps://github.com/feast-dev/feast/pull/488/commits/3e5be55927393a5f5ac31f60f0528bb3dd65141d
3e5be55https://github.com/feast-dev/feast/pull/488/commits/3e5be55927393a5f5ac31f60f0528bb3dd65141d
https://prometheus.io/docs/practices/naming/#metric-nameshttps://prometheus.io/docs/practices/naming/#metric-names
https://github.com/davidheryanto
davidheryantohttps://github.com/davidheryanto
pradithyahttps://github.com/pradithya
zhilingchttps://github.com/zhilingc
code ownershttps://github.com/feast-dev/feast/blob/aec7979f2986e56d7be525cc6b27a1eeb786d501/.github/CODEOWNERS#L7
February 24, 2020 04:19https://github.com/feast-dev/feast/pull/488#event-3064051581
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
size/XS https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXS
Feb 24, 2020https://github.com/feast-dev/feast/pull/488#event-3064051631
https://github.com/davidheryanto
davidheryantohttps://github.com/davidheryanto
Feb 24, 2020https://github.com/feast-dev/feast/pull/488#issuecomment-590174609
Please reload this pagehttps://github.com/feast-dev/feast/pull/488
https://github.com/davidheryanto
davidheryantohttps://github.com/davidheryanto
Feb 24, 2020https://github.com/feast-dev/feast/pull/488#issuecomment-590176585
Please reload this pagehttps://github.com/feast-dev/feast/pull/488
https://github.com/davidheryanto
davidheryantohttps://github.com/davidheryanto
Feb 24, 2020https://github.com/feast-dev/feast/pull/488#issuecomment-590214184
Please reload this pagehttps://github.com/feast-dev/feast/pull/488
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
do-not-merge/hold https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fhold
Feb 24, 2020https://github.com/feast-dev/feast/pull/488#event-3064456359
https://github.com/davidheryanto
davidheryantohttps://github.com/davidheryanto
khorshuhenghttps://github.com/khorshuheng
woophttps://github.com/woop
code ownershttps://github.com/feast-dev/feast/blob/aec7979f2986e56d7be525cc6b27a1eeb786d501/.github/CODEOWNERS#L4
February 24, 2020 08:38https://github.com/feast-dev/feast/pull/488#event-3064464360
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
size/S https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FS
size/XS https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXS
Feb 24, 2020https://github.com/feast-dev/feast/pull/488#event-3064465042
https://github.com/davidheryanto
davidheryantohttps://github.com/davidheryanto
Feb 24, 2020https://github.com/feast-dev/feast/pull/488#issuecomment-590223880
Please reload this pagehttps://github.com/feast-dev/feast/pull/488
https://github.com/davidheryanto
davidheryantohttps://github.com/davidheryanto
Feb 24, 2020 https://github.com/feast-dev/feast/pull/488#ref-pullrequest-569734983
Fix fastavro version used in Feast to avoid Timestamp delta error #490 https://github.com/feast-dev/feast/pull/490
https://github.com/davidheryanto
davidheryantohttps://github.com/davidheryanto
Feb 25, 2020https://github.com/feast-dev/feast/pull/488#issuecomment-590653578
Please reload this pagehttps://github.com/feast-dev/feast/pull/488
https://github.com/davidheryanto
davidheryantohttps://github.com/davidheryanto
force-pushedhttps://github.com/feast-dev/feast/compare/74be918b8a526743664ffa4b26b8cd06cc1ecc12..3e5be55927393a5f5ac31f60f0528bb3dd65141d
74be918https://github.com/feast-dev/feast/commit/74be918b8a526743664ffa4b26b8cd06cc1ecc12
3e5be55https://github.com/feast-dev/feast/commit/3e5be55927393a5f5ac31f60f0528bb3dd65141d
Compare https://github.com/feast-dev/feast/compare/74be918b8a526743664ffa4b26b8cd06cc1ecc12..3e5be55927393a5f5ac31f60f0528bb3dd65141d
February 25, 2020 05:33https://github.com/feast-dev/feast/pull/488#event-3068028068
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
size/XS https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXS
size/S https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FS
Feb 25, 2020https://github.com/feast-dev/feast/pull/488#event-3068028413
https://github.com/woop
woophttps://github.com/woop
Feb 25, 2020https://github.com/feast-dev/feast/pull/488#issuecomment-591134981
@davidheryantohttps://github.com/davidheryanto
Please reload this pagehttps://github.com/feast-dev/feast/pull/488
https://github.com/davidheryanto
davidheryantohttps://github.com/davidheryanto
Feb 26, 2020https://github.com/feast-dev/feast/pull/488#issuecomment-591185424
Please reload this pagehttps://github.com/feast-dev/feast/pull/488
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
do-not-merge/hold https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fhold
Feb 26, 2020https://github.com/feast-dev/feast/pull/488#event-3071747474
https://github.com/woop
woophttps://github.com/woop
Feb 26, 2020https://github.com/feast-dev/feast/pull/488#issuecomment-591187623
Please reload this pagehttps://github.com/feast-dev/feast/pull/488
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
woophttps://github.com/woop
Feb 26, 2020https://github.com/feast-dev/feast/pull/488#event-3071763791
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
Feb 26, 2020https://github.com/feast-dev/feast/pull/488#event-3071763820
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Feb 26, 2020https://github.com/feast-dev/feast/pull/488#issuecomment-591187648
davidheryantohttps://github.com/gojek/feast/pull/488
woophttps://github.com/gojek/feast/pull/488#issuecomment-591187623
herehttps://go.k8s.io/bot-commands?repo=gojek%2Ffeast
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/gojek/feast/blob/master/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast/pull/488
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
5758d99https://github.com/feast-dev/feast/commit/5758d99a7048d166dc011f6a97333e68811c2003
Feb 26, 2020https://github.com/feast-dev/feast/pull/488#event-3071792827
davidheryantohttps://github.com/davidheryanto
Feb 26, 2020 https://github.com/feast-dev/feast/pull/488#ref-commit-6508e42
https://github.com/davidheryanto
Rename metric name for request latency in feast serving (https://github.com/davidheryanto/feast/commit/6508e423a5e0b5e67940b688ceb439f0464b8635
feast-dev#488https://github.com/feast-dev/feast/pull/488
)https://github.com/davidheryanto/feast/commit/6508e423a5e0b5e67940b688ceb439f0464b8635
6508e42https://github.com/davidheryanto/feast/commit/6508e423a5e0b5e67940b688ceb439f0464b8635
https://prometheus.io/docs/practices/naming/#metric-nameshttps://prometheus.io/docs/practices/naming/#metric-names
5758d99https://github.com/davidheryanto/feast/commit/5758d99a7048d166dc011f6a97333e68811c2003
zhilingchttps://github.com/zhilingc
Feb 26, 2020 https://github.com/feast-dev/feast/pull/488#ref-commit-5f55f5c
https://github.com/davidheryanto
https://github.com/zhilingc
Rename metric name for request latency in feast serving (https://github.com/feast-dev/feast/commit/5f55f5c3002881e592c8f128ac38847c47081acd
#488https://github.com/feast-dev/feast/pull/488
)https://github.com/feast-dev/feast/commit/5f55f5c3002881e592c8f128ac38847c47081acd
5f55f5chttps://github.com/feast-dev/feast/commit/5f55f5c3002881e592c8f128ac38847c47081acd
https://prometheus.io/docs/practices/naming/#metric-nameshttps://prometheus.io/docs/practices/naming/#metric-names
5758d99https://github.com/feast-dev/feast/commit/5758d99a7048d166dc011f6a97333e68811c2003
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F488
https://github.com/pradithya
pradithya https://github.com/pradithya
https://github.com/zhilingc
zhilingc https://github.com/zhilingc
https://github.com/khorshuheng
khorshuheng https://github.com/khorshuheng
https://github.com/woop
woop https://github.com/woop
https://github.com/woop
woop https://github.com/woop
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
size/XS https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXS
Please reload this pagehttps://github.com/feast-dev/feast/pull/488
https://github.com/davidheryanto
https://github.com/woop
https://github.com/feast-ci-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.