René's URL Explorer Experiment


Title: Fail Spotless formatting check before tests execute by ches · Pull Request #487 · feast-dev/feast · GitHub

Open Graph Title: Fail Spotless formatting check before tests execute by ches · Pull Request #487 · feast-dev/feast

X Title: Fail Spotless formatting check before tests execute by ches · Pull Request #487 · feast-dev/feast

Description: What this PR does / why we need it: Moves the spotless:check Maven goal to execute after tests compile, but before test executes the tests. This way the check will be run on CI, which runs mvn test...

Open Graph Description: What this PR does / why we need it: Moves the spotless:check Maven goal to execute after tests compile, but before test executes the tests. This way the check will be run on CI, which runs mvn test...

X Description: What this PR does / why we need it: Moves the spotless:check Maven goal to execute after tests compile, but before test executes the tests. This way the check will be run on CI, which runs mvn test...

Opengraph URL: https://github.com/feast-dev/feast/pull/487

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cd92c9d8-da01-ca25-2e9a-94451a2d0083
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA02E:13B4AC:1EC46DD:29AEA48:69799537
html-safe-nonce2d3a174d76d22e317acb6a948426a794c39c4529f9f69f1118c449fbcff06b26
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDJFOjEzQjRBQzoxRUM0NkREOjI5QUVBNDg6Njk3OTk1MzciLCJ2aXNpdG9yX2lkIjoiMzkyNDgxMzgwMzYyNzIwNTY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac25a15461b5c3449f7d0f23033f92d873850602a4f09f68d88fa9796b60226750
hovercard-subject-tagpull_request:378712271
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/487/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dea39fc5fc87002e2391c0e5103d463724fe890134c7a24242801b9a7505738e/feast-dev/feast/pull/487
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dea39fc5fc87002e2391c0e5103d463724fe890134c7a24242801b9a7505738e/feast-dev/feast/pull/487
og:image:altWhat this PR does / why we need it: Moves the spotless:check Maven goal to execute after tests compile, but before test executes the tests. This way the check will be run on CI, which runs mvn test...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameches
hostnamegithub.com
expected-hostnamegithub.com
Nonec049b65ec7e54cbf2521f5a560b6527714c612b0bd169188e2ea6e16f83bd5f4
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release87b137883e35e2766c3d0f6a257c4044f6390b83
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/487#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F487
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F487
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/487
Reloadhttps://github.com/feast-dev/feast/pull/487
Reloadhttps://github.com/feast-dev/feast/pull/487
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 181 https://github.com/feast-dev/feast/issues
Pull requests 69 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast/pull/487#issue-comment-box
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Fail Spotless formatting check before tests execute https://github.com/feast-dev/feast/pull/487#top
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Conversation 9 https://github.com/feast-dev/feast/pull/487
Commits 2 https://github.com/feast-dev/feast/pull/487/commits
Checks 0 https://github.com/feast-dev/feast/pull/487/checks
Files changed https://github.com/feast-dev/feast/pull/487/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/487
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
https://github.com/ches
cheshttps://github.com/ches
Feb 23, 2020https://github.com/feast-dev/feast/pull/487#issue-569504258
Please reload this pagehttps://github.com/feast-dev/feast/pull/487
a lot of noisy, unrelated changes come into reviewhttps://github.com/gojek/feast/pull/466#issuecomment-583329347
Please reload this pagehttps://github.com/feast-dev/feast/pull/487
cheshttps://github.com/ches
February 23, 2020 21:03https://github.com/feast-dev/feast/pull/487#commits-pushed-cf29060
https://github.com/ches
Fail formatting check before tests executehttps://github.com/feast-dev/feast/pull/487/commits/cf2906000105cca71a914aaf614088e035616f2b
cf29060https://github.com/feast-dev/feast/pull/487/commits/cf2906000105cca71a914aaf614088e035616f2b
https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.htmlhttps://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html
https://github.com/ches
Apply spotless formattinghttps://github.com/feast-dev/feast/pull/487/commits/ec0a6da4d35e9ad44aa9177c865769f938917025
ec0a6dahttps://github.com/feast-dev/feast/pull/487/commits/ec0a6da4d35e9ad44aa9177c865769f938917025
https://github.com/ches
cheshttps://github.com/ches
kind/housekeeping https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Fhousekeeping
Feb 23, 2020https://github.com/feast-dev/feast/pull/487#event-3063460137
https://github.com/ches
cheshttps://github.com/ches
davidheryantohttps://github.com/davidheryanto
khorshuhenghttps://github.com/khorshuheng
pradithyahttps://github.com/pradithya
woophttps://github.com/woop
zhilingchttps://github.com/zhilingc
code ownershttps://github.com/feast-dev/feast/blob/aec7979f2986e56d7be525cc6b27a1eeb786d501/.github/CODEOWNERS#L4
February 23, 2020 14:33https://github.com/feast-dev/feast/pull/487#event-3063460140
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
size/M https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FM
Feb 23, 2020https://github.com/feast-dev/feast/pull/487#event-3063460268
https://github.com/davidheryanto
davidheryantohttps://github.com/davidheryanto
Feb 24, 2020https://github.com/feast-dev/feast/pull/487#issuecomment-590174812
Please reload this pagehttps://github.com/feast-dev/feast/pull/487
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
davidheryantohttps://github.com/davidheryanto
Feb 24, 2020https://github.com/feast-dev/feast/pull/487#event-3064145885
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
Feb 24, 2020https://github.com/feast-dev/feast/pull/487#event-3064145897
https://github.com/ches
cheshttps://github.com/ches
Feb 24, 2020https://github.com/feast-dev/feast/pull/487#issuecomment-590277833
@davidheryantohttps://github.com/davidheryanto
Please reload this pagehttps://github.com/feast-dev/feast/pull/487
https://github.com/davidheryanto
davidheryantohttps://github.com/davidheryanto
Feb 24, 2020https://github.com/feast-dev/feast/pull/487#issuecomment-590283138
Please reload this pagehttps://github.com/feast-dev/feast/pull/487
https://github.com/ches
cheshttps://github.com/ches
Feb 24, 2020https://github.com/feast-dev/feast/pull/487#issuecomment-590339470
pull request processhttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
#466https://github.com/feast-dev/feast/pull/466
Please reload this pagehttps://github.com/feast-dev/feast/pull/487
https://github.com/woop
woophttps://github.com/woop
Feb 24, 2020https://github.com/feast-dev/feast/pull/487#issuecomment-590594382
pull request processhttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
#466https://github.com/feast-dev/feast/pull/466
@cheshttps://github.com/ches
http://prow.feast.ai/command-helphttp://prow.feast.ai/command-help
Please reload this pagehttps://github.com/feast-dev/feast/pull/487
https://github.com/woop
woophttps://github.com/woop
Feb 24, 2020https://github.com/feast-dev/feast/pull/487#issuecomment-590594750
Please reload this pagehttps://github.com/feast-dev/feast/pull/487
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Feb 24, 2020https://github.com/feast-dev/feast/pull/487#issuecomment-590594780
cheshttps://github.com/gojek/feast/pull/487
woophttps://github.com/gojek/feast/pull/487#issuecomment-590594750
herehttps://go.k8s.io/bot-commands?repo=gojek%2Ffeast
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/gojek/feast/blob/master/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast/pull/487
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
Feb 24, 2020https://github.com/feast-dev/feast/pull/487#event-3067343036
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
6363540https://github.com/feast-dev/feast/commit/636354092c3967c4b89d4c345ffc281f9f7c592d
Feb 24, 2020https://github.com/feast-dev/feast/pull/487#event-3067345092
https://github.com/ches
cheshttps://github.com/ches
February 25, 2020 02:08https://github.com/feast-dev/feast/pull/487#event-3067690612
https://github.com/ches
cheshttps://github.com/ches
Feb 25, 2020https://github.com/feast-dev/feast/pull/487#issuecomment-590646297
http://prow.feast.ai/command-helphttp://prow.feast.ai/command-help
@davidheryantohttps://github.com/davidheryanto
Please reload this pagehttps://github.com/feast-dev/feast/pull/487
https://github.com/ches
cheshttps://github.com/ches
Feb 25, 2020https://github.com/feast-dev/feast/pull/487#issuecomment-590651654
Please reload this pagehttps://github.com/feast-dev/feast/pull/487
the other dochttps://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#the-code-review-process
Please reload this pagehttps://github.com/feast-dev/feast/pull/487
davidheryantohttps://github.com/davidheryanto
Feb 26, 2020 https://github.com/feast-dev/feast/pull/487#ref-commit-f745d82
https://github.com/ches
https://github.com/davidheryanto
Fail Spotless formatting check before tests execute (https://github.com/davidheryanto/feast/commit/f745d82bf54453c353bf217f5e45c97d402e6587
feast-dev#487https://github.com/feast-dev/feast/pull/487
)https://github.com/davidheryanto/feast/commit/f745d82bf54453c353bf217f5e45c97d402e6587
f745d82https://github.com/davidheryanto/feast/commit/f745d82bf54453c353bf217f5e45c97d402e6587
https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.htmlhttps://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html
6363540https://github.com/davidheryanto/feast/commit/636354092c3967c4b89d4c345ffc281f9f7c592d
zhilingchttps://github.com/zhilingc
Feb 26, 2020 https://github.com/feast-dev/feast/pull/487#ref-commit-601033f
https://github.com/ches
https://github.com/zhilingc
Fail Spotless formatting check before tests execute (https://github.com/feast-dev/feast/commit/601033fa4ba60cb5ca445b3ebeba5b6655cc04ee
#487https://github.com/feast-dev/feast/pull/487
)https://github.com/feast-dev/feast/commit/601033fa4ba60cb5ca445b3ebeba5b6655cc04ee
601033fhttps://github.com/feast-dev/feast/commit/601033fa4ba60cb5ca445b3ebeba5b6655cc04ee
https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.htmlhttps://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html
6363540https://github.com/feast-dev/feast/commit/636354092c3967c4b89d4c345ffc281f9f7c592d
v0.3 backport: Fail Spotless check before tests #516 https://github.com/feast-dev/feast/pull/516
Code Standards / Linting checked & applied consistently for all langs #526 https://github.com/feast-dev/feast/issues/526
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F487
https://github.com/davidheryanto
davidheryanto https://github.com/davidheryanto
https://github.com/khorshuheng
khorshuheng https://github.com/khorshuheng
https://github.com/pradithya
pradithya https://github.com/pradithya
https://github.com/woop
woop https://github.com/woop
https://github.com/zhilingc
zhilingc https://github.com/zhilingc
https://github.com/davidheryanto
davidheryanto https://github.com/davidheryanto
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
kind/housekeeping https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Fhousekeeping
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
size/M https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FM
Please reload this pagehttps://github.com/feast-dev/feast/pull/487
https://github.com/ches
https://github.com/davidheryanto
https://github.com/woop
https://github.com/feast-ci-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.