| route-pattern | /:user_id/:repository/pull/:id/commits/:range(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:1cdd2483-7e4d-f48a-010d-159fbcb3c5c0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D36E:1AB486:BFBDCD:10A379B:6993423A |
| html-safe-nonce | 6526109bd4920217c7f3eba4fa5a84b424f4447cfb6d5635d21fc68458a10a67 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzZFOjFBQjQ4NjpCRkJEQ0Q6MTBBMzc5Qjo2OTkzNDIzQSIsInZpc2l0b3JfaWQiOiI1MzcyODgyNjQ4ODY2OTY0MDI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 04fdb1ad9d472b9c57a86521a72f33e4eee9ab877492115dce0d01ec08014402 |
| hovercard-subject-tag | pull_request:2171901990 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111 |
| twitter:image | https://avatars.githubusercontent.com/u/4163062?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4163062?s=400&v=4 |
| og:image:alt | What this PR does / why we need it:
This PR introduces the Milvus Vector Database into Feast. This integration enhances the capability of Feast to handle and store vector embeddings, along with tra... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1bae9c7d08ea14e1ee9576041777790e900aa7d28044a68c6b15fb7dc65e3f07 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ad48c1033c0f050997cf91138185bc19229a2f07 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F4751%2Fcommits%2F22bac8ba7e6b48f5290f4051d9ca831bc9513111 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F4751%2Fcommits%2F22bac8ba7e6b48f5290f4051d9ca831bc9513111 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111 |
| Reload | https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111 |
| Reload | https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111 |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
188
| https://github.com/feast-dev/feast/issues |
|
Pull requests
73
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| franciscojavierarceo | https://github.com/franciscojavierarceo |
| master | https://github.com/feast-dev/feast/tree/master |
| milvus-vector-db | https://github.com/feast-dev/feast/tree/milvus-vector-db |
|
Conversation
3
| https://github.com/feast-dev/feast/pull/4751 |
|
Commits
33
| https://github.com/feast-dev/feast/pull/4751/commits |
|
Checks
23
| https://github.com/feast-dev/feast/pull/4751/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/4751/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111 |
|
feat: Add Milvus Vector Database Implementation
| https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111#top |
|
Show all changes
33 commits
| https://github.com/feast-dev/feast/pull/4751/files |
|
ab7d4fb
merged rebase
franciscojavierarceo Dec 9, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/ab7d4fba2c65b455927274e233c6f305e09cef4b |
|
a6c9005
adding configuration
franciscojavierarceo Nov 11, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/a6c900572f78885c63101cfdef42a1f992b78b3b |
|
b61b965
updated
franciscojavierarceo Nov 12, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/b61b965648af2b975c1076ef14be385310c79121 |
|
88bca02
changed things and linted
franciscojavierarceo Nov 15, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/88bca02ef18292136223c8433f2850859d0388c5 |
|
81bd84a
adding updated builds
franciscojavierarceo Nov 15, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/81bd84a2903148fd7fe3093a7f6ab4afce1fabcb |
|
083fe67
adding repo config
franciscojavierarceo Nov 20, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/083fe670f20c98de59b80df181efd18d66afd118 |
|
fcf32d9
updated
franciscojavierarceo Nov 25, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/fcf32d9161f59911893cac8017000300c34ea475 |
|
662119a
renaming test and adding milvus to integration test
franciscojavierarceo Nov 27, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/662119a610c1c7d00d963beaaa47ef38db352381 |
|
4a7edd8
not quite working but have milvus talking
franciscojavierarceo Nov 27, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/4a7edd8e00938f9c69e00659f900b3bca43ed86b |
|
4c16c0b
updated tests
franciscojavierarceo Dec 1, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/4c16c0b72aa64dd03543a407aeac166d0910252c |
|
fabac18
apply() method now works
franciscojavierarceo Dec 2, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/fabac181b32c4bf5b2fb6a27695a9310f2f30dd3 |
|
2ee74c5
updated setup
franciscojavierarceo Dec 9, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/2ee74c5e4c8ffdcefda464802475ad39021549a8 |
|
1859e76
checking in progresss...getting there
franciscojavierarceo Dec 13, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/1859e7690b76d8252a1a932c0182a4a22cf22f12 |
|
35557ce
making some progress
franciscojavierarceo Dec 14, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/35557ce7d141080c7e6b841a5a3ff67e49c50914 |
|
c54309a
partially running
franciscojavierarceo Dec 15, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/c54309a0779439ee4f6149a30cb17aac123002dc |
|
0094e27
checking in progress...finding issues still
franciscojavierarceo Dec 16, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/0094e271ff32af84b30344efb53aef75b35e0c0c |
|
25a065e
have the apply working
franciscojavierarceo Dec 16, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/25a065e94d8fff8cee72bcf5fdd02be2b7ba33aa |
|
f1a92e0
adjusting some type issues
franciscojavierarceo Dec 16, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/f1a92e00653690e14970b37a5e86feccf6936b56 |
|
3282a05
updated and removed test
franciscojavierarceo Dec 16, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/3282a05e2eab8c519f0b9df5cab87cb4e18b7985 |
|
2dee462
have things behaving with the enviornment arg
franciscojavierarceo Dec 17, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/2dee46298ae2e2ba12b34d31f96cdc44c33f754e |
|
be8c5bc
updated milvus
franciscojavierarceo Dec 17, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/be8c5bc04513c5446624c584baabd1f90b853c8c |
|
dbc11e2
almost have retrieval working, having to make a lot of changes to onl…
franciscojavierarceo Dec 18, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/dbc11e29d98f863e9ce15aec94778a92a8424031 |
|
37d93f1
almost have deserialization from the search results done
franciscojavierarceo Dec 19, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/37d93f1264aa0a692a11ff5c5696265793efd9e7 |
|
67ad688
got the retrieval working now too :D
franciscojavierarceo Dec 19, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/67ad68866dcd48b55144a81c43a4e8d602b2d0ca |
|
d1c15cf
updates to fix linter and new signature for all implementations
franciscojavierarceo Dec 20, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/d1c15cff2c147b6304b150eeb948d3a432fc8865 |
|
6d94d7a
linter
franciscojavierarceo Dec 20, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/6d94d7acde75bcb3485ea780e3748d2cf0883391 |
|
fe518ed
more linting
franciscojavierarceo Dec 20, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/fe518ed9cda3909f071fd97f9946a1dcc80ba58e |
|
a639013
Removing some unnecessary code
franciscojavierarceo Dec 20, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/a639013d5cbc301b3eedf664e4c7c1c1ded5f4bd |
|
c91681f
removing change to setup
franciscojavierarceo Dec 20, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/c91681f4f1bf8475bdfd0265f848e33e5ad01e90 |
|
bd5ff48
adding sphinx docs
franciscojavierarceo Dec 20, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/bd5ff480b2a73a6dda4b8ecfa240f3cf9d609deb |
|
32c9a9f
adjusting workflow
franciscojavierarceo Dec 23, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/32c9a9fa817509b71620a987fda2e3c3050767b0 |
|
22bac8b
adding logging to debug
franciscojavierarceo Dec 23, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111 |
|
134b908
changing to vectordb environment
franciscojavierarceo Dec 23, 2024
| https://github.com/feast-dev/feast/pull/4751/commits/134b908595d36a50831bb4d86a23f1d9f6991a6a |
|
Clear filters
| https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111 |
| Please reload this page | https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111 |
| Please reload this page | https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111 |
|
Prev
| https://github.com/feast-dev/feast/pull/4751/commits/32c9a9fa817509b71620a987fda2e3c3050767b0 |
|
Next
| https://github.com/feast-dev/feast/pull/4751/commits/134b908595d36a50831bb4d86a23f1d9f6991a6a |
| Please reload this page | https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111 |
|
| https://github.com/franciscojavierarceo |
| franciscojavierarceo | https://github.com/feast-dev/feast/commits?author=franciscojavierarceo |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/tests/integration/online_store/test_universal_online.py | https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111#diff-4f3e62ecf7f09cabe95c2e4536bab2ac159c0a64967dabe46517f423d6a49923 |
|
View file
| https://github.com/feast-dev/feast/blob/22bac8ba7e6b48f5290f4051d9ca831bc9513111/sdk/python/tests/integration/online_store/test_universal_online.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/4751/commits/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111#diff-4f3e62ecf7f09cabe95c2e4536bab2ac159c0a64967dabe46517f423d6a49923 |
|
| https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111#diff-4f3e62ecf7f09cabe95c2e4536bab2ac159c0a64967dabe46517f423d6a49923 |
| Please reload this page | https://github.com/feast-dev/feast/pull/4751/commits/22bac8ba7e6b48f5290f4051d9ca831bc9513111 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |