René's URL Explorer Experiment


Title: Allow use of secure gRPC in Feast Python client. by Yanson · Pull Request #459 · feast-dev/feast · GitHub

Open Graph Title: Allow use of secure gRPC in Feast Python client. by Yanson · Pull Request #459 · feast-dev/feast

X Title: Allow use of secure gRPC in Feast Python client. by Yanson · Pull Request #459 · feast-dev/feast

Description: What this PR does / why we need it: Since #458 enables provisioning of an nginx ingress with TLS, when connecting from outside the cluster, secure gRPC is required. Which issue(s) this PR fixes: N/A Does this PR introduce a user-facing change?: If Feast Core or Serving gRPC APIs are listening on port 443, the Feast Client will default to enabling client-side TLS. If using non-secure gRPC on port 443, explicitly set the secure flag to false when constructing the client.

Open Graph Description: What this PR does / why we need it: Since #458 enables provisioning of an nginx ingress with TLS, when connecting from outside the cluster, secure gRPC is required. Which issue(s) this PR fixes: N...

X Description: What this PR does / why we need it: Since #458 enables provisioning of an nginx ingress with TLS, when connecting from outside the cluster, secure gRPC is required. Which issue(s) this PR fixes: N...

Opengraph URL: https://github.com/feast-dev/feast/pull/459

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:28525397-6ac9-a784-127e-bf22e75cc539
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC62:3451C3:2498736:3118A65:697AC28D
html-safe-nonce0a2a545802e7c7f6e20c3f30f8923123bba35c92d929b27b4292dd4545be830f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzYyOjM0NTFDMzoyNDk4NzM2OjMxMThBNjU6Njk3QUMyOEQiLCJ2aXNpdG9yX2lkIjoiOTE1MjY2MjgyODA5NDI0MzQ3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8643c13718ff04ff1ee888042ba91b45abf435348234322973209612afa554f9
hovercard-subject-tagpull_request:370971672
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/459/files
twitter:imagehttps://avatars.githubusercontent.com/u/6860163?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6860163?s=400&v=4
og:image:altWhat this PR does / why we need it: Since #458 enables provisioning of an nginx ingress with TLS, when connecting from outside the cluster, secure gRPC is required. Which issue(s) this PR fixes: N...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None37b00135a01848812420158e49744eb9715c1ef534ee4552f790d6ef33807fc2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release78685bd12c01954e3a0e08fc52173e9b3e48215d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/459/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F459%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F459%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/459/files
Reloadhttps://github.com/feast-dev/feast/pull/459/files
Reloadhttps://github.com/feast-dev/feast/pull/459/files
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 183 https://github.com/feast-dev/feast/issues
Pull requests 68 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Yanson:secure_grpc_clienthttps://github.com/Yanson/feast/tree/secure_grpc_client
Conversation 10 https://github.com/feast-dev/feast/pull/459
Commits 3 https://github.com/feast-dev/feast/pull/459/commits
Checks 0 https://github.com/feast-dev/feast/pull/459/checks
Files changed https://github.com/feast-dev/feast/pull/459/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/459/files
Allow use of secure gRPC in Feast Python client. https://github.com/feast-dev/feast/pull/459/files#top
Show all changes 3 commits https://github.com/feast-dev/feast/pull/459/files
ac24a8b Allow use of secure gRPC in Feast Python client. Yanson Feb 4, 2020 https://github.com/feast-dev/feast/pull/459/commits/ac24a8bf3d130510fbcaf6f8a14c5c566c2be10b
b10d771 Add tests for secure gRPC in Python client. Yanson Feb 17, 2020 https://github.com/feast-dev/feast/pull/459/commits/b10d771b1cda2f70ab88c894bb5849f4ebba3c34
746efa1 Merge branch 'master-yanson' into secure_grpc_client Yanson Feb 25, 2020 https://github.com/feast-dev/feast/pull/459/commits/746efa1d428c1112c1c582269a9a39fbda4c6314
Clear filters https://github.com/feast-dev/feast/pull/459/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/459/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/459/files
client.py https://github.com/feast-dev/feast/pull/459/files#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379
requirements-ci.txt https://github.com/feast-dev/feast/pull/459/files#diff-14fa068ad6d2973b90558bad797205f309318c26a7f732aba0be2af1ddd0dfab
localhost.crt https://github.com/feast-dev/feast/pull/459/files#diff-0640ac762d8f5ca088a90ffa3bfd476b39cd265f64bd061491dc4e797ac48f92
localhost.key https://github.com/feast-dev/feast/pull/459/files#diff-99c2814b0fdb8ac1a76dbf204375ba1ae89381514e8cb8a96d524fb1af332f55
localhost.pem https://github.com/feast-dev/feast/pull/459/files#diff-13e15ef438e5df5eb17f8cebfd4f1f5acf5d7d6ff6f6d8b7e7e1dce49525053b
test_client.py https://github.com/feast-dev/feast/pull/459/files#diff-dd9aaf4113915b368515057d8c42402d3ba8ed6614985497d58887982304e3ca
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/client.pyhttps://github.com/feast-dev/feast/pull/459/files#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379
View file https://github.com/Yanson/feast/blob/746efa1d428c1112c1c582269a9a39fbda4c6314/sdk/python/feast/client.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/459/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/459/files#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379
https://github.com/feast-dev/feast/pull/459/files#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379
https://github.com/feast-dev/feast/pull/459/files#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379
https://github.com/feast-dev/feast/pull/459/files#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379
https://github.com/feast-dev/feast/pull/459/files#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379
https://github.com/feast-dev/feast/pull/459/files#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379
https://github.com/feast-dev/feast/pull/459/files#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379
https://github.com/feast-dev/feast/pull/459/files#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379
https://github.com/feast-dev/feast/pull/459/files#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379
https://github.com/feast-dev/feast/pull/459/files#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379
https://github.com/feast-dev/feast/pull/459/files#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379
https://github.com/feast-dev/feast/pull/459/files#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/requirements-ci.txthttps://github.com/feast-dev/feast/pull/459/files#diff-14fa068ad6d2973b90558bad797205f309318c26a7f732aba0be2af1ddd0dfab
View file https://github.com/Yanson/feast/blob/746efa1d428c1112c1c582269a9a39fbda4c6314/sdk/python/requirements-ci.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/459/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/459/files#diff-14fa068ad6d2973b90558bad797205f309318c26a7f732aba0be2af1ddd0dfab
https://github.com/feast-dev/feast/pull/459/files#diff-14fa068ad6d2973b90558bad797205f309318c26a7f732aba0be2af1ddd0dfab
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/data/localhost.crthttps://github.com/feast-dev/feast/pull/459/files#diff-0640ac762d8f5ca088a90ffa3bfd476b39cd265f64bd061491dc4e797ac48f92
View file https://github.com/Yanson/feast/blob/746efa1d428c1112c1c582269a9a39fbda4c6314/sdk/python/tests/data/localhost.crt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/459/{{ revealButtonHref }}
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/data/localhost.keyhttps://github.com/feast-dev/feast/pull/459/files#diff-99c2814b0fdb8ac1a76dbf204375ba1ae89381514e8cb8a96d524fb1af332f55
View file https://github.com/Yanson/feast/blob/746efa1d428c1112c1c582269a9a39fbda4c6314/sdk/python/tests/data/localhost.key
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/459/{{ revealButtonHref }}
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/data/localhost.pemhttps://github.com/feast-dev/feast/pull/459/files#diff-13e15ef438e5df5eb17f8cebfd4f1f5acf5d7d6ff6f6d8b7e7e1dce49525053b
View file https://github.com/Yanson/feast/blob/746efa1d428c1112c1c582269a9a39fbda4c6314/sdk/python/tests/data/localhost.pem
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/459/{{ revealButtonHref }}
Please reload this pagehttps://github.com/feast-dev/feast/pull/459/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.