| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cfbcbf81-44fa-48a0-e78f-9538a0994d7b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E3D2:99189:D3E054:127BFFF:697B5B1E |
| html-safe-nonce | a3755105fe66818974a8c8b37b0f0a4ee09016947be8141a2d3145dec96644aa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0QyOjk5MTg5OkQzRTA1NDoxMjdCRkZGOjY5N0I1QjFFIiwidmlzaXRvcl9pZCI6IjQ3OTQzOTI3MTc3ODgxNDIzNjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c014a79c8e172a9586c115bb7efaf19ea1738b5a78e0b182697943cc68a1d007 |
| hovercard-subject-tag | pull_request:369188154 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/451/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/75d8175ddcb0261248fdedf9d1aa8eb8f46140499bdace4e46b14cae4e7f15b4/feast-dev/feast/pull/451 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/75d8175ddcb0261248fdedf9d1aa8eb8f46140499bdace4e46b14cae4e7f15b4/feast-dev/feast/pull/451 |
| og:image:alt | What this PR does / why we need it:
Upgrade Feast to next LTS - Java 11 - since Java 8 is outdated and no longer supported.
Our internal build and testing of Feast has been on Java 11 all along, so... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Yanson |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7eed3e20c41f6c464df945b1f353a52c450ca1653f4697d4ebcc58c2adc5868a |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b059c4725f1b62cc8534bdab4092fd840e833907 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/451#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F451 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F451 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/451 |
| Reload | https://github.com/feast-dev/feast/pull/451 |
| Reload | https://github.com/feast-dev/feast/pull/451 |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
182
| https://github.com/feast-dev/feast/issues |
|
Pull requests
67
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/feast-dev/feast/pull/451#issue-comment-box |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| Yanson:java11 | https://github.com/Yanson/feast/tree/java11 |
|
Upgrade to Java 11
| https://github.com/feast-dev/feast/pull/451#top |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| Yanson:java11 | https://github.com/Yanson/feast/tree/java11 |
|
Conversation
18
| https://github.com/feast-dev/feast/pull/451 |
|
Commits
2
| https://github.com/feast-dev/feast/pull/451/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/451/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/451/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
|
| https://github.com/Yanson |
| Yanson | https://github.com/Yanson |
| Jan 30, 2020 | https://github.com/feast-dev/feast/pull/451#issue-557631865 |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
|
| https://github.com/Yanson |
| Upgrade to Java 11 | https://github.com/feast-dev/feast/pull/451/commits/20b00b0893920b2bc9b0aed08ae75abbd4e9c3b1 |
| 20b00b0 | https://github.com/feast-dev/feast/pull/451/commits/20b00b0893920b2bc9b0aed08ae75abbd4e9c3b1 |
| https://github.com/Yanson |
| Yanson | https://github.com/Yanson |
| davidheryanto | https://github.com/davidheryanto |
| khorshuheng | https://github.com/khorshuheng |
| pradithya | https://github.com/pradithya |
| woop | https://github.com/woop |
| zhilingc | https://github.com/zhilingc |
| code owners | https://github.com/feast-dev/feast/blob/1b47ac422f72ca06b8852277453bb4d1e7f4f366/.github/CODEOWNERS#L4 |
| January 30, 2020 17:06 | https://github.com/feast-dev/feast/pull/451#event-2994171116 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| Jan 30, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-580355266 |
| @Yanson | https://github.com/Yanson |
| gojek | https://github.com/orgs/gojek/people |
| join the org | https://github.com/orgs/gojek/people |
| here | https://go.k8s.io/bot-commands?repo=gojek%2Ffeast |
| here | https://git.k8s.io/community/contributors/guide/pull-requests.md |
| kubernetes/test-infra | https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue: |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
needs-ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-ok-to-test |
|
size/M
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FM |
| Jan 30, 2020 | https://github.com/feast-dev/feast/pull/451#event-2994172051 |
| https://github.com/Yanson |
| Yanson | https://github.com/Yanson |
| Jan 30, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-580356599 |
| @woop | https://github.com/woop |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| woop | https://github.com/woop |
| Jan 30, 2020 | https://github.com/feast-dev/feast/pull/451#event-2994182387 |
| https://github.com/khorshuheng |
| khorshuheng | https://github.com/khorshuheng |
| Jan 31, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-580551212 |
| @Yanson | https://github.com/Yanson |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/khorshuheng |
| khorshuheng | https://github.com/khorshuheng |
| Jan 31, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-580551238 |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
|
needs-ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-ok-to-test |
| Jan 31, 2020 | https://github.com/feast-dev/feast/pull/451#event-2995588668 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Jan 31, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-580588815 |
| @khorshuheng | https://github.com/khorshuheng |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/Yanson |
| Yanson | https://github.com/Yanson |
| Jan 31, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-580685430 |
| http://prow.feast.ai/prowjob?prowjob=9bf59c76-43cf-11ea-9ebf-e2420cc0b547 | http://prow.feast.ai/prowjob?prowjob=9bf59c76-43cf-11ea-9ebf-e2420cc0b547 |
| https://github.com/gojek/feast/pull/451/files#diff-7c2c7257959d7451ee7dc1de3fb9889e | https://github.com/gojek/feast/pull/451/files#diff-7c2c7257959d7451ee7dc1de3fb9889e |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/Yanson |
| Yanson | https://github.com/Yanson |
| Jan 31, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-580687651 |
| @Yanson | https://github.com/Yanson |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/Yanson |
| Yanson | https://github.com/Yanson |
| Feb 3, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-581310789 |
| @woop | https://github.com/woop |
| @khorshuheng | https://github.com/khorshuheng |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/khorshuheng |
| khorshuheng | https://github.com/khorshuheng |
| Feb 3, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-581376262 |
| @woop | https://github.com/woop |
| @khorshuheng | https://github.com/khorshuheng |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Feb 9, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-583793902 |
| @Yanson | https://github.com/Yanson |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Feb 11, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-584488001 |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Feb 11, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-584512132 |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
|
| https://github.com/davidheryanto |
| Add support for Java 1.8 in Maven enforcer | https://github.com/feast-dev/feast/pull/451/commits/190e6050f166228cd4866564d3637f5f1d6c2391 |
| 190e605 | https://github.com/feast-dev/feast/pull/451/commits/190e6050f166228cd4866564d3637f5f1d6c2391 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Feb 11, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-584524709 |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Feb 11, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-584528954 |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
| Feb 11, 2020 | https://github.com/feast-dev/feast/pull/451#event-3025634368 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| Feb 11, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-584528982 |
| woop | https://github.com/gojek/feast/pull/451#issuecomment-584528954 |
| Yanson | https://github.com/gojek/feast/pull/451 |
| here | https://go.k8s.io/bot-commands?repo=gojek%2Ffeast |
| here | https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process |
| OWNERS | https://github.com/gojek/feast/blob/master/OWNERS |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
| Feb 11, 2020 | https://github.com/feast-dev/feast/pull/451#event-3025634494 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| 8e227d5 | https://github.com/feast-dev/feast/commit/8e227d55da8aec7b7249029672cadfb3399fe36c |
| Feb 11, 2020 | https://github.com/feast-dev/feast/pull/451#event-3025636608 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| Feb 11, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-584529254 |
| @Yanson | https://github.com/Yanson |
| this | https://github.com/gojek/feast/pull/451 |
| here | https://git.k8s.io/community/contributors/guide/pull-requests.md |
| kubernetes/test-infra | https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue: |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/Yanson |
| Yanson | https://github.com/Yanson |
| February 11, 2020 09:48 | https://github.com/feast-dev/feast/pull/451#event-3025828918 |
| https://github.com/khorshuheng |
| khorshuheng | https://github.com/khorshuheng |
|
Feb 13, 2020
| https://github.com/feast-dev/feast/pull/451#ref-pullrequest-564458302 |
|
Use Java 8 SDK for branch 3.0 / 4.0 and Java 11 for master
#473
| https://github.com/feast-dev/feast/pull/473 |
| https://github.com/ches |
| ches | https://github.com/ches |
| Mar 7, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-596079551 |
| vendors are supporting OpenJDK 8 until at least 2023 | https://access.redhat.com/articles/1299013 |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/ches |
| ches | https://github.com/ches |
|
Mar 7, 2020
| https://github.com/feast-dev/feast/pull/451#ref-issue-577353742 |
|
To cross build, or not to cross build Ingestion
#517
| https://github.com/feast-dev/feast/issues/517 |
| https://github.com/Yanson |
| Yanson | https://github.com/Yanson |
| Mar 9, 2020 | https://github.com/feast-dev/feast/pull/451#issuecomment-596455281 |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
| https://github.com/ches |
| ches | https://github.com/ches |
|
May 21, 2020
| https://github.com/feast-dev/feast/pull/451#ref-pullrequest-622256946 |
|
Restore Feast Java SDK and Ingestion compatibility with Java 8 runtimes
#722
| https://github.com/feast-dev/feast/pull/722 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F451 |
|
| https://github.com/davidheryanto |
|
davidheryanto
| https://github.com/davidheryanto |
|
| https://github.com/khorshuheng |
|
khorshuheng
| https://github.com/khorshuheng |
|
| https://github.com/pradithya |
|
pradithya
| https://github.com/pradithya |
|
| https://github.com/woop |
|
woop
| https://github.com/woop |
|
| https://github.com/zhilingc |
|
zhilingc
| https://github.com/zhilingc |
|
| https://github.com/woop |
|
woop
| https://github.com/woop |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
|
size/M
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FM |
| Please reload this page | https://github.com/feast-dev/feast/pull/451 |
|
| https://github.com/Yanson |
|
| https://github.com/feast-ci-bot |
|
| https://github.com/khorshuheng |
|
| https://github.com/woop |
|
| https://github.com/ches |
|
| https://github.com/davidheryanto |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |