| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a0e4c46d-a0c4-cc0e-4dd4-f0d6ef2d4c72 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DA56:20614C:3583246:47A8FE1:697AF815 |
| html-safe-nonce | fe4aa30141b0841b5d5894d07e756873f33a456b0e9b9460c03c41683d1d45a8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTU2OjIwNjE0QzozNTgzMjQ2OjQ3QThGRTE6Njk3QUY4MTUiLCJ2aXNpdG9yX2lkIjoiNjM4MTQ4NjY4MTAyNjY1NjI3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9a3678febc78fae37001dd0023c0df8154c739a1c71203b168ea53524b2bd4f2 |
| hovercard-subject-tag | pull_request:368894214 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/450/files |
| twitter:image | https://avatars.githubusercontent.com/u/5300554?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5300554?s=400&v=4 |
| og:image:alt | What this PR does / why we need it:
This PR extends FeatureSet, Entity and Feature class in Python SDK so they can contain constraints defined in the Schema from Tensorflow metadata:
https://github... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7ce8ed0a54c4730aeca4e6abacfc6490365fc42e25480b86883054df3f9181c8 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d7bfc78137af9a4828305e52ab993fce981d7085 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/450/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F450%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F450%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/450/files |
| Reload | https://github.com/feast-dev/feast/pull/450/files |
| Reload | https://github.com/feast-dev/feast/pull/450/files |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
183
| https://github.com/feast-dev/feast/issues |
|
Pull requests
68
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| davidheryanto:update-python-sdk-import-export-tf-metadata-schema | https://github.com/davidheryanto/feast/tree/update-python-sdk-import-export-tf-metadata-schema |
|
Conversation
21
| https://github.com/feast-dev/feast/pull/450 |
|
Commits
12
| https://github.com/feast-dev/feast/pull/450/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/450/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/450/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/450/files |
|
Update Python SDK so FeatureSet can import Schema from Tensorflow metadata
| https://github.com/feast-dev/feast/pull/450/files#top |
|
Show all changes
12 commits
| https://github.com/feast-dev/feast/pull/450/files |
|
bfd8682
Add skeleton for update/get schema in FeatureSet
davidheryanto Jan 29, 2020
| https://github.com/feast-dev/feast/pull/450/commits/bfd8682e74378fbd6283a95d63000d751dd0712b |
|
756533e
Add update_schema method to FeatureSet
davidheryanto Jan 30, 2020
| https://github.com/feast-dev/feast/pull/450/commits/756533eba9bea39844a9ccb66d1541f594a574e3 |
|
9abd082
Update error message when domain ref is missing from top level schema
davidheryanto Jan 30, 2020
| https://github.com/feast-dev/feast/pull/450/commits/9abd0820a1eb43a13cdd6db79fe5fde09ed0b84b |
|
b2b7783
Add more assertion in test_update_schema before updating schema
davidheryanto Jan 30, 2020
| https://github.com/feast-dev/feast/pull/450/commits/b2b7783177589870671aeeb7f90e9ade75717789 |
|
4574f72
Fix conflicting versions in package requirements
davidheryanto Jan 30, 2020
| https://github.com/feast-dev/feast/pull/450/commits/4574f72493cf56e2de4810715a8d4999ef828af9 |
|
5029550
Add export_schema method to export schema from FeatureSet
davidheryanto Jan 31, 2020
| https://github.com/feast-dev/feast/pull/450/commits/5029550afe85ef35ca98a58de19b04222abbd29d |
|
dc39ca7
Add exporting of Tensorflow metadata schema from FeatureSet.
davidheryanto Feb 2, 2020
| https://github.com/feast-dev/feast/pull/450/commits/dc39ca77422f4221d0d738398fa68472663544df |
|
57dfa02
Remove changes to mypy generated codes
davidheryanto Mar 1, 2020
| https://github.com/feast-dev/feast/pull/450/commits/57dfa0206661088d4dabeb9fddf0d45eb56f18f9 |
|
bfd282d
Revert changes to packages version in requirements-ci and setup.py
davidheryanto Mar 4, 2020
| https://github.com/feast-dev/feast/pull/450/commits/bfd282d538874853216f10b56d4debda97c1da13 |
|
dcd6e19
Remove 'schema' param in 'from_proto' method in Entity and Feature.
davidheryanto Mar 13, 2020
| https://github.com/feast-dev/feast/pull/450/commits/dcd6e19feff687578cb8f7b3592f2a27c294c253 |
|
6af74c6
Fix rebase errors, apply black
Apr 10, 2020
| https://github.com/feast-dev/feast/pull/450/commits/6af74c6876294dc4870f25b05bc416ee8928c789 |
|
d12aead
Remove unnecessary imports
Apr 10, 2020
| https://github.com/feast-dev/feast/pull/450/commits/d12aeadd8926fd9f80457486c1b8f36ab9169679 |
|
Clear filters
| https://github.com/feast-dev/feast/pull/450/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/450/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/450/files |
|
entity.py
| https://github.com/feast-dev/feast/pull/450/files#diff-c0f89d7c348e7d395df4f432d417bea219403127ac9e94e0c126bcf707bf39bb |
|
feature.py
| https://github.com/feast-dev/feast/pull/450/files#diff-08365ff20f581911a17c52ed2e1f691728dc2a7ab11f3af4a43f8117d00285d9 |
|
feature_set.py
| https://github.com/feast-dev/feast/pull/450/files#diff-c32f70797a62b07c798f70588ea978ae3b173562af7a42f796df1fe761060c9b |
|
field.py
| https://github.com/feast-dev/feast/pull/450/files#diff-d07bc9ff25c891d1cf5359ba1bb16ce4f06a1c742193f9f37ca80f34f378c121 |
|
yaml.py
| https://github.com/feast-dev/feast/pull/450/files#diff-fd26da27e860f0eaff906dadd37db441556600acf9ad533e2485d400d1973b66 |
|
value_type.py
| https://github.com/feast-dev/feast/pull/450/files#diff-f3d0ec2fb5bc0c650efbcfca1ea337172a7e6cca900f7fefb47d150287387780 |
|
path_pb2.py
| https://github.com/feast-dev/feast/pull/450/files#diff-8065504fe774ca3f932ce83f8e19049198ae69e997f6b262ae5b4aba3415d6ae |
|
path_pb2.pyi
| https://github.com/feast-dev/feast/pull/450/files#diff-abaf89e7ca9d7eab3af9833da4f4295cdd249f36fa37048aecc3aa3cea134557 |
|
schema_pb2.py
| https://github.com/feast-dev/feast/pull/450/files#diff-9102f3c01016ecf6d4041a1906755d2685c912c73c0bc9b53b8c6140a6faba18 |
|
schema_pb2.pyi
| https://github.com/feast-dev/feast/pull/450/files#diff-75142273842c79685993c7f798e31b9b76b0e52a982f09a5eddededa676e514b |
|
bikeshare_feature_set.yaml
| https://github.com/feast-dev/feast/pull/450/files#diff-ecf304a2383ca6a97badd808ead8cef3b182773f09f6656a0979998b6d351da8 |
|
bikeshare_schema.json
| https://github.com/feast-dev/feast/pull/450/files#diff-6a9d679b37c0842c0498a1927ac7dc0d28fb716e18b7da6157a2df24e89770a1 |
|
test_feature_set.py
| https://github.com/feast-dev/feast/pull/450/files#diff-c6d82f9bebad23ffc7412206b4e42d97401092aad390ba298558d774968e2463 |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/feast/entity.py | https://github.com/feast-dev/feast/pull/450/files#diff-c0f89d7c348e7d395df4f432d417bea219403127ac9e94e0c126bcf707bf39bb |
|
View file
| https://github.com/davidheryanto/feast/blob/d12aeadd8926fd9f80457486c1b8f36ab9169679/sdk/python/feast/entity.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/450/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/450/files#diff-c0f89d7c348e7d395df4f432d417bea219403127ac9e94e0c126bcf707bf39bb |
|
| https://github.com/feast-dev/feast/pull/450/files#diff-c0f89d7c348e7d395df4f432d417bea219403127ac9e94e0c126bcf707bf39bb |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/feast/feature.py | https://github.com/feast-dev/feast/pull/450/files#diff-08365ff20f581911a17c52ed2e1f691728dc2a7ab11f3af4a43f8117d00285d9 |
|
View file
| https://github.com/davidheryanto/feast/blob/d12aeadd8926fd9f80457486c1b8f36ab9169679/sdk/python/feast/feature.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/450/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/450/files#diff-08365ff20f581911a17c52ed2e1f691728dc2a7ab11f3af4a43f8117d00285d9 |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/feast/feature_set.py | https://github.com/feast-dev/feast/pull/450/files#diff-c32f70797a62b07c798f70588ea978ae3b173562af7a42f796df1fe761060c9b |
|
View file
| https://github.com/davidheryanto/feast/blob/d12aeadd8926fd9f80457486c1b8f36ab9169679/sdk/python/feast/feature_set.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/450/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/450/files#diff-c32f70797a62b07c798f70588ea978ae3b173562af7a42f796df1fe761060c9b |
|
| https://github.com/feast-dev/feast/pull/450/files#diff-c32f70797a62b07c798f70588ea978ae3b173562af7a42f796df1fe761060c9b |
|
| https://github.com/feast-dev/feast/pull/450/files#diff-c32f70797a62b07c798f70588ea978ae3b173562af7a42f796df1fe761060c9b |
|
| https://github.com/feast-dev/feast/pull/450/files#diff-c32f70797a62b07c798f70588ea978ae3b173562af7a42f796df1fe761060c9b |
|
| https://github.com/feast-dev/feast/pull/450/files#diff-c32f70797a62b07c798f70588ea978ae3b173562af7a42f796df1fe761060c9b |
|
| https://github.com/feast-dev/feast/pull/450/files#diff-c32f70797a62b07c798f70588ea978ae3b173562af7a42f796df1fe761060c9b |
| Please reload this page | https://github.com/feast-dev/feast/pull/450/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |