| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f3cfb819-7188-a57a-f63d-e8ef42edb2ee |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BD06:354D8D:C55C25:10A2A1A:69795E9F |
| html-safe-nonce | 4773c42cae1fab9994f17320f9e6d628f78c04543a1f5f763ea217e92c727941 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDA2OjM1NEQ4RDpDNTVDMjU6MTBBMkExQTo2OTc5NUU5RiIsInZpc2l0b3JfaWQiOiI5MTcwNDQwOTgxOTI3NTE3ODU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c08dce9691b87bab1f00fe22d73d8f4b220389da380d4fb017721f1bc79e37e7 |
| hovercard-subject-tag | pull_request:367793166 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/446/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/dc320ed2d68ed3b8cdb20ffabc339931b32b17a0b4189b2b60db336726df2190/feast-dev/feast/pull/446 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dc320ed2d68ed3b8cdb20ffabc339931b32b17a0b4189b2b60db336726df2190/feast-dev/feast/pull/446 |
| og:image:alt | What this PR does / why we need it:
Keeping batch retrieval consistent with online retrieval.
Which issue(s) this PR fixes:
Fixes #440
Does this PR introduce a user-facing change?:
NONE |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zhilingc |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9a8bf5f945fd86e846085fae394d6ac589cd2b86e05b57ef553a6b80c16b1a62 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9288b06021ef9d084f8b8be8a0cb129d8dc9b93a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/446#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F446 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F446 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/446 |
| Reload | https://github.com/feast-dev/feast/pull/446 |
| Reload | https://github.com/feast-dev/feast/pull/446 |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
181
| https://github.com/feast-dev/feast/issues |
|
Pull requests
68
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/feast-dev/feast/pull/446#issue-comment-box |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| zhilingc:max-age | https://github.com/zhilingc/feast/tree/max-age |
|
Allow users not to set max age for batch retrieval
| https://github.com/feast-dev/feast/pull/446#top |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| zhilingc:max-age | https://github.com/zhilingc/feast/tree/max-age |
|
Conversation
3
| https://github.com/feast-dev/feast/pull/446 |
|
Commits
2
| https://github.com/feast-dev/feast/pull/446/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/446/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/446/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/446 |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
|
| https://github.com/zhilingc |
| zhilingc | https://github.com/zhilingc |
| Jan 28, 2020 | https://github.com/feast-dev/feast/pull/446#issue-555942052 |
| #440 | https://github.com/feast-dev/feast/issues/440 |
| Please reload this page | https://github.com/feast-dev/feast/pull/446 |
| Allow users not to set max age for batch retrieval | https://github.com/feast-dev/feast/pull/446/commits/4eafd364aba9d3ece0b5d448dcd3e20a48a7c8b2 |
| 4eafd36 | https://github.com/feast-dev/feast/pull/446/commits/4eafd364aba9d3ece0b5d448dcd3e20a48a7c8b2 |
| https://github.com/zhilingc |
| zhilingc | https://github.com/zhilingc |
| davidheryanto | https://github.com/davidheryanto |
| khorshuheng | https://github.com/khorshuheng |
| pradithya | https://github.com/pradithya |
| woop | https://github.com/woop |
| code owners | https://github.com/feast-dev/feast/blob/b6455e2d98ab5601779afde9f4385c37da81754b/.github/CODEOWNERS#L4 |
| January 28, 2020 02:09 | https://github.com/feast-dev/feast/pull/446#event-2984051102 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| Jan 28, 2020 | https://github.com/feast-dev/feast/pull/446#issuecomment-579046020 |
| zhilingc | https://github.com/gojek/feast/pull/446 |
| here | https://go.k8s.io/bot-commands?repo=gojek%2Ffeast |
| here | https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process |
| OWNERS | https://github.com/gojek/feast/blob/master/OWNERS |
| Please reload this page | https://github.com/feast-dev/feast/pull/446 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
size/M
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FM |
| Jan 28, 2020 | https://github.com/feast-dev/feast/pull/446#event-2984051239 |
| Fix typo in test assertion | https://github.com/feast-dev/feast/pull/446/commits/9f071e591cce3e78f2e49cb238809a275ce4d208 |
| 9f071e5 | https://github.com/feast-dev/feast/pull/446/commits/9f071e591cce3e78f2e49cb238809a275ce4d208 |
| https://github.com/zhilingc |
| zhilingc | https://github.com/zhilingc |
| woop | https://github.com/woop |
| Jan 28, 2020 | https://github.com/feast-dev/feast/pull/446#event-2984129450 |
| https://github.com/khorshuheng |
| khorshuheng | https://github.com/khorshuheng |
| Jan 28, 2020 | https://github.com/feast-dev/feast/pull/446#issuecomment-579058200 |
| Please reload this page | https://github.com/feast-dev/feast/pull/446 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| khorshuheng | https://github.com/khorshuheng |
| Jan 28, 2020 | https://github.com/feast-dev/feast/pull/446#event-2984130856 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
| Jan 28, 2020 | https://github.com/feast-dev/feast/pull/446#event-2984130880 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| 1645938 | https://github.com/feast-dev/feast/commit/164593891747c43648fa29f1d22b301284ce17fc |
| Jan 28, 2020 | https://github.com/feast-dev/feast/pull/446#event-2984131005 |
| https://github.com/ches |
| ches | https://github.com/ches |
|
backport-candidate
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Abackport-candidate |
| Jan 28, 2020 | https://github.com/feast-dev/feast/pull/446#event-2984259591 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Feb 2, 2020 | https://github.com/feast-dev/feast/pull/446#issuecomment-581090595 |
| Please reload this page | https://github.com/feast-dev/feast/pull/446 |
| khorshuheng | https://github.com/khorshuheng |
|
Feb 14, 2020
| https://github.com/feast-dev/feast/pull/446#ref-commit-84cbf22 |
| Allow users not to set max age for batch retrieval ( | https://github.com/khorshuheng/feast/commit/84cbf22ed8f2854439da37ffd2bd16b82c0fce80 |
| feast-dev#446 | https://github.com/feast-dev/feast/pull/446 |
| ) | https://github.com/khorshuheng/feast/commit/84cbf22ed8f2854439da37ffd2bd16b82c0fce80 |
| 84cbf22 | https://github.com/khorshuheng/feast/commit/84cbf22ed8f2854439da37ffd2bd16b82c0fce80 |
| https://github.com/khorshuheng |
| khorshuheng | https://github.com/khorshuheng |
|
Feb 14, 2020
| https://github.com/feast-dev/feast/pull/446#ref-pullrequest-565069944 |
|
Release 0.4.5
#477
| https://github.com/feast-dev/feast/pull/477 |
| khorshuheng | https://github.com/khorshuheng |
|
Feb 14, 2020
| https://github.com/feast-dev/feast/pull/446#ref-commit-584be65 |
|
| https://github.com/khorshuheng |
| Allow users not to set max age for batch retrieval ( | https://github.com/feast-dev/feast/commit/584be6595a9c05ad5b2ed76bad2218af7dcb69af |
| #446 | https://github.com/feast-dev/feast/pull/446 |
| ) | https://github.com/feast-dev/feast/commit/584be6595a9c05ad5b2ed76bad2218af7dcb69af |
| 584be65 | https://github.com/feast-dev/feast/commit/584be6595a9c05ad5b2ed76bad2218af7dcb69af |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F446 |
|
| https://github.com/davidheryanto |
|
davidheryanto
| https://github.com/davidheryanto |
|
| https://github.com/khorshuheng |
|
khorshuheng
| https://github.com/khorshuheng |
|
| https://github.com/pradithya |
|
pradithya
| https://github.com/pradithya |
|
| https://github.com/woop |
|
woop
| https://github.com/woop |
|
| https://github.com/woop |
|
woop
| https://github.com/woop |
|
| https://github.com/khorshuheng |
|
khorshuheng
| https://github.com/khorshuheng |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
backport-candidate
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Abackport-candidate |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
|
size/M
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FM |
|
Max age should be optional
| https://github.com/feast-dev/feast/issues/440 |
| Please reload this page | https://github.com/feast-dev/feast/pull/446 |
|
| https://github.com/zhilingc |
|
| https://github.com/feast-ci-bot |
|
| https://github.com/khorshuheng |
|
| https://github.com/woop |
|
| https://github.com/ches |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |