| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:41581c16-e167-cb8f-5c34-8c7995743c1d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E14C:2EBC14:468E14D:600E32C:69709A8C |
| html-safe-nonce | 120686b4381cfb712249f121fe931669cd29ed1b033f31bf11000bd7f25b3b5b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTRDOjJFQkMxNDo0NjhFMTREOjYwMEUzMkM6Njk3MDlBOEMiLCJ2aXNpdG9yX2lkIjoiMzkxNjgwMDgwMDM2MDI3NDU3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4b3050619cd077c1be2114e053d1b53f3d64d78e76598f8875e97ab0b5bf33ee |
| hovercard-subject-tag | pull_request:2033471070 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/4438/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9b6507d8cdce688bb8c0ef2bb0d9f7bcb2c1f427ff84bb2c62bedee763a87a7f/feast-dev/feast/pull/4438 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9b6507d8cdce688bb8c0ef2bb0d9f7bcb2c1f427ff84bb2c62bedee763a87a7f/feast-dev/feast/pull/4438 |
| og:image:alt | What this PR does / why we need it:
This PR enforces the protobuf version in the build system so that it is compatible with the runtime dependency
Which issue(s) this PR fixes:
Fixes #4437
Misc
The... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Atry |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7d6181066430cc06553c8396ca201e194ae33cb9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/4438#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F4438 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F4438 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/4438 |
| Reload | https://github.com/feast-dev/feast/pull/4438 |
| Reload | https://github.com/feast-dev/feast/pull/4438 |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.6k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
176
| https://github.com/feast-dev/feast/issues |
|
Pull requests
58
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/feast-dev/feast/security |
| Please reload this page | https://github.com/feast-dev/feast/pull/4438 |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/feast-dev/feast/pull/4438#issue-comment-box |
| tokoko | https://github.com/tokoko |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| Atry:build-system-protobuf-version | https://github.com/Atry/feast/tree/build-system-protobuf-version |
|
build: Set a proper build-system protobuf version
| https://github.com/feast-dev/feast/pull/4438#top |
| tokoko | https://github.com/tokoko |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| Atry:build-system-protobuf-version | https://github.com/Atry/feast/tree/build-system-protobuf-version |
|
Conversation
1
| https://github.com/feast-dev/feast/pull/4438 |
|
Commits
1
| https://github.com/feast-dev/feast/pull/4438/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/4438/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/4438/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/4438 |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
|
| https://github.com/Atry |
| Atry | https://github.com/Atry |
| Aug 23, 2024 | https://github.com/feast-dev/feast/pull/4438#issue-2482349435 |
| #4437 | https://github.com/feast-dev/feast/issues/4437 |
| feast/setup.py | https://github.com/feast-dev/feast/blob/0a48f7bb436febb0171c78a559a577eedeff421f/setup.py#L46 |
| 0a48f7b | https://github.com/feast-dev/feast/commit/0a48f7bb436febb0171c78a559a577eedeff421f |
| Please reload this page | https://github.com/feast-dev/feast/pull/4438 |
| https://github.com/Atry |
| Atry | https://github.com/Atry |
| Aug 23, 2024 | https://github.com/feast-dev/feast/pull/4438#event-13988339182 |
| https://github.com/Atry |
| Atry | https://github.com/Atry |
| Aug 23, 2024 | https://github.com/feast-dev/feast/pull/4438#event-13988346892 |
| https://github.com/Atry |
| Atry | https://github.com/Atry |
| Aug 23, 2024 | https://github.com/feast-dev/feast/pull/4438#event-13988347537 |
|
| https://github.com/Atry |
| build: force the protobuf version in the build system so that it is c… | https://github.com/feast-dev/feast/pull/4438/commits/13ae351ff078854c3366556784a82e08c1ba8e15 |
| 13ae351 | https://github.com/feast-dev/feast/pull/4438/commits/13ae351ff078854c3366556784a82e08c1ba8e15 |
| https://github.com/Atry |
| Atry | https://github.com/Atry |
| force-pushed | https://github.com/feast-dev/feast/compare/23e3c9b9da3293c2d432d25ef630a3a1b1d9956d..13ae351ff078854c3366556784a82e08c1ba8e15 |
| 23e3c9b | https://github.com/feast-dev/feast/commit/23e3c9b9da3293c2d432d25ef630a3a1b1d9956d |
| 13ae351 | https://github.com/feast-dev/feast/commit/13ae351ff078854c3366556784a82e08c1ba8e15 |
|
Compare
| https://github.com/feast-dev/feast/compare/23e3c9b9da3293c2d432d25ef630a3a1b1d9956d..13ae351ff078854c3366556784a82e08c1ba8e15 |
| August 23, 2024 05:48 | https://github.com/feast-dev/feast/pull/4438#event-13988394260 |
| https://github.com/franciscojavierarceo |
| franciscojavierarceo | https://github.com/franciscojavierarceo |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
| Aug 23, 2024 | https://github.com/feast-dev/feast/pull/4438#event-13990848937 |
| https://github.com/tokoko |
| tokoko | https://github.com/tokoko |
|
Aug 23, 2024
| https://github.com/feast-dev/feast/pull/4438#pullrequestreview-2257621898 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/4438/files/13ae351ff078854c3366556784a82e08c1ba8e15 |
| tokoko | https://github.com/tokoko |
| https://github.com/feast-dev/feast/pull/4438#pullrequestreview-2257621898 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/4438 |
| https://github.com/tokoko |
| tokoko | https://github.com/tokoko |
| a2460d9 | https://github.com/feast-dev/feast/commit/a2460d9e65a406cc3641552e0c2f497eeb2fc735 |
| Aug 23, 2024 | https://github.com/feast-dev/feast/pull/4438#event-13995381769 |
| https://github.com/brijesh-vora-sp |
| brijesh-vora-sp | https://github.com/brijesh-vora-sp |
|
Aug 26, 2024
| https://github.com/feast-dev/feast/pull/4438#ref-pullrequest-2483942937 |
|
Sync master to release
sailpoint/feast#20
| https://github.com/sailpoint/feast/pull/20 |
| brijesh-vora-sp | https://github.com/brijesh-vora-sp |
|
Aug 27, 2024
| https://github.com/feast-dev/feast/pull/4438#ref-commit-44baad9 |
|
| https://github.com/brijesh-vora-sp |
|
| https://github.com/franciscojavierarceo |
|
| https://github.com/danbaron63 |
|
| https://github.com/shuchu |
|
| https://github.com/tokoko |
|
| https://github.com/EXPEbdodla |
|
| https://github.com/dandawg |
|
| https://github.com/tchughesiv |
|
| https://github.com/dmartinol |
|
| https://github.com/tmihalac |
|
| https://github.com/redhatHameed |
|
| https://github.com/lokeshrangineni |
|
| https://github.com/Atry |
| Sync master to release ( | https://github.com/sailpoint/feast/commit/44baad921c74acc8d316d21415dee1692677867e |
| #20 | https://github.com/sailpoint/feast/pull/20 |
| ) | https://github.com/sailpoint/feast/commit/44baad921c74acc8d316d21415dee1692677867e |
| 44baad9 | https://github.com/sailpoint/feast/commit/44baad921c74acc8d316d21415dee1692677867e |
| feast-dev#4412 | https://github.com/feast-dev/feast/pull/4412 |
| feast-dev#4410 | https://github.com/feast-dev/feast/pull/4410 |
| feast-dev#4413 | https://github.com/feast-dev/feast/pull/4413 |
| feast-dev#4416 | https://github.com/feast-dev/feast/pull/4416 |
| feast-dev#4406 | https://github.com/feast-dev/feast/pull/4406 |
| feast-dev#4419 | https://github.com/feast-dev/feast/pull/4419 |
| feast-dev#4420 | https://github.com/feast-dev/feast/pull/4420 |
| feast-dev#4422 | https://github.com/feast-dev/feast/pull/4422 |
| feast-dev#4423 | https://github.com/feast-dev/feast/pull/4423 |
| feast-dev#4424 | https://github.com/feast-dev/feast/pull/4424 |
| feast-dev#4421 | https://github.com/feast-dev/feast/pull/4421 |
| feast-dev#4380 | https://github.com/feast-dev/feast/pull/4380 |
| feast-dev#36 | https://github.com/feast-dev/feast/issues/36 |
| feast-dev#40 | https://github.com/feast-dev/feast/pull/40 |
| feast-dev#54 | https://github.com/feast-dev/feast/pull/54 |
| feast-dev#54 | https://github.com/feast-dev/feast/pull/54 |
| feast-dev#54 | https://github.com/feast-dev/feast/pull/54 |
| feast-dev#64 | https://github.com/feast-dev/feast/issues/64 |
| feast-dev#71 | https://github.com/feast-dev/feast/pull/71 |
| feast-dev#68 | https://github.com/feast-dev/feast/pull/68 |
| feast-dev#4430 | https://github.com/feast-dev/feast/pull/4430 |
| feast-dev#4407 | https://github.com/feast-dev/feast/pull/4407 |
| feast-dev#4438 | https://github.com/feast-dev/feast/pull/4438 |
| feast-dev#4442 | https://github.com/feast-dev/feast/pull/4442 |
| feast-dev#4429 | https://github.com/feast-dev/feast/pull/4429 |
| feast-dev#4436 | https://github.com/feast-dev/feast/pull/4436 |
| feast-dev#4443 | https://github.com/feast-dev/feast/pull/4443 |
| feast-dev#4445 | https://github.com/feast-dev/feast/pull/4445 |
| feast-dev#4434 | https://github.com/feast-dev/feast/pull/4434 |
| cburroughs | https://github.com/cburroughs |
|
Aug 30, 2024
| https://github.com/feast-dev/feast/pull/4438#ref-commit-718db01 |
|
| https://github.com/cburroughs |
| build: explicit protobuf build version; consistent build/setup deps | https://github.com/cburroughs/feast/commit/718db01c765c9b30c7a26008f9f68b76b3de8206 |
| 718db01 | https://github.com/cburroughs/feast/commit/718db01c765c9b30c7a26008f9f68b76b3de8206 |
| feast-dev#4437 | https://github.com/feast-dev/feast/issues/4437 |
| feast-dev#4438 | https://github.com/feast-dev/feast/pull/4438 |
| cburroughs | https://github.com/cburroughs |
|
Aug 30, 2024
| https://github.com/feast-dev/feast/pull/4438#ref-commit-2aa12ea |
|
| https://github.com/cburroughs |
| build: explicit protobuf build version; consistent build/setup deps | https://github.com/cburroughs/feast/commit/2aa12ea9f97cd5458f8c595ed1f68c54e637d368 |
| 2aa12ea | https://github.com/cburroughs/feast/commit/2aa12ea9f97cd5458f8c595ed1f68c54e637d368 |
| feast-dev#4437 | https://github.com/feast-dev/feast/issues/4437 |
| feast-dev#4438 | https://github.com/feast-dev/feast/pull/4438 |
| https://github.com/cburroughs |
| cburroughs | https://github.com/cburroughs |
|
Aug 30, 2024
| https://github.com/feast-dev/feast/pull/4438#ref-pullrequest-2497877834 |
|
build: Explicit protobuf build version; consistent build/setup deps
#4472
| https://github.com/feast-dev/feast/pull/4472 |
| tokoko | https://github.com/tokoko |
|
Sep 3, 2024
| https://github.com/feast-dev/feast/pull/4438#ref-commit-8fef194 |
|
| https://github.com/cburroughs |
| build: Explicit protobuf build version; consistent build/setup deps ( | https://github.com/feast-dev/feast/commit/8fef1944d9b6acb6b47a80d0fab27a724cf1bc5c |
| #… | https://github.com/feast-dev/feast/pull/4472 |
| 8fef194 | https://github.com/feast-dev/feast/commit/8fef1944d9b6acb6b47a80d0fab27a724cf1bc5c |
| …4472 | https://github.com/feast-dev/feast/pull/4472 |
| #4437 | https://github.com/feast-dev/feast/issues/4437 |
| #4438 | https://github.com/feast-dev/feast/pull/4438 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F4438 |
|
| https://github.com/tokoko |
|
tokoko
| https://github.com/tokoko |
|
| https://github.com/feast-dev/feast/pull/4438/files/13ae351ff078854c3366556784a82e08c1ba8e15 |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
|
ImportError: cannot import name 'runtime_version' from 'google.protobuf'
| https://github.com/feast-dev/feast/issues/4437 |
| Please reload this page | https://github.com/feast-dev/feast/pull/4438 |
|
| https://github.com/Atry |
|
| https://github.com/tokoko |
|
| https://github.com/franciscojavierarceo |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |