Title: Change RedisBackedJobService to use a connection pool by zhilingc · Pull Request #439 · feast-dev/feast · GitHub
Open Graph Title: Change RedisBackedJobService to use a connection pool by zhilingc · Pull Request #439 · feast-dev/feast
X Title: Change RedisBackedJobService to use a connection pool by zhilingc · Pull Request #439 · feast-dev/feast
Description: What this PR does / why we need it: Current implementation of connection to jobs redis is using a client that upon failure does not refresh its connection to the db - so if anything goes awry batch retrieval is unusable until the instance is restarted to manually establish a new connection with redis. This PR changes RedisBackedJobService to use a connection pool instead. Which issue(s) this PR fixes: N/A Does this PR introduce a user-facing change?: NONE
Open Graph Description: What this PR does / why we need it: Current implementation of connection to jobs redis is using a client that upon failure does not refresh its connection to the db - so if anything goes awry batch...
X Description: What this PR does / why we need it: Current implementation of connection to jobs redis is using a client that upon failure does not refresh its connection to the db - so if anything goes awry batch...
Opengraph URL: https://github.com/feast-dev/feast/pull/439
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6b5a2722-55d3-1d74-33b7-d2ddc1800320 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A778:92D06:CB7EF:12076A:697B290F |
| html-safe-nonce | 119ffcd0c0978f30d344037339dc0a3a316df180dd61069e012de43ba002b4e0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzc4OjkyRDA2OkNCN0VGOjEyMDc2QTo2OTdCMjkwRiIsInZpc2l0b3JfaWQiOiIzMDkxMzU5MTI3NDYxMTEyMDgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 431bb20a7abc6766d6cc5b082855501e627767c7b59904e3c17c2ab13cf6b45a |
| hovercard-subject-tag | pull_request:365074951 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/439/files |
| twitter:image | https://avatars.githubusercontent.com/u/15104168?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15104168?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: Current implementation of connection to jobs redis is using a client that upon failure does not refresh its connection to the db - so if anything goes awry batch... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 26ee438f0a804360f1b93f477a85a7932f8df33f19cc3cc6231e1782206b194a |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c845ccd48a615635f346dc49a2d3da3f5224a529 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width