René's URL Explorer Experiment


Title: Change RedisBackedJobService to use a connection pool by zhilingc · Pull Request #439 · feast-dev/feast · GitHub

Open Graph Title: Change RedisBackedJobService to use a connection pool by zhilingc · Pull Request #439 · feast-dev/feast

X Title: Change RedisBackedJobService to use a connection pool by zhilingc · Pull Request #439 · feast-dev/feast

Description: What this PR does / why we need it: Current implementation of connection to jobs redis is using a client that upon failure does not refresh its connection to the db - so if anything goes awry batch...

Open Graph Description: What this PR does / why we need it: Current implementation of connection to jobs redis is using a client that upon failure does not refresh its connection to the db - so if anything goes awry batch...

X Description: What this PR does / why we need it: Current implementation of connection to jobs redis is using a client that upon failure does not refresh its connection to the db - so if anything goes awry batch...

Opengraph URL: https://github.com/feast-dev/feast/pull/439

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9f87df01-df37-ea73-09a9-7c9ef5ce2fdc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCBD2:3BAA97:6EC1E8:9A367B:697A6A20
html-safe-nonce0195f263fb2c67ffd0b66124ad099f0fb2ce42985d185192842b9c64c98d99a2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkQyOjNCQUE5Nzo2RUMxRTg6OUEzNjdCOjY5N0E2QTIwIiwidmlzaXRvcl9pZCI6IjgzMDkwNzgwNzUxNjk3MjkwNTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7a446956a3d16dcbc446acea4904c5c21952b3b8ccdfae97ffbf3b1e07364ac3
hovercard-subject-tagpull_request:365074951
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/439/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/711442b36a43f0bd2fe97512a7770331238984958453b47e93423ff373009481/feast-dev/feast/pull/439
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/711442b36a43f0bd2fe97512a7770331238984958453b47e93423ff373009481/feast-dev/feast/pull/439
og:image:altWhat this PR does / why we need it: Current implementation of connection to jobs redis is using a client that upon failure does not refresh its connection to the db - so if anything goes awry batch...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezhilingc
hostnamegithub.com
expected-hostnamegithub.com
None4f4c032790588250388c2e36a0e1ea776c0a3f887d37d994e1ac3d7ea79d34ef
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release06b3a5a9a6214e1e06e508d250d778cbaf17c577
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/439#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F439
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F439
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/439
Reloadhttps://github.com/feast-dev/feast/pull/439
Reloadhttps://github.com/feast-dev/feast/pull/439
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 183 https://github.com/feast-dev/feast/issues
Pull requests 68 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast/pull/439#issue-comment-box
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
zhilingc:redis-conn-poolhttps://github.com/zhilingc/feast/tree/redis-conn-pool
Change RedisBackedJobService to use a connection pool https://github.com/feast-dev/feast/pull/439#top
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
zhilingc:redis-conn-poolhttps://github.com/zhilingc/feast/tree/redis-conn-pool
Conversation 9 https://github.com/feast-dev/feast/pull/439
Commits 6 https://github.com/feast-dev/feast/pull/439/commits
Checks 0 https://github.com/feast-dev/feast/pull/439/checks
Files changed https://github.com/feast-dev/feast/pull/439/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/439
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Jan 21, 2020https://github.com/feast-dev/feast/pull/439#issue-552600050
Please reload this pagehttps://github.com/feast-dev/feast/pull/439
Change job service connection to use a connection poolhttps://github.com/feast-dev/feast/pull/439/commits/8658ccb08a7b46f83e08adc685b38c5049954a18
8658ccbhttps://github.com/feast-dev/feast/pull/439/commits/8658ccb08a7b46f83e08adc685b38c5049954a18
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
pradithyahttps://github.com/pradithya
code ownerhttps://github.com/feast-dev/feast/blob/fe520a968e33da20de84a427f540f0bc41cf08b4/.github/CODEOWNERS#L7
January 21, 2020 03:13https://github.com/feast-dev/feast/pull/439#event-2964711230
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
size/M https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FM
Jan 21, 2020https://github.com/feast-dev/feast/pull/439#event-2964711348
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Jan 21, 2020https://github.com/feast-dev/feast/pull/439#event-2964711853
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
khorshuhenghttps://github.com/khorshuheng
January 21, 2020 03:13https://github.com/feast-dev/feast/pull/439#event-2964712202
January 21, 2020 12:10https://github.com/feast-dev/feast/pull/439#commits-pushed-1dbcdfd
Close connectionhttps://github.com/feast-dev/feast/pull/439/commits/1dbcdfd68c9ef490c70e6b0731d2c6c7ea33a3e6
1dbcdfdhttps://github.com/feast-dev/feast/pull/439/commits/1dbcdfd68c9ef490c70e6b0731d2c6c7ea33a3e6
Remove isConnected conditionhttps://github.com/feast-dev/feast/pull/439/commits/d2e81123f3da8b143c98e62a83ebf7728983e358
d2e8112https://github.com/feast-dev/feast/pull/439/commits/d2e81123f3da8b143c98e62a83ebf7728983e358
Add simple test to test that pool recovers broken connectionshttps://github.com/feast-dev/feast/pull/439/commits/98bf375f7c2f8b9123eb8d2f4bc9ae84ef5f1bf0
98bf375https://github.com/feast-dev/feast/pull/439/commits/98bf375f7c2f8b9123eb8d2f4bc9ae84ef5f1bf0
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
size/M https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FM
Jan 21, 2020https://github.com/feast-dev/feast/pull/439#event-2964946815
https://github.com/davidheryanto
davidheryantohttps://github.com/davidheryanto
Jan 21, 2020 https://github.com/feast-dev/feast/pull/439#pullrequestreview-345653193
View reviewed changes https://github.com/feast-dev/feast/pull/439/files/98bf375f7c2f8b9123eb8d2f4bc9ae84ef5f1bf0
serving/src/main/java/feast/serving/service/RedisBackedJobService.javahttps://github.com/feast-dev/feast/pull/439/files/d2e81123f3da8b143c98e62a83ebf7728983e358..98bf375f7c2f8b9123eb8d2f4bc9ae84ef5f1bf0#diff-b48e8f9c91a84885d5d53e68ffdc10dadcff6aaa24284ed117aaf278e3881934
Please reload this pagehttps://github.com/feast-dev/feast/pull/439
January 21, 2020 14:30https://github.com/feast-dev/feast/pull/439#commits-pushed-3a8f80e
Catch JedisExceptions separatelyhttps://github.com/feast-dev/feast/pull/439/commits/3a8f80e233904792577b5e91967604128768a6e4
3a8f80ehttps://github.com/feast-dev/feast/pull/439/commits/3a8f80e233904792577b5e91967604128768a6e4
Catch only JedisConnectionExceptionhttps://github.com/feast-dev/feast/pull/439/commits/b3a2cf5ca05740f43ed921bf5d81023dc758aee0
b3a2cf5https://github.com/feast-dev/feast/pull/439/commits/b3a2cf5ca05740f43ed921bf5d81023dc758aee0
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
Jan 21, 2020https://github.com/feast-dev/feast/pull/439#issuecomment-576543215
Please reload this pagehttps://github.com/feast-dev/feast/pull/439
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
khorshuhenghttps://github.com/khorshuheng
Jan 21, 2020https://github.com/feast-dev/feast/pull/439#event-2965033776
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
Jan 21, 2020https://github.com/feast-dev/feast/pull/439#event-2965033798
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
Jan 21, 2020https://github.com/feast-dev/feast/pull/439#issuecomment-576543304
Please reload this pagehttps://github.com/feast-dev/feast/pull/439
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
0a8987ehttps://github.com/feast-dev/feast/commit/0a8987e1668381231df3639e51ddac8abab1f307
Jan 21, 2020https://github.com/feast-dev/feast/pull/439#event-2965034441
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Jan 21, 2020https://github.com/feast-dev/feast/pull/439#issuecomment-576543331
khorshuhenghttps://github.com/gojek/feast/pull/439#issuecomment-576543304
zhilingchttps://github.com/gojek/feast/pull/439
herehttps://go.k8s.io/bot-commands?repo=gojek%2Ffeast
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/gojek/feast/blob/master/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast/pull/439
https://github.com/brandon733
brandon733https://github.com/brandon733
Jan 24, 2020https://github.com/feast-dev/feast/pull/439#issuecomment-578219141
Please reload this pagehttps://github.com/feast-dev/feast/pull/439
Please reload this pagehttps://github.com/feast-dev/feast/pull/439
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
Jan 25, 2020https://github.com/feast-dev/feast/pull/439#issuecomment-578367593
Please reload this pagehttps://github.com/feast-dev/feast/pull/439
https://github.com/brandon733
brandon733https://github.com/brandon733
Jan 27, 2020https://github.com/feast-dev/feast/pull/439#issuecomment-578822898
Please reload this pagehttps://github.com/feast-dev/feast/pull/439
https://docs.feast.dev/getting-started/installing-feast#minikubehttps://docs.feast.dev/getting-started/installing-feast#minikube
Please reload this pagehttps://github.com/feast-dev/feast/pull/439
khorshuhenghttps://github.com/khorshuheng
Feb 13, 2020 https://github.com/feast-dev/feast/pull/439#ref-commit-dcaccaa
Change RedisBackedJobService to use a connection pool (https://github.com/feast-dev/feast/commit/dcaccaab01692cafc4eb79d27af4e79f34800c78
#439https://github.com/feast-dev/feast/pull/439
)https://github.com/feast-dev/feast/commit/dcaccaab01692cafc4eb79d27af4e79f34800c78
dcaccaahttps://github.com/feast-dev/feast/commit/dcaccaab01692cafc4eb79d27af4e79f34800c78
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F439
https://github.com/davidheryanto
davidheryanto https://github.com/davidheryanto
https://github.com/feast-dev/feast/pull/439/files/98bf375f7c2f8b9123eb8d2f4bc9ae84ef5f1bf0
https://github.com/pradithya
pradithya https://github.com/pradithya
https://github.com/khorshuheng
khorshuheng https://github.com/khorshuheng
https://github.com/khorshuheng
khorshuheng https://github.com/khorshuheng
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
Please reload this pagehttps://github.com/feast-dev/feast/pull/439
https://github.com/zhilingc
https://github.com/khorshuheng
https://github.com/feast-ci-bot
https://github.com/brandon733
https://github.com/davidheryanto
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.