| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9e4f5c2e-c5b6-d1e7-ee5a-b678976beee8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DEEA:327374:187DCAC:2242A4E:6972770C |
| html-safe-nonce | be294974c76f014a1ab58876053227eb99d8ee4ed755130a95fccf0bc640a583 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUVBOjMyNzM3NDoxODdEQ0FDOjIyNDJBNEU6Njk3Mjc3MEMiLCJ2aXNpdG9yX2lkIjoiODM3MTA5ODcyNDUxNTQ4OTQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 75addbf4d9f414ff0fd13434ad8c5a69603e19344e066d3c89604aec26510bf4 |
| hovercard-subject-tag | pull_request:1721041503 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/3947/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b13e3d40ad4bb04889b6ef8425502ad046aba5a34b033c7ae51e27920e9b7a31/feast-dev/feast/pull/3947 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b13e3d40ad4bb04889b6ef8425502ad046aba5a34b033c7ae51e27920e9b7a31/feast-dev/feast/pull/3947 |
| og:image:alt | What this PR does / why we need it: mypy lint fixes, refer to: #3938
subset of mypy linting fixes when mypy version was upgraded in #3938.
The PR is getting alittle too long, so I'm breaking in... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bushwhackr |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3be355d8ea7ca74c4edec03a70ecaa8211862649e90886d88a4db13e6778e4c3 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4ae5b6c1e16519c3e3ad37a388f7cca2192a79a8 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/3947#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F3947 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F3947 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/3947 |
| Reload | https://github.com/feast-dev/feast/pull/3947 |
| Reload | https://github.com/feast-dev/feast/pull/3947 |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.6k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
181
| https://github.com/feast-dev/feast/issues |
|
Pull requests
64
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/feast-dev/feast/pull/3947#issue-comment-box |
| bushwhackr | https://github.com/bushwhackr |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| bushwhackr:bushwhackr/mypy | https://github.com/bushwhackr/feast/tree/bushwhackr/mypy |
|
chore: Refactoring to fix mypy linting
| https://github.com/feast-dev/feast/pull/3947#top |
| bushwhackr | https://github.com/bushwhackr |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| bushwhackr:bushwhackr/mypy | https://github.com/bushwhackr/feast/tree/bushwhackr/mypy |
|
Conversation
2
| https://github.com/feast-dev/feast/pull/3947 |
|
Commits
13
| https://github.com/feast-dev/feast/pull/3947/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/3947/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/3947/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/3947 |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
|
| https://github.com/bushwhackr |
| bushwhackr | https://github.com/bushwhackr |
| Feb 11, 2024 | https://github.com/feast-dev/feast/pull/3947#issue-2129108727 |
| #3938 | https://github.com/feast-dev/feast/pull/3938 |
| #3938 | https://github.com/feast-dev/feast/pull/3938 |
| Please reload this page | https://github.com/feast-dev/feast/pull/3947 |
| https://github.com/bushwhackr |
| bushwhackr | https://github.com/bushwhackr |
| kevjumba | https://github.com/kevjumba |
| niklasvm | https://github.com/niklasvm |
| sfc-gh-madkins | https://github.com/sfc-gh-madkins |
| sudohainguyen | https://github.com/sudohainguyen |
| younggyu-oh | https://github.com/younggyu-oh |
| code owners | https://github.com/feast-dev/feast/blob/4e450ad3b1b6d2f66fd87e07805bb57772390142/CODEOWNERS#L28 |
| February 11, 2024 18:23 | https://github.com/feast-dev/feast/pull/3947#event-11767838930 |
| https://github.com/bushwhackr |
| bushwhackr | https://github.com/bushwhackr |
| force-pushed | https://github.com/feast-dev/feast/compare/658354fd2a6d4ee3123b42185ba4838acaf4e5e7..275d16268b91a476c2d94f96090388b93c5826d6 |
| 658354f | https://github.com/feast-dev/feast/commit/658354fd2a6d4ee3123b42185ba4838acaf4e5e7 |
| 275d162 | https://github.com/feast-dev/feast/commit/275d16268b91a476c2d94f96090388b93c5826d6 |
|
Compare
| https://github.com/feast-dev/feast/compare/658354fd2a6d4ee3123b42185ba4838acaf4e5e7..275d16268b91a476c2d94f96090388b93c5826d6 |
| February 11, 2024 18:24 | https://github.com/feast-dev/feast/pull/3947#event-11767843232 |
| bushwhackr | https://github.com/bushwhackr |
| February 12, 2024 02:26 | https://github.com/feast-dev/feast/pull/3947#commits-pushed-68d18d2 |
|
| https://github.com/bushwhackr |
| allowing follow-imports + fixing on_demand_feature_view.py | https://github.com/feast-dev/feast/pull/3947/commits/68d18d2421f5af74e9ba8dd14fdd9474ee0ce93a |
| 68d18d2 | https://github.com/feast-dev/feast/pull/3947/commits/68d18d2421f5af74e9ba8dd14fdd9474ee0ce93a |
|
| https://github.com/bushwhackr |
| creating base type SnowflakeStoreConfig to fix circular imports | https://github.com/feast-dev/feast/pull/3947/commits/73bba2c62bf3b5af2c007f4a3ca08be00cf2d15e |
| 73bba2c | https://github.com/feast-dev/feast/pull/3947/commits/73bba2c62bf3b5af2c007f4a3ca08be00cf2d15e |
|
| https://github.com/bushwhackr |
| fixing circular imports | https://github.com/feast-dev/feast/pull/3947/commits/d80acd86424150397a7bba3912023622bca833fc |
| d80acd8 | https://github.com/feast-dev/feast/pull/3947/commits/d80acd86424150397a7bba3912023622bca833fc |
|
| https://github.com/bushwhackr |
| converting create_data_source to take in arbitrary arguments | https://github.com/feast-dev/feast/pull/3947/commits/3ecff669dc4f1c817c7a7804feca495f5ff35bae |
| 3ecff66 | https://github.com/feast-dev/feast/pull/3947/commits/3ecff669dc4f1c817c7a7804feca495f5ff35bae |
|
| https://github.com/bushwhackr |
| lint fix on base function create_online_store | https://github.com/feast-dev/feast/pull/3947/commits/39fb45b4c47c63df6a69e07b46c8a130fc80f35c |
| 39fb45b | https://github.com/feast-dev/feast/pull/3947/commits/39fb45b4c47c63df6a69e07b46c8a130fc80f35c |
|
| https://github.com/bushwhackr |
| lint fix on ingest_stream_feature_view | https://github.com/feast-dev/feast/pull/3947/commits/83818e065fe3dbe71f14a7379c7a865186d05ddc |
| 83818e0 | https://github.com/feast-dev/feast/pull/3947/commits/83818e065fe3dbe71f14a7379c7a865186d05ddc |
|
| https://github.com/bushwhackr |
| lint fixes in configuration | https://github.com/feast-dev/feast/pull/3947/commits/2fa14b7ea3fef74ac899ac0cf86f7fdf8a642702 |
| 2fa14b7 | https://github.com/feast-dev/feast/pull/3947/commits/2fa14b7ea3fef74ac899ac0cf86f7fdf8a642702 |
|
| https://github.com/bushwhackr |
| isort linting | https://github.com/feast-dev/feast/pull/3947/commits/a96c266b575f1895f1a6727b9df1af97700402b4 |
| a96c266 | https://github.com/feast-dev/feast/pull/3947/commits/a96c266b575f1895f1a6727b9df1af97700402b4 |
|
| https://github.com/bushwhackr |
| mypy checking of all files in sdk/python folder | https://github.com/feast-dev/feast/pull/3947/commits/f0f7fec79447d73b731238368c4958b690563638 |
| f0f7fec | https://github.com/feast-dev/feast/pull/3947/commits/f0f7fec79447d73b731238368c4958b690563638 |
| https://github.com/bushwhackr |
| bushwhackr | https://github.com/bushwhackr |
| force-pushed | https://github.com/feast-dev/feast/compare/275d16268b91a476c2d94f96090388b93c5826d6..f0f7fec79447d73b731238368c4958b690563638 |
| 275d162 | https://github.com/feast-dev/feast/commit/275d16268b91a476c2d94f96090388b93c5826d6 |
| f0f7fec | https://github.com/feast-dev/feast/commit/f0f7fec79447d73b731238368c4958b690563638 |
|
Compare
| https://github.com/feast-dev/feast/compare/275d16268b91a476c2d94f96090388b93c5826d6..f0f7fec79447d73b731238368c4958b690563638 |
| February 11, 2024 18:26 | https://github.com/feast-dev/feast/pull/3947#event-11767848056 |
|
| https://github.com/bushwhackr |
| checking only feast directory for mypy errors | https://github.com/feast-dev/feast/pull/3947/commits/28010b7861405c4f9a708b3afc8974defc90a5a0 |
| 28010b7 | https://github.com/feast-dev/feast/pull/3947/commits/28010b7861405c4f9a708b3afc8974defc90a5a0 |
| https://github.com/sudohainguyen |
| sudohainguyen | https://github.com/sudohainguyen |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
|
kind/techdebt
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Ftechdebt |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
kind/techdebt
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Ftechdebt |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
| Feb 12, 2024 | https://github.com/feast-dev/feast/pull/3947#event-11769492494 |
| bushwhackr | https://github.com/bushwhackr |
| February 13, 2024 16:30 | https://github.com/feast-dev/feast/pull/3947#commits-pushed-5dbe13d |
|
| https://github.com/bushwhackr |
| allow extras for FeastConfigBaseModel | https://github.com/feast-dev/feast/pull/3947/commits/5dbe13d8abcd33ce199aca9d22a38866d3f820cd |
| 5dbe13d | https://github.com/feast-dev/feast/pull/3947/commits/5dbe13d8abcd33ce199aca9d22a38866d3f820cd |
|
| https://github.com/bushwhackr |
| fixing tests | https://github.com/feast-dev/feast/pull/3947/commits/004949ddd1d63f42594dd323df99a6c44929e985 |
| 004949d | https://github.com/feast-dev/feast/pull/3947/commits/004949ddd1d63f42594dd323df99a6c44929e985 |
|
| https://github.com/bushwhackr |
| adding extra field for online store config | https://github.com/feast-dev/feast/pull/3947/commits/2696cc337b4a64983bc043b065b7c0d2a6c18cb7 |
| 2696cc3 | https://github.com/feast-dev/feast/pull/3947/commits/2696cc337b4a64983bc043b065b7c0d2a6c18cb7 |
| https://github.com/bushwhackr |
| bushwhackr | https://github.com/bushwhackr |
|
Feb 13, 2024
| https://github.com/feast-dev/feast/pull/3947#pullrequestreview-1877235792 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/3947/files/2696cc337b4a64983bc043b065b7c0d2a6c18cb7 |
| sdk/python/tests/integration/feature_repos/universal/data_source_creator.py | https://github.com/feast-dev/feast/pull/3947/files/2696cc337b4a64983bc043b065b7c0d2a6c18cb7#diff-86c1c3ec549ceedc698b563b598b4aa33e4af7f068f4f347a1a2087e0a7bf617 |
| bushwhackr | https://github.com/bushwhackr |
| Feb 13, 2024 | https://github.com/feast-dev/feast/pull/3947#discussion_r1487446019 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/3947 |
| https://github.com/bushwhackr |
| bushwhackr | https://github.com/bushwhackr |
| Feb 13, 2024 | https://github.com/feast-dev/feast/pull/3947#issuecomment-1940848721 |
| #3948 | https://github.com/feast-dev/feast/pull/3948 |
| Please reload this page | https://github.com/feast-dev/feast/pull/3947 |
| https://github.com/bushwhackr |
| bushwhackr | https://github.com/bushwhackr |
| Feb 13, 2024 | https://github.com/feast-dev/feast/pull/3947#event-11785425144 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F3947 |
|
| https://github.com/sfc-gh-madkins |
|
sfc-gh-madkins
| https://github.com/sfc-gh-madkins |
|
| https://github.com/niklasvm |
|
niklasvm
| https://github.com/niklasvm |
|
| https://github.com/kevjumba |
|
kevjumba
| https://github.com/kevjumba |
|
| https://github.com/younggyu-oh |
|
younggyu-oh
| https://github.com/younggyu-oh |
|
| https://github.com/sudohainguyen |
|
sudohainguyen
| https://github.com/sudohainguyen |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
| Please reload this page | https://github.com/feast-dev/feast/pull/3947 |
|
| https://github.com/bushwhackr |
|
| https://github.com/sudohainguyen |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |